nastra opened a new issue, #9845:
URL: https://github.com/apache/iceberg/issues/9845
### Feature Request / Improvement
Views are currently only supported by `SparkCatalog`. We should also add
support to `SparkSessionCatalog` and update `TestViews` to test against against
a `SparkSess
nastra opened a new issue, #9844:
URL: https://github.com/apache/iceberg/issues/9844
### Feature Request / Improvement
Similar to tables, we could support metadata tables for views. The ones that
come to mind are:
* `.versions` to show the view versions over time
* `.history` to
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1508618144
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2800,6 +3062,58 @@ components:
additionalProperties:
type: string
+PrePlanTableRequest:
+
tomtongue commented on issue #9085:
URL: https://github.com/apache/iceberg/issues/9085#issuecomment-1972684808
@nastra Thanks, sure it can avoid the duplicate efforts. Will list the test
files here.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
rahil-c commented on PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#issuecomment-1972681829
@jackye1995 @rdblue i rebased on the latest changes from
https://github.com/apache/iceberg/commit/bb53c3d4e0e27ac6706803c2371793ad2476ae04
Was wondering if you guys can review thi
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1508608763
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2068,6 +2162,145 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
+
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1508608297
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2068,6 +2162,145 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
+
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1508607907
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2068,6 +2162,145 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
+
rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1508607575
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2068,6 +2162,145 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
+
liurenjie1024 commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1508594423
##
crates/iceberg/src/file_record_batch_reader.rs:
##
Review Comment:
Given that most of these operations are arrow related, how about rename this
file i
Fokko commented on PR #485:
URL: https://github.com/apache/iceberg-python/pull/485#issuecomment-1972632541
@HonahX I think it was a PR that was not rebased to the main branch 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
himadripal commented on PR #484:
URL: https://github.com/apache/iceberg-python/pull/484#issuecomment-1972533570
locally all passed
```shell
(venv) hpal@HPals-MacBook-ProM1 apache-iceberg-python % poetry run
pre-commit run --all-files
trim trailing
whitespace
ZENOTME commented on PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#issuecomment-1972533382
I have added more tests. Feel free to tell me if there is still something
need to improve. @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the mess
bitsondatadev opened a new issue, #9842:
URL: https://github.com/apache/iceberg/issues/9842
#9779 changed to symlinks of formats that are still using the hugo markdown
and it broke the links.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
himadripal commented on PR #486:
URL: https://github.com/apache/iceberg-python/pull/486#issuecomment-1972523776
@Fokko @syun64 @flyrain @RussellSpitzer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
himadripal opened a new pull request, #486:
URL: https://github.com/apache/iceberg-python/pull/486
#479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
kevinjqliu commented on PR #289:
URL: https://github.com/apache/iceberg-python/pull/289#issuecomment-1972473935
@Fokko As we discussed in #293, let's not create yet another catalog.
I moved the changes back to `test_base.py` where the In-Memory catalog was
originally. This PR improves the
anupam-saini commented on PR #433:
URL: https://github.com/apache/iceberg-python/pull/433#issuecomment-1972462085
Now with Sort Order and Partition Spec updates, this PR has all the
necessary pieces for create-replace table operation and is ready for review.
@Fokko @syun64
--
This
liurenjie1024 commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1508447324
##
crates/iceberg/src/spec/values.rs:
##
@@ -70,6 +79,571 @@ pub enum PrimitiveLiteral {
Decimal(i128),
}
+/// Literal associated with its type. The va
jacksonrnewhouse commented on issue #225:
URL: https://github.com/apache/iceberg-rust/issues/225#issuecomment-1972389376
Just appending data would be sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
liurenjie1024 commented on issue #224:
URL: https://github.com/apache/iceberg-rust/issues/224#issuecomment-1972381561
> Is this block by #169? I could work on this after this pr is merged.
Hi, @Dysprosium0626 Yes, it's blocked by #169. Welcome to contribute!
--
This is an automated
liurenjie1024 commented on issue #225:
URL: https://github.com/apache/iceberg-rust/issues/225#issuecomment-1972373337
Hi, @jacksonrnewhouse What's mention are two feature:
1. Create table.
2. Append files.
These two features are transaction apis. 1 is relative easy to finish,
huaxingao commented on PR #9841:
URL: https://github.com/apache/iceberg/pull/9841#issuecomment-1972363257
cc @aokolnychyi @sunchao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
huaxingao commented on PR #9826:
URL: https://github.com/apache/iceberg/pull/9826#issuecomment-1972362520
@zinking
> are there any performance metrics
I will do a performance test and post the metrics in the new PR.
--
This is an automated message from the Apache Git Service
huaxingao commented on PR #9826:
URL: https://github.com/apache/iceberg/pull/9826#issuecomment-1972361237
I will close this PR for now. I have a
[PR](https://github.com/apache/iceberg/pull/9841) to show how I will integrate
Iceberg with Comet.
--
This is an automated message from the Ap
huaxingao closed pull request #9826: Dynamically support Spark native engine in
Iceberg
URL: https://github.com/apache/iceberg/pull/9826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Xuanwo commented on issue #225:
URL: https://github.com/apache/iceberg-rust/issues/225#issuecomment-1972350908
Thank you for bringing this to our attention. This feature is indeed
included in our process of writing data into Iceberg. We simply need to make
the API accessible.
--
This is
huaxingao opened a new pull request, #9841:
URL: https://github.com/apache/iceberg/pull/9841
This PR shows how I will integrate
[Comet](https://github.com/apache/arrow-datafusion-comet) with iceberg. The PR
doesn't compile yet because we haven't released Comet yet. Also, Comet doesn't
have
jacksonrnewhouse opened a new issue, #225:
URL: https://github.com/apache/iceberg-rust/issues/225
[Arroyo](https://github.com/ArroyoSystems/arroyo) is a Rust-based stream
processing engine that performs reliable computation on data across many
supported sources and writes to a similar numbe
Dysprosium0626 commented on issue #224:
URL: https://github.com/apache/iceberg-rust/issues/224#issuecomment-1972341874
Is this block by https://github.com/apache/iceberg-rust/pull/169?
I could work on this after this pr is merged.
--
This is an automated message from the Apache Git Ser
himadripal commented on issue #479:
URL: https://github.com/apache/iceberg-python/issues/479#issuecomment-1972339539
working on the python one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Xuanwo commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1508403764
##
crates/iceberg/src/io.rs:
##
@@ -215,9 +216,12 @@ pub struct InputFile {
}
/// Trait for reading file.
-pub trait FileRead: AsyncRead + AsyncSeek {}
+pub trait
ZENOTME commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1508400754
##
crates/iceberg/src/io.rs:
##
@@ -215,9 +216,12 @@ pub struct InputFile {
}
/// Trait for reading file.
-pub trait FileRead: AsyncRead + AsyncSeek {}
+pub trai
huyuanfeng2018 commented on code in PR #9606:
URL: https://github.com/apache/iceberg/pull/9606#discussion_r1508394884
##
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java:
##
@@ -68,6 +72,33 @@ public static Schema convert(TableSchema schema) {
r
huyuanfeng2018 commented on code in PR #9606:
URL: https://github.com/apache/iceberg/pull/9606#discussion_r1508394858
##
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java:
##
@@ -68,6 +72,33 @@ public static Schema convert(TableSchema schema) {
r
tomtongue commented on issue #9085:
URL: https://github.com/apache/iceberg/issues/9085#issuecomment-1972308123
@nastra Is anyone working on this? May I help the migration to JUnit5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
liurenjie1024 commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1508375681
##
crates/iceberg/src/expr/mod.rs:
##
@@ -18,25 +18,129 @@
//! This module contains expressions.
mod term;
+
+use std::fmt::{Display, Formatter};
+
pub us
liurenjie1024 commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1508372825
##
crates/iceberg/src/expr/mod.rs:
##
@@ -18,25 +18,129 @@
//! This module contains expressions.
mod term;
+
+use std::fmt::{Display, Formatter};
+
pub us
syun64 commented on code in PR #473:
URL: https://github.com/apache/iceberg-python/pull/473#discussion_r1508370814
##
pyiceberg/table/metadata.py:
##
@@ -121,7 +122,7 @@ def check_sort_orders(table_metadata: TableMetadata) ->
TableMetadata:
def construct_refs(table_metadata:
syun64 commented on code in PR #473:
URL: https://github.com/apache/iceberg-python/pull/473#discussion_r1508370020
##
pyiceberg/table/metadata.py:
##
@@ -121,7 +122,7 @@ def check_sort_orders(table_metadata: TableMetadata) ->
TableMetadata:
def construct_refs(table_metadata:
HonahX commented on code in PR #473:
URL: https://github.com/apache/iceberg-python/pull/473#discussion_r1508355210
##
pyiceberg/table/metadata.py:
##
@@ -121,7 +122,7 @@ def check_sort_orders(table_metadata: TableMetadata) ->
TableMetadata:
def construct_refs(table_metadata:
HonahX merged PR #485:
URL: https://github.com/apache/iceberg-python/pull/485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
sdd commented on PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#issuecomment-1972211944
Woohoo, made the error handling much nicer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
github-actions[bot] commented on issue #1708:
URL: https://github.com/apache/iceberg/issues/1708#issuecomment-1972190087
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] closed issue #1396: Cannot read Parquet maps with
NameMapping
URL: https://github.com/apache/iceberg/issues/1396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
github-actions[bot] closed issue #1383: Flink: Support Flink streaming reading
URL: https://github.com/apache/iceberg/issues/1383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
github-actions[bot] commented on issue #1756:
URL: https://github.com/apache/iceberg/issues/1756#issuecomment-1972190179
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #1710:
URL: https://github.com/apache/iceberg/issues/1710#issuecomment-1972190141
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #1396:
URL: https://github.com/apache/iceberg/issues/1396#issuecomment-1972189726
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] commented on issue #1383:
URL: https://github.com/apache/iceberg/issues/1383#issuecomment-1972189676
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
szehon-ho commented on code in PR #9813:
URL: https://github.com/apache/iceberg/pull/9813#discussion_r1508313483
##
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##
@@ -158,14 +176,26 @@ static class ManifestReadTask extends BaseFileScanTask
implements DataTask {
szehon-ho commented on code in PR #9813:
URL: https://github.com/apache/iceberg/pull/9813#discussion_r1508313002
##
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##
@@ -54,7 +56,23 @@ public Schema schema() {
schema = TypeUtil.selectNot(schema,
Sets.newHashS
sdd commented on PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#issuecomment-1972120970
@liurenjie1024 and @ZENOTME : PTAL again, I've refactored the parquet file
reading logic out into a separate reader struct. I've addressed all the other
comments also.
--
This is an aut
RussellSpitzer commented on PR #9840:
URL: https://github.com/apache/iceberg/pull/9840#issuecomment-1972120101
Thanks @stevenzwu and @singhpk234 for reviewing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
RussellSpitzer merged PR #9840:
URL: https://github.com/apache/iceberg/pull/9840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceb
sdd commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1508291039
##
crates/iceberg/src/scan.rs:
##
@@ -180,7 +185,42 @@ pub type ArrowRecordBatchStream = BoxStream<'static,
crate::Result>
impl FileScanTask {
/// Returns a strea
pp-akursar commented on issue #24:
URL: https://github.com/apache/iceberg-python/issues/24#issuecomment-1972048447
I was looking for something comparable to spark's
[partitions](https://iceberg.apache.org/docs/latest/spark-queries/#partitions)
metadata table, which lets me do something like
syun64 commented on code in PR #473:
URL: https://github.com/apache/iceberg-python/pull/473#discussion_r1508217603
##
pyiceberg/serializers.py:
##
@@ -127,6 +129,11 @@ def table_metadata(metadata: TableMetadata, output_file:
OutputFile, overwrite:
overwrite (bool):
himadripal commented on PR #484:
URL: https://github.com/apache/iceberg-python/pull/484#issuecomment-1971983862
> The easiest way is to fix this locally using `make install && make lint`
@Fokko Thank you for this tip.
--
This is an automated message from the Apache Git Service.
To
kevinjqliu commented on issue #376:
URL: https://github.com/apache/iceberg-python/issues/376#issuecomment-1971982173
@jonashaag this should work now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Fokko opened a new pull request, #485:
URL: https://github.com/apache/iceberg-python/pull/485
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
stevenzwu commented on code in PR #9606:
URL: https://github.com/apache/iceberg/pull/9606#discussion_r1507990720
##
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java:
##
@@ -68,6 +72,33 @@ public static Schema convert(TableSchema schema) {
return
Fokko merged PR #453:
URL: https://github.com/apache/iceberg-python/pull/453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on PR #453:
URL: https://github.com/apache/iceberg-python/pull/453#issuecomment-1971972695
Let's move this forward, thanks for working on this 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Fokko commented on PR #469:
URL: https://github.com/apache/iceberg-python/pull/469#issuecomment-1971935173
Thanks @kevinjqliu for fixing this 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Fokko closed issue #376: Allow non-stringly typed table properties
URL: https://github.com/apache/iceberg-python/issues/376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
Fokko merged PR #469:
URL: https://github.com/apache/iceberg-python/pull/469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on code in PR #473:
URL: https://github.com/apache/iceberg-python/pull/473#discussion_r1508081821
##
mkdocs/docs/configuration.md:
##
@@ -249,3 +249,7 @@ catalog:
# Concurrency
PyIceberg uses multiple threads to parallelize operations. The number of
workers
Fokko commented on PR #484:
URL: https://github.com/apache/iceberg-python/pull/484#issuecomment-1971916997
The easiest way is to fix this locally using `make install && make lint`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
mfatihaktas commented on issue #30:
URL: https://github.com/apache/iceberg-python/issues/30#issuecomment-1971894322
Just to note, we would also love this feature. It would allow us to [support
Iceberg read/write in Ibis](https://github.com/ibis-project/ibis/pull/8343).
--
This is an autom
himadripal commented on PR #484:
URL: https://github.com/apache/iceberg-python/pull/484#issuecomment-1971852828
@Fokko Thank you for the approval. Fixed the conflict, can you please let
the build checks run?
--
This is an automated message from the Apache Git Service.
To respond to the m
himadripal commented on PR #9839:
URL: https://github.com/apache/iceberg/pull/9839#issuecomment-1971845270
Although the issue discusses about making `audience` configurable but there
are few other optional parameter exists in the specification (I have added
support for `resource` as an add
dramaticlly commented on PR #9838:
URL: https://github.com/apache/iceberg/pull/9838#issuecomment-1971825356
> > Can you do make generate to have python code update as well? Otherwise
LGTM
>
>
>
> @dramaticlly Tested with OpenAPI's python generator (if that's what you
mean), d
RussellSpitzer commented on code in PR #9803:
URL: https://github.com/apache/iceberg/pull/9803#discussion_r1508097349
##
core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewriter.java:
##
@@ -258,6 +262,24 @@ protected long writeMaxFileSize() {
return (long) (targ
haizhou-zhao commented on PR #9838:
URL: https://github.com/apache/iceberg/pull/9838#issuecomment-1971810856
> Can you do make generate to have python code update as well? Otherwise LGTM
@dramaticlly Tested with OpenAPI's python generator (if that's what you
mean), details also in the
dramaticlly commented on PR #9838:
URL: https://github.com/apache/iceberg/pull/9838#issuecomment-1971802670
Can you do make generate to have python code update as well? Otherwise LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
haizhou-zhao commented on issue #9837:
URL: https://github.com/apache/iceberg/issues/9837#issuecomment-1971798949
cc: @dramaticlly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
haizhou-zhao commented on issue #9837:
URL: https://github.com/apache/iceberg/issues/9837#issuecomment-1971798787
@Fokko I've worked with you in the past to correct several other REST spec
models. I'm wondering if this is some issue that interests you, or if you can
help forwarding to parti
haizhou-zhao commented on issue #9837:
URL: https://github.com/apache/iceberg/issues/9837#issuecomment-1971796532
Relevant code change proposed at https://github.com/apache/iceberg/pull/9838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
HonahX commented on issue #445:
URL: https://github.com/apache/iceberg-python/issues/445#issuecomment-1971790736
> what we will need to support CREATE TABLE ... AS SELECT semantics as
well...
Totally agree! I've created an issue to track this feature:
https://github.com/apache/iceber
RussellSpitzer commented on code in PR #9803:
URL: https://github.com/apache/iceberg/pull/9803#discussion_r1508074372
##
api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java:
##
@@ -119,6 +119,15 @@ public interface RewriteDataFiles
String REWRITE_JOB_ORDER_DE
RussellSpitzer commented on code in PR #9803:
URL: https://github.com/apache/iceberg/pull/9803#discussion_r1508073261
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##
@@ -1463,6 +1465,148 @@ public void testSnapshotProperty()
RussellSpitzer commented on code in PR #9803:
URL: https://github.com/apache/iceberg/pull/9803#discussion_r1508073261
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##
@@ -1463,6 +1465,148 @@ public void testSnapshotProperty()
haizhou-zhao opened a new issue, #9837:
URL: https://github.com/apache/iceberg/issues/9837
### Apache Iceberg version
1.4.3 (latest release)
### Query engine
None
### Please describe the bug 🐞
## Summary
This is a report on error made in REST Spec's open
RussellSpitzer commented on code in PR #9803:
URL: https://github.com/apache/iceberg/pull/9803#discussion_r1508069068
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##
@@ -1463,6 +1465,148 @@ public void testSnapshotProperty()
RussellSpitzer commented on code in PR #9803:
URL: https://github.com/apache/iceberg/pull/9803#discussion_r1508068633
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##
@@ -1463,6 +1465,148 @@ public void testSnapshotProperty()
himadripal commented on code in PR #9803:
URL: https://github.com/apache/iceberg/pull/9803#discussion_r1508053756
##
core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewriter.java:
##
@@ -258,6 +262,24 @@ protected long writeMaxFileSize() {
return (long) (targetFi
RussellSpitzer commented on code in PR #9803:
URL: https://github.com/apache/iceberg/pull/9803#discussion_r1508035340
##
core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewriter.java:
##
@@ -258,6 +262,24 @@ protected long writeMaxFileSize() {
return (long) (targ
RussellSpitzer commented on code in PR #9803:
URL: https://github.com/apache/iceberg/pull/9803#discussion_r1508035340
##
core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewriter.java:
##
@@ -258,6 +262,24 @@ protected long writeMaxFileSize() {
return (long) (targ
amitgilad3 commented on issue #9833:
URL: https://github.com/apache/iceberg/issues/9833#issuecomment-1971750782
Hey @bk-mz , If you are trying to compact the files with positional deletes
and remove you need to run compaction on the data files themselves , like this:
1. first run rewrite
amitgilad3 commented on issue #9833:
URL: https://github.com/apache/iceberg/issues/9833#issuecomment-1971739029
If you are trying to compact the files with positional deletes you need to
run compaction on the data files themselves , like this:
--
This is an automated message from the Apa
RussellSpitzer commented on code in PR #9803:
URL: https://github.com/apache/iceberg/pull/9803#discussion_r1508020842
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##
@@ -1463,6 +1449,176 @@ public void testSnapshotProperty()
RussellSpitzer commented on code in PR #9803:
URL: https://github.com/apache/iceberg/pull/9803#discussion_r1508019543
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##
@@ -1463,6 +1449,176 @@ public void testSnapshotProperty()
RussellSpitzer commented on code in PR #9803:
URL: https://github.com/apache/iceberg/pull/9803#discussion_r1508017989
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##
@@ -1463,6 +1449,176 @@ public void testSnapshotProperty()
danielcweeks merged PR #9660:
URL: https://github.com/apache/iceberg/pull/9660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceber
syun64 commented on PR #473:
URL: https://github.com/apache/iceberg-python/pull/473#issuecomment-1971728190
I went forward with the **Option 2** and I think it looks pretty clean. Let
me know what you think @Fokko
--
This is an automated message from the Apache Git Service.
To respond to
jaychia opened a new pull request, #9836:
URL: https://github.com/apache/iceberg/pull/9836
- Adds installation examples
- Adds code examples for getting up and running with Daft + PyIceberg
- Adds a type conversion matrix between Daft and PyIceberg
--
This is an automated message fro
jacobmarble commented on PR #9008:
URL: https://github.com/apache/iceberg/pull/9008#issuecomment-1971715722
@rdblue can you take another look at this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
Fokko commented on code in PR #176:
URL: https://github.com/apache/iceberg-rust/pull/176#discussion_r1507992831
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -0,0 +1,385 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
Fokko commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1507941201
##
crates/iceberg/src/expr/mod.rs:
##
@@ -18,25 +18,129 @@
//! This module contains expressions.
mod term;
+
+use std::fmt::{Display, Formatter};
+
pub use term::
1 - 100 of 147 matches
Mail list logo
