ZENOTME commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1508400754
##########
crates/iceberg/src/io.rs:
##########
@@ -215,9 +216,12 @@ pub struct InputFile {
}
/// Trait for reading file.
-pub trait FileRead: AsyncRead + AsyncSeek {}
+pub trait FileRead: AsyncRead + AsyncSeek + Send + Unpin + TokioAsyncRead +
TokioAsyncSeek {}
Review Comment:
> TODO: I'm working on https://github.com/upondal/opendal-parquet-io for
best performance.
Maybe we can use an interface like `InputFile.parquet_reader() ->
AsyncFIleReader` to let a FileIO provide a custom parquet reader. But for now,
using the FileRead trait looks good to me. cc @Xuanwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
