syun64 commented on code in PR #473:
URL: https://github.com/apache/iceberg-python/pull/473#discussion_r1508217603
##########
pyiceberg/serializers.py:
##########
@@ -127,6 +129,11 @@ def table_metadata(metadata: TableMetadata, output_file:
OutputFile, overwrite:
overwrite (bool): Where to overwrite the file if it already
exists. Defaults to `False`.
"""
with output_file.create(overwrite=overwrite) as output_stream:
- json_bytes = metadata.model_dump_json().encode(UTF8)
+ model_dump = metadata.model_dump_json()
+ if Config().get_bool("legacy-current-snapshot-id") and
metadata.current_snapshot_id is None:
+ model_dict = json.loads(model_dump)
+ model_dict[CURRENT_SNAPSHOT_ID] = -1
+ model_dump = json.dumps(model_dict)
Review Comment:
Oh that's a good suggestion. I'll add the field_serializer and set
exclude_none to False so we can print out `-1` in the output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
