liurenjie1024 commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1508372825
##########
crates/iceberg/src/expr/mod.rs:
##########
@@ -18,25 +18,129 @@
//! This module contains expressions.
mod term;
+
+use std::fmt::{Display, Formatter};
+
pub use term::*;
mod predicate;
pub use predicate::*;
/// Predicate operators used in expressions.
+///
+/// The discriminant of this enum is used for determining the type of the
operator, see
+/// [`PredicateOperator::is_unary`], [`PredicateOperator::is_binary`],
[`PredicateOperator::is_set`]
#[allow(missing_docs)]
+#[derive(Debug, Clone, Copy)]
+#[repr(u16)]
pub enum PredicateOperator {
Review Comment:
Good suggestion. I think the `AlwaysTrue`/`AlwaysFalse` would be quite
useful, but I prefer to add them in later prs since this pr is already a little
too large for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
