himadripal commented on code in PR #9803:
URL: https://github.com/apache/iceberg/pull/9803#discussion_r1508053756
##########
core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewriter.java:
##########
@@ -258,6 +262,24 @@ protected long writeMaxFileSize() {
return (long) (targetFileSize + ((maxFileSize - targetFileSize) * 0.5));
}
+ protected PartitionSpec outputSpec() {
+ return table.specs().get(outputSpecId);
+ }
+
+ protected int outputSpecId() {
Review Comment:
I'm ok to change the name for the private method to `extractOutputSpecId` or
`populateOutputSpecId`. Kept it like that seeing other method names format in
this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
