PR c/117025
gcc/testsuite/ChangeLog:
* gcc.dg/countof-vla.c: Remove spurious comments.
* gcc.dg/countof-zero-compile.c: Remove spurious comments.
Fixes: 517c9487f8fd (2025-05-27; "c: Add _Countof operator [PR117025]")
Reported-by: Sam James
Signed-off-by:
Hi Jakub, Joseph,
On Tue, May 27, 2025 at 10:28:23PM +0200, Jakub Jelinek wrote:
> On Tue, May 27, 2025 at 08:22:28PM +, Joseph Myers wrote:
> > Thanks, I've committed these patches, with additional commit message
> > changes to reference PR117025 in the standard way for GCC so that Bugzilla
* gcc.dg/countof-zero.c: New test.
* gcc.dg/countof.c: New test.
Suggested-by: Xavier Del Campo Romero
Co-authored-by: Martin Uecker
Acked-by: "James K. Lowden"
Signed-off-by: Alejandro Colomar
---
gcc/c-family/c-common.cc| 26
est.
* gcc.dg/countof-pedantic.c: New test.
* gcc.dg/countof-pedantic-errors.c: New test.
Signed-off-by: Alejandro Colomar
---
gcc/c/c-parser.cc | 4
gcc/testsuite/gcc.dg/countof-compat.c | 8
gcc/testsuite/gcc.dg/countof-no-compa
gcc/ChangeLog:
* Makefile.in (USER_H): Add .
* ginclude/stdcountof.h: New file.
gcc/testsuite/ChangeLog:
* gcc.dg/countof-stdcountof.c: New test.
Signed-off-by: Alejandro Colomar
---
gcc/Makefile.in | 1 +
gcc/ginclude/stdcountof.h
ave a lovely night!
Alex
Alejandro Colomar (3):
c: Add _Countof operator
c: Add
c: Add -Wpedantic diagnostic for _Countof
gcc/Makefile.in | 1 +
gcc/c-family/c-common.cc | 26
gcc/c-family/c-common.def | 3 +
Hi Jakub,
On Wed, May 21, 2025 at 11:47:30PM +0200, Jakub Jelinek wrote:
> > @@ -1747,6 +1737,8 @@ static struct c_expr c_parser_binary_expression
> > (c_parser *, struct c_expr *,
> > tree);
> > static struct c_expr c_parser_cast_expr
Hi Jakub,
On Wed, May 21, 2025 at 11:31:05PM +0200, Alejandro Colomar wrote:
> > > +#define c_parser_sizeof_expressi
On Wed, May 21, 2025 at 11:36:56PM +0200, Alejandro Colomar wrote:
> Hi Jakub,
>
> On Wed, May 21, 2025 at 11:12:07PM +0200, Jakub Jelinek wrote:
> > > warning_at (loc, OPT_Wc___compat,
> > > "defining type in %qs expression is invalid in
Hi Jakub,
On Wed, May 21, 2025 at 11:12:07PM +0200, Jakub Jelinek wrote:
> > warning_at (loc, OPT_Wc___compat,
> > "defining type in %qs expression is invalid in C++",
> > (in_sizeof
> > ? "sizeof"
> > -: (in_typeof ? "typeof" : "alignof")));
>
Hi Jakub,
On Wed, May 21, 2025 at 11:12:07PM +0200, Jakub Jelinek wrote:
> > * c-common.h: Add RID_COUNTOF.
>
> (enum rid): Add RID_COUNTOF.
Okay.
>
> > (c_countof_type): New function prototype.
> > * c-common.def (COUNTOF_EXPR): New tree.
> > * c-common.cc
> > (c_common_re
gcc/ChangeLog:
* Makefile.in (USER_H): Add .
* ginclude/stdcountof.h: Add countof macro.
gcc/testsuite/ChangeLog:
* gcc.dg/countof-stdcountof.c: Add tests for .
Signed-off-by: Alejandro Colomar
---
gcc/Makefile.in | 1 +
gcc/ginclude
f.
Suggested-by: Xavier Del Campo Romero
Co-authored-by: Martin Uecker
Acked-by: "James K. Lowden"
Signed-off-by: Alejandro Colomar
---
gcc/c-family/c-common.cc| 26
gcc/c-family/c-common.def | 3 +
gcc/c-family/c-common.h
tic-errors on C23.
Signed-off-by: Alejandro Colomar
---
gcc/c/c-parser.cc | 4
gcc/testsuite/gcc.dg/countof-compat.c | 8
gcc/testsuite/gcc.dg/countof-no-compat.c | 5 +
gcc/testsuite/gcc.dg/countof-pedantic-errors.c | 8
(test for excess errors)
PASS: gcc.dg/countof-zero.c (test for excess errors)
PASS: gcc.dg/countof-zero.c execution test
PASS: gcc.dg/countof.c (test for excess errors)
PASS: gcc.dg/countof.c execution test
Have a lovely day!
Alex
Alejandro Colomar (3):
c: Add _Co
Hi Joseph,
On Wed, May 21, 2025 at 04:26:46PM +, Joseph Myers wrote:
> On Wed, 21 May 2025, Alejandro Colomar wrote:
>
> > @@ -10572,6 +10583,8 @@ c_parser_unary_expression (c_parser *parser)
> > case CPP_KEYWORD:
> >switch (c_parser_peek
On Wed, May 21, 2025 at 02:17:58AM +0200, Alejandro Colomar wrote:
> Hi!
>
> Here's another revision of this patch set.
>
> v23 changes:
>
> - More specific change logs.
> - #define assert() instead of #include'ing .
>
> `make check` says all'
f.
Suggested-by: Xavier Del Campo Romero
Co-authored-by: Martin Uecker
Acked-by: "James K. Lowden"
Signed-off-by: Alejandro Colomar
---
gcc/c-family/c-common.cc| 26
gcc/c-family/c-common.def | 3 +
gcc/c-family/c-common.h
gcc/ChangeLog:
* Makefile.in (USER_H): Add .
* ginclude/stdcountof.h: Add countof macro.
gcc/testsuite/ChangeLog:
* gcc.dg/countof-stdcountof.c: Add tests for .
Signed-off-by: Alejandro Colomar
---
gcc/Makefile.in | 1 +
gcc/ginclude
tic-errors on C23.
Signed-off-by: Alejandro Colomar
---
gcc/c/c-parser.cc | 4
gcc/testsuite/gcc.dg/countof-compat.c | 8
gcc/testsuite/gcc.dg/countof-no-compat.c | 5 +
gcc/testsuite/gcc.dg/countof-pedantic-errors.c | 8
I've
only ran `make check -j24` once at the tip, and all the countof tests
pass.
Have a lovely night!
Alex
Alejandro Colomar (3):
c: Add _Countof operator
c: Add
c: Add -Wpedantic diagnostic for _Countof
gcc/Makefile.in | 1 +
gcc/c-family/c-common
Hi Jakub,
On Tue, May 20, 2025 at 11:20:27PM +0200, Jakub Jelinek wrote:
> On Tue, May 20, 2025 at 11:12:38PM +0200, Alejandro Colomar wrote:
> > Okay; how about this?
> >
> > gcc/c-family/ChangeLog:
> >
> > * c-common.h: Add _Countof operato
Hi Jakub,
On Tue, May 20, 2025 at 05:25:29PM +0200, Jakub Jelinek wrote:
> On Tue, May 20, 2025 at 05:15:33PM +0200, Alejandro Colomar wrote:
> > I've based on gnulib commits, which I believe follow the same
> > guidelines. For example:
Hi Joseph,
On Tue, May 20, 2025 at 02:43:55PM +, Joseph Myers wrote:
> > Could you please clarify if I need to do anything or if this is already
> > scheduled for review when you have some time? Also please clarify if
> > you're okay with amending that or if you prefer that I send v23.
>
> I
Hi Joseph,
On Fri, May 16, 2025 at 07:13:15PM +0200, Alejandro Colomar wrote:
> On Fri, May 16, 2025 at 05:01:36PM +, Joseph Myers wrote:
> > On Fri, 16 May 2025, Alejandro Colomar wrote:
> >
> > > Hmmm, I've been trying to find a compromise between readabilit
Hi Joseph,
On Fri, May 16, 2025 at 05:01:36PM +, Joseph Myers wrote:
> On Fri, 16 May 2025, Alejandro Colomar wrote:
>
> > Hmmm, I've been trying to find a compromise between readability and
> > simplicity, and I think I have something. I've seen some
Hi Joseph,
On Fri, May 16, 2025 at 12:25:39PM +, Joseph Myers wrote:
> On Fri, 16 May 2025, Alejandro Colomar wrote:
>
> > - Add (and NDEBUG) to some test files that were missing it,
> >and also the forward declaration of strcmp(3).
>
> Depending on libc heade
Here's the test run. No regressions.
BTW, there are some differences between runs. I _think_ this is due to
running them in separate days, and having run 'make install' in between,
which seems to have made some tests that would normally fail now succeed
but that's unrelated to the feature, and i
* gcc.dg/countof-zero-compile.c
* gcc.dg/countof-zero.c
* gcc.dg/countof.c: Add tests for _Countof operator.
Suggested-by: Xavier Del Campo Romero
Co-authored-by: Martin Uecker
Acked-by: "James K. Lowden"
Signed-off-by: Alejandro Colomar
---
gcc/c-family/c-common.c
gcc/ChangeLog:
* Makefile.in (USER_H): Add .
* ginclude/stdcountof.h: Add countof macro.
gcc/testsuite/ChangeLog:
* gcc.dg/countof-stdcountof.c: Add tests for .
Signed-off-by: Alejandro Colomar
---
gcc/Makefile.in | 1 +
gcc/ginclude
it,
and also the forward declaration of strcmp(3).
- Fix typos in dejagnu diagnostic comments.
Is this ready to merge now, hopefully? :-)
Have a lovely night!
Alex
Alejandro Colomar (3):
c: Add _Countof operator
c: Add
c: Add -Wpedantic diagnostic for _Count
.dg/countof-pedantic.c
* gcc.dg/countof-pedantic-errors.c:
Test pedantic diagnostics for _Countof.
Signed-off-by: Alejandro Colomar
---
gcc/c/c-parser.cc | 4
gcc/testsuite/gcc.dg/countof-compat.c | 8
gcc/testsuite/gcc.dg/countof
Hi Jason,
On Tue, May 13, 2025 at 10:35:00AM -0400, Jason Merrill wrote:
> > > It seems to be one of the more common trailers used in the linux
> > > kernel [1],
>
> Hmm, I don't see it in that list. But it is described in
> https://docs.kernel.org/process/submitting-patches.html
It was mentio
Hi Jonathan,
On Tue, May 13, 2025 at 10:39:21AM +0100, Jonathan Wakely wrote:
> On Mon, 12 May 2025 at 23:15, Alejandro Colomar wrote:
> > <https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by>
> >
> >
Hi Jonathan,
On Tue, May 13, 2025 at 10:50:23AM +0100, Jonathan Wakely wrote:
> Fair enough, I have no objection to adding Link: support to the
> git_commit.py script. (We don't really have anybody who is the owner
> of those scripts now, so I think you need a global reviewer to approve
> it.)
Th
Hi Jonathan,
On Mon, May 12, 2025 at 06:11:18PM +0100, Jonathan Wakely wrote:
> On 12/05/25 17:53 +0200, Alejandro Colomar wrote:
> > Suggested-by: Xavier Del Campo Romero
> > Co-authored-by: Martin Uecker
> > Acked-by: "James K. Lowden"
>
> What
Hi Jonathan,
On Mon, May 12, 2025 at 05:42:55PM +0100, Jonathan Wakely wrote:
> On Mon, 12 May 2025 at 17:34, Jonathan Wakely wrote:
> >
> > On Mon, 12 May 2025 at 16:46, Alejandro Colomar wrote:
> > >
> > > contrib/ChangeLog:
> > >
> > &g
Hi Joseph,
On Mon, May 12, 2025 at 04:43:45PM +, Joseph Myers wrote:
> On Mon, 12 May 2025, Alejandro Colomar wrote:
>
> > + if (strcmp (xstr(countof), "_Alignas") != 0)
>
> countof should definitely not expand to _Alignas!
D'oh! :-)
> I don't
.dg/countof-pedantic.c
* gcc.dg/countof-pedantic-errors.c:
Test pedantic diagnostics for _Countof.
Signed-off-by: Alejandro Colomar
---
gcc/c/c-parser.cc | 4
gcc/testsuite/gcc.dg/countof-compat.c | 8
gcc/testsuite/gcc.dg/countof
hey look good.
Have a lovely day!
Alex
Alejandro Colomar (3):
c: Add _Countof operator
c: Add
c: Add -Wpedantic diagnostic for _Countof
gcc/Makefile.in | 1 +
gcc/c-family/c-common.cc | 26 +++
gcc/c-family/c-common.def
gcc/ChangeLog:
* Makefile.in (USER_H): Add .
* ginclude/stdcountof.h: Add countof macro.
gcc/testsuite/ChangeLog:
* gcc.dg/countof-stdcountof.c: Add tests for .
Signed-off-by: Alejandro Colomar
---
gcc/Makefile.in | 1 +
gcc/ginclude
/questions/37538/#57537491>
Suggested-by: Xavier Del Campo Romero
Co-authored-by: Martin Uecker
Acked-by: "James K. Lowden"
Signed-off-by: Alejandro Colomar
---
gcc/c-family/c-common.cc | 26 +
gcc/c-family/c-common.def | 3 +
gcc/c-family/c-common.h
contrib/ChangeLog:
* gcc-changelog/git_commit.py (GitCommit):
Add support for 'Link:' tags.
Cc: Jason Merrill
Signed-off-by: Alejandro Colomar
---
Hi,
This patch is needed by my patches that add _Countof.
Have a lovely day!
Alex
contrib/gcc-changelog/git_com
On Mon, May 12, 2025 at 10:54:34AM +, Joseph Myers wrote:
> On Sun, 11 May 2025, Alejandro Colomar wrote:
>
> > +/* { dg-options "-Wno-declaration-after-statement -Wno-pedantic -Wno-vla"
> > } */
>
> > +/* { dg-options "-Wno-pedantic -Wvla-par
On Mon, May 12, 2025 at 10:54:52AM +, Joseph Myers wrote:
> On Sun, 11 May 2025, Alejandro Colomar wrote:
>
> > gcc/ChangeLog:
> >
> > * Makefile.in (USER_H): Add .
> > * ginclude/stdcountof.h: Add countof macro.
>
> This is missing tests for th
gcc/ChangeLog:
* Makefile.in (USER_H): Add .
* ginclude/stdcountof.h: Add countof macro.
Signed-off-by: Alejandro Colomar
---
gcc/Makefile.in | 1 +
gcc/ginclude/stdcountof.h | 31 +++
2 files changed, 32 insertions(+)
create mode 100644
It is not supported in <= C23 mode.
gcc/c/ChangeLog:
* c-parser.cc (c_parser_sizeof_or_countof_expression):
Add -Wpedantic diagnostic for _Countof in <= C23 mode.
Signed-off-by: Alejandro Colomar
---
gcc/c/c-parser.cc | 4
1 file changed, 4 insertions(+)
diff --git
/questions/37538/#57537491>
Suggested-by: Xavier Del Campo Romero
Co-authored-by: Martin Uecker
Acked-by: "James K. Lowden"
Signed-off-by: Alejandro Colomar
---
gcc/c-family/c-common.cc | 26 +
gcc/c-family/c-common.def | 3 +
gcc/c-family/c-common.h
contrib/ChangeLog:
* gcc-changelog/git_commit.py (GitCommit):
Add support for 'Link:' tags.
Cc: Jason Merrill
Signed-off-by: Alejandro Colomar
---
contrib/gcc-changelog/git_commit.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/contrib/gcc-changelog/git_co
Have a lovely day!
Alex
Alejandro Colomar (4):
contrib/: Add support for Link: tags
c: Add _Countof operator
c: Add
c: Add -Wpedantic diagnostic for _Countof
contrib/gcc-changelog/git_commit.py| 3 +
gcc/Makefile.in| 1 +
gcc/c-family/c-common.cc
On Fri, May 09, 2025 at 11:43:18PM +0200, Alejandro Colomar wrote:
> Hi Joseph,
>
> On Fri, May 09, 2025 at 09:39:34PM +, Joseph Myers wrote:
> > > > > contrib/ChangeLog:
> > > > >
> > > > > * gcc-changelog/git_commit.py (GitCom
Hi Joseph,
On Fri, May 09, 2025 at 09:39:34PM +, Joseph Myers wrote:
> > > > contrib/ChangeLog:
> > > >
> > > > * gcc-changelog/git_commit.py (GitCommit):
> > > > Add support for 'Cc: ' and 'Link: ' tags.
> > >
> > > Please remove this patch from this patch series; it has not
Hi Joseph,
On Fri, May 09, 2025 at 09:00:58PM +, Joseph Myers wrote:
> On Fri, 9 May 2025, Alejandro Colomar wrote:
>
> > contrib/ChangeLog:
> >
> > * gcc-changelog/git_commit.py (GitCommit):
> > Add support for 'Cc: ' and 'Link: ' t
Hi Jakub,
On Fri, May 09, 2025 at 10:02:17PM +0200, Jakub Jelinek wrote:
> On Fri, May 09, 2025 at 09:32:50PM +0200, Alejandro Colomar wrote:
> > gcc/ChangeLog:
> >
> > * Makefile.in
>
> Missing (USER_H): Add stdcountof.h.
Thanks!
> > --- /dev/null
&g
gcc/ChangeLog:
* Makefile.in
* ginclude/stdcountof.h: Add countof macro.
Signed-off-by: Alejandro Colomar
---
gcc/Makefile.in | 1 +
gcc/ginclude/stdcountof.h | 31 +++
2 files changed, 32 insertions(+)
create mode 100644 gcc/ginclude
contrib/ChangeLog:
* gcc-changelog/git_commit.py (GitCommit):
Add support for 'Cc: ' and 'Link: ' tags.
Cc: Jason Merrill
Signed-off-by: Alejandro Colomar
---
contrib/gcc-changelog/git_commit.py | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
iewicz
Cc: Douglas McIlroy
Cc: Jason Merrill
Cc: "Gustavo A. R. Silva"
Cc: Patrizia Kaye
Cc: Ori Bernstein
Cc: Robert Seacord
Cc: Marek Polacek
Cc: Sam James
Cc: Richard Biener
Signed-off-by: Alejandro Colomar
---
gcc/c-family/c-common.cc | 26 +
gcc/c-fam
o that in the following days,
since I'll be traveling.
I haven't yet implemented the pedantic diagnostic for old C versions.
This is in my TODO list. I think that's the only thing I'm missing.
Have a lovely night!
Alex
Alejandro Colomar (3):
contrib/: Add support for Cc: an
check for nonstring cases.
> * gcc.dg/Wunterminated-string-initialization-c++.c: Duplicate
> C test for -Wc++-compat.
The log and the code look good to me, but I'm not a maintainer, so can't
review that part. For the behavior and tests:
Acked-by: Alejand
Hi Eric,
On Thu, Oct 17, 2024 at 03:20:11PM GMT, Eric Gallager wrote:
> On Thu, Oct 17, 2024 at 10:54 AM Alejandro Colomar wrote:
> >
> > Just like we already do for git-send-email(1). In some cases, patches
> > are prepared with git-format-patch(1), but are sent with a
On Sun, Nov 10, 2024 at 11:32:54AM GMT, Alejandro Colomar wrote:
> Hi!
>
> Your favourite operator with the most controversial name comes back with
> support for [0], thanks to Martin Uecker. In movie theaters, and
> probably in GCC 16.
>
> For those who fight in a side in
Alex Celeste
Cc: Jakub Łukasiewicz
Cc: Douglas McIlroy
Cc: Jason Merrill
Cc: "Gustavo A. R. Silva"
Cc: Patrizia Kaye
Cc: Ori Bernstein
Cc: Robert Seacord
Cc: Marek Polacek
Cc: Sam James
Cc: Richard Biener
Signed-off-by: Alejandro Colomar
---
gcc/c-family/c-common.cc
reply to this email with the
regression-test session results; they all passed. [0] works like a
charm.
Have a lovely day!
Alex
Alejandro Colomar (2):
contrib/: Add support for Cc: and Link: tags
c: Add __countof__ operator
contrib/gcc-changelog/git_commit.py| 5 +-
gcc/c
contrib/ChangeLog:
* gcc-changelog/git_commit.py (GitCommit):
Add support for 'Cc: ' and 'Link: ' tags.
Cc: Jason Merrill
Signed-off-by: Alejandro Colomar
---
contrib/gcc-changelog/git_commit.py | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
geLog:
> * gcc.dg/Wzero-as-null-pointer-constant.c: New test.
>
>
> Suggested-by: Alejandro Colomar
> Acked-by: Alejandro Colomar
>
>
> diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt
> index 9b9f5e744f6..b4e967ce000 100644
> --- a/gcc/c-fami
ing that it may be good to add some tests to check that structs
with implicit initialization to 0s don't trigger this diagnostic.
struct ( int a; void *b; } a = { 0 };
struct ( int a; int b; void *b; } b = { 0 , 0 };
There might be other corner cases worth testing.
Thanks for adding this diagnostic! Feel free to add:
Suggested-by: Alejandro Colomar
Acked-by: Alejandro Colomar
Cheers,
Alex
--
<https://www.alejandro-colomar.es/>
signature.asc
Description: PGP signature
Hi Joseph,
This is a gentle ping about this patch set, 10 days before the start of
stage 3.
Have a lovely day!
Alex
On Sat, Oct 26, 2024 at 12:10:56AM GMT, Alejandro Colomar wrote:
> Hi Joseph,
>
> On Fri, Oct 25, 2024 at 08:44:15PM GMT, Joseph Myers wrote:
> > I don&#
Hi Joseph,
On Fri, Oct 25, 2024 at 08:44:15PM GMT, Joseph Myers wrote:
> I don't see the use of pedwarn_c23 and associated tests (error with
> -std=c23 -pedantic-errors, warning with -std=c23 -pedantic, no diagnostic
> with -std=c23 -pedantic-errors -Wno-c23-c2y-compat, no diagnostic with
> -st
On Tue, Oct 22, 2024 at 08:48:10PM GMT, Alejandro Colomar wrote:
> Hi Joseph,
>
> I found some tests that could be improved, so I've worked on that in the
> last few days. I'll post as a reply to this email the bootstrap and
> regression testing results.
alx@debian:~
Cc: Ville Voutilainen
Cc: Alex Celeste
Cc: Jakub Łukasiewicz
Cc: Douglas McIlroy
Cc: Jason Merrill
Cc: "Gustavo A. R. Silva"
Cc: Patrizia Kaye
Cc: Ori Bernstein
Cc: Robert Seacord
Cc: Marek Polacek
Cc: Sam James
Cc: Richard Biener
Signed-off-by: Alejandro Colomar
---
contrib/ChangeLog:
* gcc-changelog/git_commit.py (GitCommit):
Add support for 'Cc: ' and 'Link: ' tags.
Cc: Jason Merrill
Signed-off-by: Alejandro Colomar
---
contrib/gcc-changelog/git_commit.py | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
ts.
Below is the range diff against v16b.
Have a lovely night!
Alex
Alejandro Colomar (2):
contrib/: Add support for Cc: and Link: tags
c: Add __countof__ operator
contrib/gcc-changelog/git_commit.py| 5 +-
gcc/c-family/c-common.cc | 26 +
gcc/c-family/c-
On Fri, Oct 18, 2024 at 10:25:59AM GMT, Alejandro Colomar wrote:
> Hi Joseph,
>
> On Wed, Oct 16, 2024 at 08:02:05PM GMT, Alejandro Colomar wrote:
> > Hi Joseph,
> >
> > On Wed, Oct 16, 2024 at 05:21:39PM GMT, Joseph Myers wrote:
> > > On Wed,
Hi Joseph,
On Wed, Oct 16, 2024 at 08:02:05PM GMT, Alejandro Colomar wrote:
> Hi Joseph,
>
> On Wed, Oct 16, 2024 at 05:21:39PM GMT, Joseph Myers wrote:
> > On Wed, 16 Oct 2024, Alejandro Colomar wrote:
> >
> > > The old name was misleading.
> > >
> &
On Thu, Oct 17, 2024 at 04:54:04PM GMT, Alejandro Colomar wrote:
> Just like we already do for git-send-email(1). In some cases, patches
> are prepared with git-format-patch(1), but are sent with a different
> program, or some flags to git-send-email(1) may accidentally in
@ will receive the patch.
contrib/ChangeLog:
* gcc-git-customization.sh: Configure git-format-patch(1) to add
'To: gcc-patches@gcc.gnu.org'.
Cc: Eric Gallager
Signed-off-by: Alejandro Colomar
---
Hi!
v2 changes:
- Fix comment. [Eric]
Cheers,
Alex
Range-diff aga
On Wed, Oct 16, 2024 at 03:41:00PM GMT, Eric Gallager wrote:
> On Wed, Oct 16, 2024 at 8:55 AM Alejandro Colomar wrote:
> >
> > Just like we already do for git-send-email(1). In some cases, patches
> > are prepared with git-format-patch(1), but are sent with a different
Hi Joseph,
On Wed, Oct 16, 2024 at 05:21:39PM GMT, Joseph Myers wrote:
> On Wed, 16 Oct 2024, Alejandro Colomar wrote:
>
> > The old name was misleading.
> >
> > While at it, also rename some temporary variables that are used with
> > this function, for consiste
@ will receive the patch.
contrib/ChangeLog:
* gcc-git-customization.sh: Configure git-format-patch(1) to add
'To: gcc-patches@gcc.gnu.org'.
Signed-off-by: Alejandro Colomar
---
contrib/gcc-git-customization.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/contr
* backend/rust-tree.cc (array_type_nelts_top):
Rename array_type_nelts => array_type_nelts_minus_one
Cc: Gabriel Ravier
Cc: Martin Uecker
Cc: Joseph Myers
Cc: Xavier Del Campo Romero
Cc: Jakub Jelinek
Suggested-by: Richard Biener
Signed-off-by: Alejandro Colomar
---
gcc/c/c-decl.
Cc: Ville Voutilainen
Cc: Alex Celeste
Cc: Jakub Łukasiewicz
Cc: Douglas McIlroy
Cc: Jason Merrill
Cc: "Gustavo A. R. Silva"
Cc: Patrizia Kaye
Cc: Ori Bernstein
Cc: Robert Seacord
Cc: Marek Polacek
Cc: Sam James
Cc: Richard Biener
Signed-off-by: Alejandro Colomar
---
geLog:
* backend/rust-tree.h (array_type_nelts_top)
* backend/rust-tree.cc (array_type_nelts_top):
Remove function.
Signed-off-by: Alejandro Colomar
---
gcc/cp/cp-tree.h | 1 -
gcc/cp/tree.cc| 13 -
gcc/rust/backend/rust-tree.cc
contrib/ChangeLog:
* gcc-changelog/git_commit.py (GitCommit):
Add support for 'Cc: ' and 'Link: ' tags.
Cc: Jason Merrill
Signed-off-by: Alejandro Colomar
---
contrib/gcc-changelog/git_commit.py | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
is a resend, since I accidentally didn't send them to the mailing
list.
Have a lovely day!
Alex
Alejandro Colomar (4):
contrib/: Add support for Cc: and Link: tags
gcc/: Rename array_type_nelts => array_type_nelts_minus_one
gcc/: Merge definitions of array_type_nelts_top
c: Add __c
On Wed, Oct 16, 2024 at 10:34:21AM GMT, Joseph Myers wrote:
> On Wed, 16 Oct 2024, Alejandro Colomar wrote:
>
> > The old name was misleading.
> >
> > While at it, also rename some temporary variables that are used with
> > this function, for consistency.
>
Hi Joseph,
On Wed, Oct 16, 2024 at 10:30:36AM GMT, Joseph Myers wrote:
> On Wed, 16 Oct 2024, Alejandro Colomar wrote:
>
> > + if (type_code != ARRAY_TYPE)
> > +{
> > + error_at (loc, "invalid application of % to type %qT",
> >
Hi Joseph,
On Wed, Oct 16, 2024 at 10:34:21AM GMT, Joseph Myers wrote:
> On Wed, 16 Oct 2024, Alejandro Colomar wrote:
>
> > The old name was misleading.
> >
> > While at it, also rename some temporary variables that are used with
> > this function, for consistency
Cc: Ville Voutilainen
Cc: Alex Celeste
Cc: Jakub Łukasiewicz
Cc: Douglas McIlroy
Cc: Jason Merrill
Cc: "Gustavo A. R. Silva"
Cc: Patrizia Kaye
Cc: Ori Bernstein
Cc: Robert Seacord
Cc: Marek Polacek
Cc: Sam James
Signed-off-by: Alejandro Colomar
---
gcc/c-family/c-common.cc
geLog:
* backend/rust-tree.h (array_type_nelts_top)
* backend/rust-tree.cc (array_type_nelts_top):
Remove function.
Signed-off-by: Alejandro Colomar
---
gcc/cp/cp-tree.h | 1 -
gcc/cp/tree.cc| 13 -
gcc/rust/backend/rust-tree.cc
gcc/rust/ChangeLog:
* backend/rust-tree.cc (array_type_nelts_top):
Rename array_type_nelts() => array_type_nelts_minus_one()
Cc: Gabriel Ravier
Cc: Martin Uecker
Cc: Joseph Myers
Cc: Xavier Del Campo Romero
Cc: Jakub Jelinek
Suggested-by: Richard Biener
Signed-off-by: Alejandro Colomar
contrib/ChangeLog:
* gcc-changelog/git_commit.py (GitCommit):
Add support for 'Cc: ' and 'Link: ' tags.
Cc: Jason Merrill
Signed-off-by: Alejandro Colomar
---
contrib/gcc-changelog/git_commit.py | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
he Democratic presidential candidate, ?Every thinking person in
America
> will vote for you.? Stevenson supposed replied, "That's not enough.
> I need a majority.?
>
> 'Twas always thus.
> I would go with __countof__(). It'
Hi Joseph,
On Wed, Oct 09, 2024 at 09:11:52PM GMT, Joseph Myers wrote:
> On Wed, 9 Oct 2024, Alejandro Colomar wrote:
>
> > Every little bit adds up. Documentation is simpler if there is naming
> > consistency. We have SYNOPSISes in the man pages, and they're up
Hi Jason,
You've recently touched code about C++ modules. Do you have any idea of
why my changes may be introducing regressions in the tests?
Have a lovely night!
Alex
On Sun, Oct 13, 2024 at 11:56:55PM GMT, Alejandro Colomar wrote:
> Hi Joseph,
>
> On Fri, Oct 11, 2024 at
Hi Joseph,
On Fri, Oct 11, 2024 at 01:44:36PM GMT, Alejandro Colomar wrote:
> Hi,
>
> This is just an untested draft. If there's rough agreement that this is
> wanted, I'll test it, write changelog, etc.
>
> The intention of this change is to help improve the co
On Fri, Oct 11, 2024 at 02:55:38PM GMT, Joseph Myers wrote:
> On Fri, 11 Oct 2024, Alejandro Colomar wrote:
>
> > That was insane.
> >
> > Link: <https://software.codidact.com/posts/292718>
> > Signed-off-by: Alejandro Colomar
> > ---
> > gcc
Hi Joseph,
On Fri, Oct 11, 2024 at 02:59:50PM GMT, Joseph Myers wrote:
> On Fri, 11 Oct 2024, Alejandro Colomar wrote:
>
> > That was insane.
>
> Also please avoid such pejorative language in commit messages. The
> libiberty code here is 30-40 years (or more) old; the def
For internal C++ code, unconditionally define NULL as nullptr.
We already require a C++11 compiler to bootstrap GCC anyway.
Link: <https://software.codidact.com/posts/292718>
Signed-off-by: Alejandro Colomar
---
libgm2/libm2pim/wrapc.cc | 4 +---
1 file changed, 1 insertion(+), 3 del
0 is a terrible definition of NULL. If possible, that is, for C++11 or
later, define is as nullptr.
Link: <https://software.codidact.com/posts/292718>
Signed-off-by: Alejandro Colomar
---
gcc/ginclude/stddef.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
That was insane.
Link: <https://software.codidact.com/posts/292718>
Signed-off-by: Alejandro Colomar
---
gcc/testsuite/gcc.c-torture/execute/pr68143_1.c | 2 +-
gcc/testsuite/gcc.c-torture/execute/pr70566.c | 2 +-
gcc/testsuite/gcc.dg/tm/20100615.c | 2 +-
gcc/tes
1 - 100 of 317 matches
Mail list logo
