Hi Joseph,

On Fri, May 09, 2025 at 09:00:58PM +0000, Joseph Myers wrote:
> On Fri, 9 May 2025, Alejandro Colomar wrote:
> 
> > contrib/ChangeLog:
> > 
> >     * gcc-changelog/git_commit.py (GitCommit):
> >     Add support for 'Cc: ' and 'Link: ' tags.
> 
> Please remove this patch from this patch series; it has nothing to do with 
> _Countof and would probably be reviewed by different people.

Who should review that?  Nobody applied it, nor replied to it.  (IIRC
someone said the patch looks good, but not someone who should merge it,
so it was of no use.)  Please point me to the people who are responsible
for that.

>  Just don't 
> use any unsupported tags in commit messages.  (And I don't think Cc: 
> belongs in a commit message at all; information about who you chose to CC 
> on a patch submission is of no use to people looking at the commit 
> history, so doesn't belong in that history.)

I disagree.  In projects I (co-)maintain, this info has been very
useful, for example to ask about a very old patch, where I couldn't
reach the author, but I could reach people that was CCd in discussions
leading to the patch.  Thanks to having their names in commit messages,
I could reach them.

But since you're the maintainer here, it's your prerrogative, so I can
drop them if you confirm I should do that.


Have a lovely night!
Alex

-- 
<https://www.alejandro-colomar.es/>

Attachment: signature.asc
Description: PGP signature

Reply via email to