On Fri, May 09, 2025 at 11:43:18PM +0200, Alejandro Colomar wrote: > Hi Joseph, > > On Fri, May 09, 2025 at 09:39:34PM +0000, Joseph Myers wrote: > > > > > contrib/ChangeLog: > > > > > > > > > > * gcc-changelog/git_commit.py (GitCommit): > > > > > Add support for 'Cc: ' and 'Link: ' tags. > > > > > > > > Please remove this patch from this patch series; it has nothing to do > > > > with > > > > _Countof and would probably be reviewed by different people. > > > > > > Who should review that? Nobody applied it, nor replied to it. (IIRC > > > > Putting a patch in an unrelated series makes it *less* likely anyone will > > look at it, since people concerned with that patch may be disjoint from > > those concerned with the apparent subject of the series. (So if a change > > to one part of the compiler depends on a change to another, I think it's > > always better to post the dependency separately, not as part of the main > > series.) > > IIRC, I did resend that patch also separate from this series a long time > ago, and no response. > > > > > > someone said the patch looks good, but not someone who should merge it, > > > so it was of no use.) Please point me to the people who are responsible > > > for that. > > > > People who have worked on that code lately? (In practice people can > > maintain their own scripts in contrib/, but Martin Liska is no longer > > significantly active in GCC development so that doesn't help here.) > > I did ping several people who touched that code lately, but they said > they weren't responsible for it. :| > > > > I disagree. In projects I (co-)maintain, this info has been very > > > useful, for example to ask about a very old patch, where I couldn't > > > reach the author, but I could reach people that was CCd in discussions > > > leading to the patch. Thanks to having their names in commit messages, > > > I could reach them. > > > > > > But since you're the maintainer here, it's your prerrogative, so I can > > > drop them if you confirm I should do that. > > > > I think CC should be dropped from commit messages. > > Thanks; I'll do that for v20. (And I'll drop patch 1/3, since it will > be unnecessary then.)
BTW, the patch also has 'Link:', which is also currently unsupported. How should I proceed with those? Cheers, Alex > > > Have a lovely night! > Alex > > -- > <https://www.alejandro-colomar.es/> -- <https://www.alejandro-colomar.es/>
signature.asc
Description: PGP signature
