On Fri, Oct 18, 2024 at 10:25:59AM GMT, Alejandro Colomar wrote:
> Hi Joseph,
> 
> On Wed, Oct 16, 2024 at 08:02:05PM GMT, Alejandro Colomar wrote:
> > Hi Joseph,
> > 
> > On Wed, Oct 16, 2024 at 05:21:39PM GMT, Joseph Myers wrote:
> > > On Wed, 16 Oct 2024, Alejandro Colomar wrote:
> > > 
> > > > The old name was misleading.
> > > > 
> > > > While at it, also rename some temporary variables that are used with
> > > > this function, for consistency.
> > > 
> > > This patch is OK and should be committed (assuming it has passed 
> > > bootstrap 
> > > and regression testing).

This patch (2/4) needs patch 1/4 for the commit message.  Otherwise
`git gcc-verify` reports a problem (Cc: tags).  Please revise patch 1/4
too.

Cheers,
Alex

> > 
> > Thanks!
> > 
> > I did bootstrap + regression testing in v15.  In v16 I got lazy and
> > since the changes were small, I only checked that the new tests all
> > pass.
> > 
> > Since it looks like it's close to merging, I'll run bootstrap +
> > regression testing again.
> 
> I've finished with regression testing.  It's all good for the entire
> patch set.  See below.
> 
> Have a lovely day!
> Alex
> 
> 
> $ find | grep sum$ | while read f; do diff -u ../len16b_b4/$f $f; done
> --- ../len16b_b4/./gcc/testsuite/gcc/gcc.sum  2024-10-16 22:35:00.073117065 
> +0200
> +++ ./gcc/testsuite/gcc/gcc.sum       2024-10-18 01:03:29.717522166 +0200
> @@ -1,4 +1,4 @@
> -Test run by alx on Wed Oct 16 20:49:15 2024
> +Test run by alx on Thu Oct 17 23:17:38 2024
>  Native configuration is x86_64-pc-linux-gnu
>  
>               === gcc tests ===
> @@ -77826,6 +77826,29 @@
>  PASS: gcc.dg/conv-2.c (test for excess errors)
>  PASS: gcc.dg/conv-3.c (test for excess errors)
>  PASS: gcc.dg/conv-3.c execution test
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 20)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 24)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 35)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 50)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 53)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 56)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 68)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 69)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 70)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 71)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 72)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 73)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 74)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 75)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 76)
> +PASS: gcc.dg/countof-compile.c  (test for warnings, line 80)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 100)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 109)
> +PASS: gcc.dg/countof-compile.c  (test for errors, line 114)
> +PASS: gcc.dg/countof-compile.c (test for excess errors)
> +PASS: gcc.dg/countof-vla.c (test for excess errors)
> +PASS: gcc.dg/countof.c (test for excess errors)
> +PASS: gcc.dg/countof.c execution test
>  PASS: gcc.dg/cr-decimal-dig-1.c (test for excess errors)
>  PASS: gcc.dg/cr-decimal-dig-2.c (test for excess errors)
>  PASS: gcc.dg/cr-decimal-dig-3.c (test for excess errors)
> @@ -208273,7 +208296,7 @@
>  
>               === gcc Summary ===
>  
> -# of expected passes         203197
> +# of expected passes         203220
>  # of unexpected failures     47
>  # of unexpected successes    2
>  # of expected failures               1467
> --- ../len16b_b4/./gcc/testsuite/gfortran/gfortran.sum        2024-10-17 
> 00:13:36.027361156 +0200
> +++ ./gcc/testsuite/gfortran/gfortran.sum     2024-10-18 02:42:26.303591286 
> +0200
> @@ -1,4 +1,4 @@
> -Test run by alx on Wed Oct 16 23:38:34 2024
> +Test run by alx on Fri Oct 18 02:07:15 2024
>  Native configuration is x86_64-pc-linux-gnu
>  
>               === gfortran tests ===
> --- ../len16b_b4/./gcc/testsuite/objc/objc.sum        2024-10-17 
> 00:14:42.583978154 +0200
> +++ ./gcc/testsuite/objc/objc.sum     2024-10-18 02:43:33.504187051 +0200
> @@ -1,4 +1,4 @@
> -Test run by alx on Thu Oct 17 00:13:36 2024
> +Test run by alx on Fri Oct 18 02:42:26 2024
>  Native configuration is x86_64-pc-linux-gnu
>  
>               === objc tests ===
> --- ../len16b_b4/./gcc/testsuite/g++/g++.sum  2024-10-16 23:38:33.908171142 
> +0200
> +++ ./gcc/testsuite/g++/g++.sum       2024-10-18 02:07:14.745543661 +0200
> @@ -1,4 +1,4 @@
> -Test run by alx on Wed Oct 16 22:35:00 2024
> +Test run by alx on Fri Oct 18 01:03:30 2024
>  Native configuration is x86_64-pc-linux-gnu
>  
>               === g++ tests ===
> --- ../len16b_b4/./x86_64-pc-linux-gnu/libitm/testsuite/libitm.sum    
> 2024-10-17 03:41:54.781371501 +0200
> +++ ./x86_64-pc-linux-gnu/libitm/testsuite/libitm.sum 2024-10-18 
> 06:08:27.040788653 +0200
> @@ -1,4 +1,4 @@
> -Test run by alx on Thu Oct 17 03:41:52 2024
> +Test run by alx on Fri Oct 18 06:08:24 2024
>  Native configuration is x86_64-pc-linux-gnu
>  
>               === libitm tests ===
> --- ../len16b_b4/./x86_64-pc-linux-gnu/libgomp/testsuite/libgomp.sum  
> 2024-10-17 03:41:52.169347276 +0200
> +++ ./x86_64-pc-linux-gnu/libgomp/testsuite/libgomp.sum       2024-10-18 
> 06:08:24.288765717 +0200
> @@ -1,4 +1,4 @@
> -Test run by alx on Thu Oct 17 03:27:33 2024
> +Test run by alx on Fri Oct 18 05:54:08 2024
>  Native configuration is x86_64-pc-linux-gnu
>  
>               === libgomp tests ===
> --- ../len16b_b4/./x86_64-pc-linux-gnu/libatomic/testsuite/libatomic.sum      
> 2024-10-17 03:41:56.989391978 +0200
> +++ ./x86_64-pc-linux-gnu/libatomic/testsuite/libatomic.sum   2024-10-18 
> 06:08:29.288807393 +0200
> @@ -1,4 +1,4 @@
> -Test run by alx on Thu Oct 17 03:41:55 2024
> +Test run by alx on Fri Oct 18 06:08:27 2024
>  Native configuration is x86_64-pc-linux-gnu
>  
>               === libatomic tests ===
> --- ../len16b_b4/./x86_64-pc-linux-gnu/libstdc++-v3/testsuite/libstdc++.sum   
> 2024-10-17 03:27:10.237000409 +0200
> +++ ./x86_64-pc-linux-gnu/libstdc++-v3/testsuite/libstdc++.sum        
> 2024-10-18 05:53:44.801155283 +0200
> @@ -1,4 +1,4 @@
> -Test run by alx on Thu Oct 17 00:15:11 2024
> +Test run by alx on Fri Oct 18 02:43:39 2024
>  Native configuration is x86_64-pc-linux-gnu
>  
>               === libstdc++ tests ===
> 
> 
> > 
> > Have a lovely night!
> > Alex
> > 
> > -- 
> > <https://www.alejandro-colomar.es/>
> 
> 
> 
> -- 
> <https://www.alejandro-colomar.es/>



-- 
<https://www.alejandro-colomar.es/>

Attachment: signature.asc
Description: PGP signature

Reply via email to