Hi Joseph, On Tue, May 20, 2025 at 02:43:55PM +0000, Joseph Myers wrote: > > Could you please clarify if I need to do anything or if this is already > > scheduled for review when you have some time? Also please clarify if > > you're okay with amending that or if you prefer that I send v23. > > I have it on my list for review.
Thanks!
> I'd prefer v23 (also with complete
> ChangeLog entries, please, rather than the present placeholders, so they
> don't need to be written at commit time).
The ChangeLog entries that I've sent are supposed to be complete. Did I
miss anything?
I've based on gnulib commits, which I believe follow the same
guidelines. For example:
commit 6608062398ef4c983a58b90a1520c39f12fb7ac1
Author: Paul Eggert <egg...@cs.ucla.edu>
Date: Fri Jan 10 10:34:58 2025 -0800
doc: document some file system portability issues
* doc/glibc-functions/flistxattr.texi:
* doc/glibc-functions/listxattr.texi:
* doc/glibc-functions/llistxattr.texi:
* doc/posix-functions/fchdir.texi, doc/posix-functions/fstat.texi:
* doc/posix-functions/fstatvfs.texi:
Document some portability gotchas that Gnulib does not work around.
Now I realize that maybe my changelog misses the trailing ':' for the
entries that have no text (because it's only once at the end)? So for
example instead of
gcc/c-family/ChangeLog:
* c-common.h
* c-common.def
* c-common.cc (c_countof_type): Add __countof__ operator.
I should do this?
gcc/c-family/ChangeLog:
* c-common.h:
* c-common.def:
* c-common.cc (c_countof_type): Add __countof__ operator.
Or maybe this?
gcc/c-family/ChangeLog:
* c-common.h:
* c-common.def:
* c-common.cc (c_countof_type):
Add __countof__ operator.
Please let me know.
Cheers,
Alex
--
<https://www.alejandro-colomar.es/>
signature.asc
Description: PGP signature
