RE: [PATCH 4/7] aarch64: Use EOR3 for DImode values

2025-07-07 Thread Tamar Christina
> -Original Message- > From: Kyrylo Tkachov > Sent: Monday, July 7, 2025 11:19 AM > To: GCC Patches > Cc: Richard Sandiford ; Richard Earnshaw > ; Alex Coplan ; Andrew > Pinski > Subject: [PATCH 4/7] aarch64: Use EOR3 for DImode values > > Hi all, > > Similar to BCAX, we can use EOR3 f

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-07 Thread Jakub Jelinek
On Tue, Jul 08, 2025 at 08:15:30AM +0200, Richard Biener wrote: > > No. Because (most of the) pointer conversions are useless, if you have > > _2 = &something.fam[0]; > > ... > > _4 = &something.fam; > > _5 = .ACCESS_WITH_SIZE (_4, ...); > > (or whatever else where _4 has the carefully chosen p

RE: [PATCH 4/7] aarch64: Use EOR3 for DImode values

2025-07-07 Thread Tamar Christina
> -Original Message- > From: Remi Machet > Sent: Monday, July 7, 2025 5:53 PM > To: Kyrylo Tkachov ; GCC Patches patc...@gcc.gnu.org> > Cc: Richard Sandiford ; Richard Earnshaw > ; Alex Coplan ; Andrew > Pinski > Subject: Re: [PATCH 4/7] aarch64: Use EOR3 for DImode values > > On 7/7/25

RE: [PATCH 3/7] aarch64: Handle DImode BCAX operations

2025-07-07 Thread Tamar Christina
> -Original Message- > From: Richard Sandiford > Sent: Monday, July 7, 2025 12:55 PM > To: Kyrylo Tkachov > Cc: GCC Patches ; Richard Earnshaw > ; Alex Coplan ; Andrew > Pinski > Subject: Re: [PATCH 3/7] aarch64: Handle DImode BCAX operations > > Richard Sandiford writes: > > Kyrylo Tk

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-07 Thread Richard Biener
> Am 08.07.2025 um 07:21 schrieb Jakub Jelinek : > > On Mon, Jul 07, 2025 at 07:51:52PM -0400, Siddhesh Poyarekar wrote: >>> On 2025-07-07 17:47, Jakub Jelinek wrote: >>> Even 6 arguments is IMHO too much. >>> /* Expand the IFN_ACCESS_WITH_SIZE function: >>>ACCESS_WITH_SIZE (REF_TO_OBJ, RE

Re: [PATCH 0/1] [RFC][AutoFDO]: Source filename tracking in GCOV

2025-07-07 Thread Kugan Vivekanandarajah
Hi Honza, > On 8 Jul 2025, at 2:26 am, Jan Hubicka wrote: > > External email: Use caution opening links or attachments > > > Hi, > as discussed also on the autofdo pull request, LLVM solves the same > problem using -funique-internal-linkage-names > https://reviews.llvm.org/D73307 > > All non-

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-07 Thread Jakub Jelinek
On Mon, Jul 07, 2025 at 07:51:52PM -0400, Siddhesh Poyarekar wrote: > On 2025-07-07 17:47, Jakub Jelinek wrote: > > Even 6 arguments is IMHO too much. > > /* Expand the IFN_ACCESS_WITH_SIZE function: > > ACCESS_WITH_SIZE (REF_TO_OBJ, REF_TO_SIZE, CLASS_OF_SIZE, > > TYPE_OF

RE: [PATCH v1] RISC-V: Disable uint128_t testcase of SAT_MUL when rv32

2025-07-07 Thread Li, Pan2
> Is that correct? Don't you need to be testing that the platform has > vector in addition to being rv64? It is riscv.exp test, so I think vector extension is not required here. Pan -Original Message- From: Jeff Law Sent: Tuesday, July 8, 2025 11:45 AM To: Li, Pan2 ; gcc-patches@gcc.

Re: [PATCH v1] RISC-V: Disable uint128_t testcase of SAT_MUL when rv32

2025-07-07 Thread Jeff Law
On 7/7/25 9:24 PM, pan2...@intel.com wrote: /**/ /* Saturation Add (unsigned and signed) */ diff --git a/gcc/testsuite/gcc.target/riscv/sat/sat_u_mul-run-1-u16-from-u128.c

[SNAPv4] libstdc++: Add NTTP bind_front, -back, not_fn (P2714) [PR119744]

2025-07-07 Thread Nathan Myers
This is a snapshot of work in progress, for reference. bind_front(...) is uglified directly from the sample implementation in P2714, at include/std/functional:1284 . Test failures: bind_front/1.cc:53: error: static assertion failed bind_front/1.cc:57: error: static assertion failed bind_front/1.c

[PATCH v1] RISC-V: Disable uint128_t testcase of SAT_MUL when rv32

2025-07-07 Thread pan2 . li
From: Pan Li The rv32 doesn't support __uint128, and then we will have error like below during test. error: '__int128' is not supported on this target. Thus, we disable the uint128_t related test when rv32. gcc/testsuite/ChangeLog: * gcc.target/riscv/sat/sat_arith.h: Add xlen check fo

[committed] Minor fix to gcc.dg/torture/pr120654.c

2025-07-07 Thread Jeff Law
I don't recall which port complained, but pr120654.c was failing on one or more of the embedded targets due to the use of malloc/free. This change just turns them into the __builtin variants which makes everyone happy again. Pushing to the trunk. jeffcommit 477abe67d34f7f8d1b0b12408e08769995

[PATCH, FYI] [vxworks] [x86] disable vxworks6 PIC on vxworks7

2025-07-07 Thread Alexandre Oliva
VxWorks6 used symbols __GOTT_BASE__ and __GOTT_INDEX__ to obtain the address of the global offset table. Starting with VxWorks7, that is no longer the case, but we've still issued these symbols in output_set_got. Do that only with VxWorks<7. Switching to the call-based PIC register sequence, w

[committed][RISC-V] Fix testsuite fallout from check-function-bodies change

2025-07-07 Thread Jeff Law
Minor fallout from HJ's recent change to the check-function-bodies code in the testsuite. The label isn't at all important here, so forcing it match is just a waste of time. So this patch just skips over the label. It fixes a handful of failures in testsuite: unix//-march=rv32gcv: gcc: gc

[FYI] [vxworks] add aarch64 to vxworks-dummy.h set

2025-07-07 Thread Alexandre Oliva
It's not strictly necessary, because nothing defined therein is referenced by anything in gcc/config/aarch64, but it was an oversight to not have it there. Tested with aarch64-vx7r2. I'm checking it in. for gcc/ChangeLog * config.gcc (vxworks-dummy.h): Add to aarch64-*-* as well. --

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-07 Thread Siddhesh Poyarekar
On 2025-07-07 17:47, Jakub Jelinek wrote: Even 6 arguments is IMHO too much. /* Expand the IFN_ACCESS_WITH_SIZE function: ACCESS_WITH_SIZE (REF_TO_OBJ, REF_TO_SIZE, CLASS_OF_SIZE, TYPE_OF_SIZE, ACCESS_MODE) which returns the REF_TO_OBJ same as the 1st argument;

RE: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL.

2025-07-07 Thread Robert Dubner
> -Original Message- > From: Rainer Orth > Sent: Monday, July 7, 2025 18:08 > To: Robert Dubner > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL. > > Hi Robert, > > > I have elsewhere described my frustration in trying, during development, > >

[PATCH v2] libstdc++: Search for tzdata on Windows (msys)

2025-07-07 Thread Björn Schäpers
From: Björn Schäpers Windows does not provide a tzdata.zi, but msys does. Use this, if available, instead of the embedded (and possibly outdated) database. libstdc++-v3/Changelog: Use msys provided time zone information. * src/c++20/tzdb.cc (zoneinfo_file): On Windows look rela

Re: [PATCH] libstdc++: Search for tzdata on Windows (msys)

2025-07-07 Thread Björn Schäpers
Am 07.07.2025 um 23:02 schrieb Jonathan Wakely: On Mon, 7 Jul 2025 at 22:01, Jonathan Wakely wrote: On Mon, 7 Jul 2025 at 21:26, Björn Schäpers wrote: From: Björn Schäpers Sorry for the noise, this is the current version of the Patch. -- >8 -- Windows does not provide a tzdata.zi, but ms

Re: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL.

2025-07-07 Thread Rainer Orth
Hi Robert, > I have elsewhere described my frustration in trying, during development, > to set more stringent error-finding and warning-generating compilation > options. But they seem to require the use of CXXFLAGS, which in at least > the case of trying to set -std=c++14, causes libcody's compil

[PATCH] cobol: Implement CXXFLAGS_FOR_COBOL.

2025-07-07 Thread Robert Dubner
I have elsewhere described my frustration in trying, during development, to set more stringent error-finding and warning-generating compilation options. But they seem to require the use of CXXFLAGS, which in at least the case of trying to set -std=c++14, causes libcody's compilation to fail, since

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-07 Thread Jakub Jelinek
On Mon, Jul 07, 2025 at 09:18:53PM +, Qing Zhao wrote: > From OLD: > > _2 = &a->c; > _3 = &a->count; > _1 = .ACCESS_WITH_SIZE (_2, _3, 1, 0, -1, 0B); > _4 = *_1; > D.2964 = __builtin_dynamic_object_size (_4, 1); > > To NEW: > > _2 = a->c; > _3 = &a->count; > _1 = .ACCESS_WITH_SIZE (_

[PATCH] Check backend when setting DECL_ALIGN for PARM_DECL

2025-07-07 Thread H.J. Lu
On Tue, Jul 8, 2025 at 5:02 AM H.J. Lu wrote: > > On Mon, Jul 7, 2025 at 11:08 PM Jason Merrill wrote: > > > > On 7/1/25 5:36 PM, H.J. Lu wrote: > > > On Tue, Jul 1, 2025 at 9:37 PM Jason Merrill wrote: > > >> > > >> On 6/30/25 7:03 PM, H.J. Lu wrote: > > >>> On Mon, Jun 30, 2025 at 10:36 PM Jas

Re: [PATCH 6/7] aarch64: Use SVE2 BSL1N for DImode arguments

2025-07-07 Thread Remi Machet
On 7/7/25 06:19, Kyrylo Tkachov wrote: > External email: Use caution opening links or attachments > > > Hi all, > > Similar to other patches in this series, this patch adds a splitter > for DImode BSL1N operations, taking care to generate the right code > in the GP regs case. > > Thus for the test

Re: [PATCH 5/7] aarch64: Use SVE2 NBSL for DImode arguments

2025-07-07 Thread Remi Machet
On 7/7/25 06:19, Kyrylo Tkachov wrote: External email: Use caution opening links or attachments Hi all, Similar to the BCAX and EOR3 patterns from TARGET_SHA3 we can use the SVE2 NBSL instruction for DImode arugments when they come in SIMD registers. Minor nit: there is a typo in "arugments"

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-07 Thread Qing Zhao
Hi, thanks a lot for all the discussion so far on this issue. An update on this: 1. I have reverted the 3 patches to support counted_by for pointers I have committed last week from master. 2. At the same time: On the C FE code generation to .ACCESS_WITH_SIZE for pointers with counted_by att

Re: [PATCH] c-family: Check backend for argument alignment on stack

2025-07-07 Thread H.J. Lu
On Mon, Jul 7, 2025 at 11:08 PM Jason Merrill wrote: > > On 7/1/25 5:36 PM, H.J. Lu wrote: > > On Tue, Jul 1, 2025 at 9:37 PM Jason Merrill wrote: > >> > >> On 6/30/25 7:03 PM, H.J. Lu wrote: > >>> On Mon, Jun 30, 2025 at 10:36 PM Jason Merrill wrote: > > On 6/28/25 7:00 AM, H.J. Lu wr

[PATCH] libstdc++: provide debug impl of P2697 ctor [PR119742]

2025-07-07 Thread Nathan Myers
This adds the new bitset constructor from string_view defined in P2697 to the debug version of the type. libstdc++-v3/Changelog: PR libstdc++/119742 * include/debug/bitset: Add new ctor. --- libstdc++-v3/include/debug/bitset | 12 1 file changed, 12 insertions(+) dif

Re: [PATCH] libstdc++: Search for tzdata on Windows (msys)

2025-07-07 Thread Jonathan Wakely
On Mon, 7 Jul 2025 at 22:01, Jonathan Wakely wrote: > > On Mon, 7 Jul 2025 at 21:26, Björn Schäpers wrote: > > > > From: Björn Schäpers > > > > Sorry for the noise, this is the current version of the Patch. > > > > -- >8 -- > > Windows does not provide a tzdata.zi, but msys does. Use this, if >

Re: [PATCH] libstdc++: Search for tzdata on Windows (msys)

2025-07-07 Thread Jonathan Wakely
On Mon, 7 Jul 2025 at 21:26, Björn Schäpers wrote: > > From: Björn Schäpers > > Sorry for the noise, this is the current version of the Patch. > > -- >8 -- > Windows does not provide a tzdata.zi, but msys does. Use this, if > available, instead of the embedded (and possibly outdated) database. >

[PATCH] c++: P2036R3 - Change scope of lambda trailing-return-type [PR102610]

2025-07-07 Thread Marek Polacek
Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8 -- This patch is an attempt to implement P2036R3 along with P2579R0, fixing build breakages caused by P2036R3. The simplest example is: auto counter1 = [j=0]() mutable -> decltype(j) { return j++; }; which currently do

Re: [PATCH] check-function-bodies: Support "^[0-9]+:"

2025-07-07 Thread H.J. Lu
On Fri, Jul 4, 2025 at 5:20 PM H.J. Lu wrote: > > On Thu, Jul 3, 2025 at 2:02 PM H.J. Lu wrote: > > > > On Wed, Jul 2, 2025 at 9:12 AM H.J. Lu wrote: > > > > > > While working on > > > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=120881 > > > > > > I tried to use check-function-bodies to v

[PATCH] libstdc++: Search for tzdata on Windows (msys)

2025-07-07 Thread Björn Schäpers
From: Björn Schäpers Sorry for the noise, this is the current version of the Patch. -- >8 -- Windows does not provide a tzdata.zi, but msys does. Use this, if available, instead of the embedded (and possibly outdated) database. libstdc++-v3/Changelog: Use msys provided time zone inform

[PATCH] libstdc++: Search for tzdata on Windows (msys)

2025-07-07 Thread Björn Schäpers
From: Björn Schäpers Windows does not provide a tzdata.zi, but msys does. Use this, if available, instead of the embedded (and possibly outdated) database. libstdc++-v3/Changelog: Use msys provided time zone information. * src/c++20/tzdb.cc (zoneinfo_file): On Windows look rela

[PATCH] libstdc++: Search for tzdata on Windows (msys)

2025-07-07 Thread Björn Schäpers
From: Björn Schäpers Windows does not provide a tzdata.zi, but msys does. Use this, if available, instead of the embedded (and possibly outdated) database. libstdc++-v3/Changelog: Use msys provided time zone information. * src/c++20/tzdb.cc (zoneinfo_file): On Windows look rela

Re: [PATCH 17/17] Ignore more clang warnings in contrib/filter-clang-warnings.py

2025-07-07 Thread Martin Jambor
On Wed, Jun 25 2025, Martin Jambor wrote: > Hi, > > in contrib we have a script filter-clang-warnings.py which supposedly > filters out uninteresting warnings emitted by clang when it compiles > GCC. I'm not sure if anyone else uses it but our internal SUSE > testing infrastructure does. > > Since

[PATCH] ranger: Mark three occurrences of verify_range with overide

2025-07-07 Thread Martin Jambor
Hi, in line with my previous patches introducing override where clang warnings indicate that they are missing, this patch adds it to three new member functions overriding ancestor virtual functions that do not have them. Since Andrew has pre-approved such changes for ranger, I am going to push it

Re: [PATCH, v2] Fortran: fix minor issues with coarrays (extended)

2025-07-07 Thread Steve Kargl
On Mon, Jul 07, 2025 at 08:53:16PM +0200, Harald Anlauf wrote: > Andre, > > I still don't get it, and the present version made it worse for me... > > So let's see what I was thinking. There are the following types of > functions: > > (0) impure, non-elemental functions, which likely have side-e

Re: [PATCH, v2] Fortran: fix minor issues with coarrays (extended)

2025-07-07 Thread Harald Anlauf
Andre, I still don't get it, and the present version made it worse for me... So let's see what I was thinking. There are the following types of functions: (0) impure, non-elemental functions, which likely have side-effects (1) pure functions (in the f95 sense), i.e. pure non-elemental (2)

[COMMITTED] xtensa: Remove TARGET_PROMOTE_PROTOTYPES

2025-07-07 Thread Max Filippov
From: "H.J. Lu" xtensa ABI requires sign extension of signed 8/16-bit arguments to 32 bits and zero extension of unsigned 8/16-bit arguments to 32 bits. TARGET_PROMOTE_PROTOTYPES is an optimization, not an ABI requirement. Remove TARGET_PROMOTE_PROTOTYPES and define xtensa_promote_function_mode t

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-07-07 Thread Steve Kargl
On Sun, Jul 06, 2025 at 09:09:53PM +0800, Yuao Ma wrote: > Hi Tobias, > > On 7/6/2025 6:34 PM, Tobias Burnus wrote: > > As that commit is from 2020 and 2.69 in from 2012, it seems as if your > > autoconf is too new. Can you re-check that the right version is at the > > beginning of the PATH? > >

Re: [Ping, Fortran, Patch, PR120637, v1] Ensure expression in finalizer creation is freed only when unused.

2025-07-07 Thread Jerry D
On 7/7/25 8:39 AM, Andre Vehreschild wrote: Ping! OK for mainline. Thanks, Jerry On Thu, 26 Jun 2025 15:32:47 +0200 Andre Vehreschild wrote: Hi, I found a bug in the module cleanup expression at the end of the test. In the attached patch it is corrected. Regtests ok on x86_64-pc-linux

Fix profile scaling in tree-inline.cc:initialize_cfun

2025-07-07 Thread Jan Hubicka
Hi, initialize_cfun calls profile_count::adjust_for_ipa_scaling (&num, &den); but then the result is never used. This patch fixes it. Overall scalling of entry/exit block is bit sloppy in tree-inline. I see if I can clean it up. Bootstrapped/regtested x86_64-linux, comitted. * tree-in

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-07 Thread Siddhesh Poyarekar
On 2025-07-07 13:07, Qing Zhao wrote: If the current bug is urgent to be fixed. and you are not comfortable with the simple Patch Sid provided, then I am okay to back it out now and then push it back with the fix to this current bug at a later time after everyone is comfortable with the curren

Re: [PATCH] testsuite: Restore dg-do run on pr116906 and pr78185 tests

2025-07-07 Thread Christophe Lyon
On Mon, 7 Jul 2025 at 15:47, Torbjorn SVENSSON wrote: > > > > On 2025-07-03 15:02, Christophe Lyon wrote: > > ping^2 ? > > Looks fine to me, but as you know, my approval does not count. > Thanks for confirming I didn't miss anything from your intentions. Christophe > Kind regards, > Torbjörn > >

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-07 Thread Qing Zhao
> On Jul 7, 2025, at 11:58, Siddhesh Poyarekar wrote: > > On 2025-07-07 09:33, Siddhesh Poyarekar wrote: >>> The only difference between &a->fam[0] and &a->fam is not the value (that is >>> the same), just the type in one case say int *, in the other int [0:] *. >>> At least in GIMPLE pointer

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-07 Thread Qing Zhao
> On Jul 7, 2025, at 02:05, Richard Biener wrote: > > On Sat, Jul 5, 2025 at 2:10 PM Siddhesh Poyarekar wrote: >> >> On 2025-07-05 07:23, Richard Biener wrote: OK, should I revert right away or can we wait till Qing returns on Monday? >>> >>> Monday is OK with me. >>> >> >> Thanks, so

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-07 Thread Siddhesh Poyarekar
On 2025-07-07 09:33, Siddhesh Poyarekar wrote: The only difference between &a->fam[0] and &a->fam is not the value (that is the same), just the type in one case say int *, in the other int [0:] *. At least in GIMPLE pointer conversions are useless, so what exact type of the argument is doesn't m

Re: [PATCH 4/7] aarch64: Use EOR3 for DImode values

2025-07-07 Thread Remi Machet
On 7/7/25 06:18, Kyrylo Tkachov wrote: > External email: Use caution opening links or attachments > > > Hi all, > > Similar to BCAX, we can use EOR3 for DImode, but we have to be careful > not to force GP<->SIMD moves unnecessarily, so add a splitter for that case. > > So for input: > uint64_t eor3

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-07 Thread Qing Zhao
Hi, Sorry for the late reply. And thanks a lot for all the help so far. For the documantion of the .ACCESS_WITH_SIZE for pointers, please see the following in c/c-typeck.cc : /* Given a COMPONENT_REF REF with the location LOC, the corresponding COUNTED_BY_REF, and the

Re: [PATCH 2/7] aarch64: Use EOR3 for 64-bit vector modes

2025-07-07 Thread Andrew Pinski
On Mon, Jul 7, 2025 at 2:56 AM Kyrylo Tkachov wrote: > > Hi all, > > Similar to the BCAX patch, we can also use EOR3 for 64-bit modes, > just by adjusting the mode iterator used. > Thus for input: > > uint32x2_t > bcax_s (uint32x2_t a, uint32x2_t b, uint32x2_t c) > { > return EOR3 (a, b, c); > }

Re: [PATCH 0/1] [RFC][AutoFDO]: Source filename tracking in GCOV

2025-07-07 Thread Jan Hubicka
Hi, as discussed also on the autofdo pull request, LLVM solves the same problem using -funique-internal-linkage-names https://reviews.llvm.org/D73307 All non-public functions gets theis symbol renamed from .__uniq. Decadic is used since demanglers special case numerical suffixes. In addition debug

Re: [PATCH][RFC] phiopt: Optimize A < 0 ? ARG1 OP 2^n-1 : ARG1

2025-07-07 Thread Raphael Zinsly
On Mon, Jun 30, 2025 at 11:29 AM Jeff Law wrote: > So I think the overall direction is: > > 1. Try to do the translation in match.pd > 2. Target the conditional move form > 3. Adjust expanders and/or target bits as necessary to avoid regressions That works for me too, I'll start working on it.

Re: [PATCH] c++: -fno-delete-null-pointer-checks constexpr addr comparison [PR71962]

2025-07-07 Thread Jakub Jelinek
On Mon, Jul 07, 2025 at 11:59:48AM -0400, Jason Merrill wrote: > > Another case are targets with implicit -fno-delete-null-pointer-checks or > > when users use that explicitly. In that case one variable or function can > > actually end up being at address 0, so am not sure if it is correct to > >

Re: [PATCH v1] libstdc++: Better CTAD for span and mdspan [P3029].

2025-07-07 Thread Tomasz Kaminski
For the title, I have created bugzilla PR120914. for this paper: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=120914 On Fri, Jul 4, 2025 at 10:34 AM Luc Grosheintz wrote: > This implements P3029R1. In P3029R1, the CTAD for span is refined to > permit deducing the extent of the span from an integ

[PATCH] RISC-V: Vector-scalar widening multiply-(subtract-)accumulate [PR119100]

2025-07-07 Thread Paul-Antoine Arras
This pattern enables the combine pass (or late-combine, depending on the case) to merge a float-extended vec_duplicate into a plus-mult or minus-mult RTL instruction. Before this patch, we have three instructions, e.g.: fcvt.s.h fa5,fa5 vfmv.v.f v24,fa5 vfmadd.vv v8,v24,v16

[PATCH][committed][testsuite]: add sve hw check to testcase [PR120817]

2025-07-07 Thread Tamar Christina
Drop down from SVE2 to SVE1 as that's the minimum required for the test, and since it's a mid-end test add the aarch64_sve_hw check. Regtested on aarch64-none-linux-gnu and no issues. committed to master. Thanks, Tamar gcc/testsuite/ChangeLog: PR tree-optimization/120817 * gcc.

Re: [PATCH] c++: -fno-delete-null-pointer-checks constexpr addr comparison [PR71962]

2025-07-07 Thread Jason Merrill
On 7/3/25 9:46 AM, Jakub Jelinek wrote: On Thu, Jul 03, 2025 at 09:35:49AM -0400, Jason Merrill wrote: On 7/2/25 7:58 PM, Patrick Palka wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- Here the flag -fno-delete-null-pointer-checks causes the triv

Re: [PATCH] libstdc++: Format %a/%A/%b/%h/%B/%p without using locale::classic [PR110739]

2025-07-07 Thread Tomasz Kaminski
On Mon, Jul 7, 2025 at 5:06 PM Tomasz Kamiński wrote: > With changes r16-2063-g8ad5968a8dcb47 the _M_a_A, _M_b_B and _M_p functions > are called only if the locale is equal to the locale::classic(), for which > the behavior is know. This patch changes they implementation, so instead of > refferin

Re: [Ping, Fortran, Patch, PR120637, v1] Ensure expression in finalizer creation is freed only when unused.

2025-07-07 Thread Andre Vehreschild
Ping! On Thu, 26 Jun 2025 15:32:47 +0200 Andre Vehreschild wrote: > Hi, > > I found a bug in the module cleanup expression at the end of the test. In the > attached patch it is corrected. > > Regtests ok on x86_64-pc-linux-gnu / F41. Ok for mainline? > > Regards, > Andre > > On Wed, 25

Re: [PATCH] c++: -fno-delete-null-pointer-checks constexpr addr comparison [PR71962]

2025-07-07 Thread Jakub Jelinek
On Thu, Jul 03, 2025 at 09:35:49AM -0400, Jason Merrill wrote: > On 7/2/25 7:58 PM, Patrick Palka wrote: > > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK > > for trunk? > > > > -- >8 -- > > > > Here the flag -fno-delete-null-pointer-checks causes the trivial address > > co

Re: [AutoFDO] Fix get_original_name to strip only names that are generated after auto-profile

2025-07-07 Thread Jan Hubicka
Hi, there are two bugs in get_original_name. First the for loop walking list of known suffixes uses sizeos (suffixes). It evnetually walks to an empty suffix. Second problem is that strcmp may accept suffixes that are longer. I.e. mix up .isra with .israabc. This is probably not a big deal bu

Re: [PATCH] libstdc++: Make VERIFY a variadic macro

2025-07-07 Thread Tomasz Kaminski
On Wed, Jul 2, 2025 at 12:31 PM Jonathan Wakely wrote: > This defines the testsuite assertion macro VERIFY so that it allows > un-parenthesized expressions containing commas. This matches how assert > is defined in C++26, following the approval of P2264R7. > > The primary motivation is to allow e

Re: [PATCH v2] c++: Fix FMV return type ambiguation

2025-07-07 Thread Jason Merrill
On 7/2/25 7:58 AM, Alfie Richards wrote: Hi Jason, Thanks for the feedback, see below an updated patch. OK. Again reg-tested on Aarch64 and x86. Thanks, Alfie -- >8 -- Add logic for the case of two FMV annotated functions with identical signature other than the return type. Previously th

[PATCH v2] Handle non default git prefix configurations

2025-07-07 Thread Pierre-Emmanuel Patry
Mklog parses the diff content from prepare-commit-msg hook but fails when git has been configured with mnemonicPrefix. Forcing the default values for the prefixes would set a distinct diff configuration supported by mklog and prevent most failures. contrib/ChangeLog: * prepare-commit-msg:

Re: [PATCH] Handle non default git configurations with mklog

2025-07-07 Thread Pierre-Emmanuel Patry
On 7/7/25 3:41 PM, Alexander Monakov wrote: Is switching the algorithm actually necessary for solving the problem at hand? I think it is possible for the default algorithm to produce diffs that lead to poorly generated changelog entries, so forcing it here seems undesirable. I was not aware of

Re: [PATCH] c-family: Check backend for argument alignment on stack

2025-07-07 Thread Jason Merrill
On 7/1/25 5:36 PM, H.J. Lu wrote: On Tue, Jul 1, 2025 at 9:37 PM Jason Merrill wrote: On 6/30/25 7:03 PM, H.J. Lu wrote: On Mon, Jun 30, 2025 at 10:36 PM Jason Merrill wrote: On 6/28/25 7:00 AM, H.J. Lu wrote: Since a backend may ignore user type alignment for arguments passed on stack, c

[PATCH] libstdc++: Format %a/%A/%b/%h/%B/%p without using locale::classic [PR110739]

2025-07-07 Thread Tomasz Kamiński
With changes r16-2063-g8ad5968a8dcb47 the _M_a_A, _M_b_B and _M_p functions are called only if the locale is equal to the locale::classic(), for which the behavior is know. This patch changes they implementation, so instead of reffering to __timepunct facet members, they use hardcoded list of Engli

[pushed] c++: -Wno-abbreviated-auto-in-template-arg [PR120917]

2025-07-07 Thread Jason Merrill
Tested x86_64-pc-linux-gnu, applying to trunk. -- 8< -- In r14-1659 I added a missing error for a Concepts TS feature that we were failing to diagnose, but this PR requests a way to disable that error for code written thinking it was valid. Which seems reasonable, since it doesn't require any wo

[PATCH v1 2/3] RISC-V: Add test for vec_duplicate + vssub.vv combine case 0 with GR2VR cost 0, 2 and 15

2025-07-07 Thread pan2 . li
From: Pan Li Add asm dump check and run test for vec_duplicate + vssub.vv combine to vssub.vx, with the GR2VR cost is 0, 2 and 15. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/autovec/vx_vf/vx-1-i16.c: Add asm check. * gcc.target/riscv/rvv/autovec/vx_vf/vx-1-i32.c: Ditto.

[PATCH v1 3/3] RISC-V: Add test for vec_duplicate + vssub.vv combine case 1 with GR2VR cost 0, 1 and 2

2025-07-07 Thread pan2 . li
From: Pan Li Add asm dump check test for vec_duplicate + vssub.vv combine to vssub.vx, with the GR2VR cost is 0, 1 and 2. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/autovec/vx_vf/vx-4-i16.c: Add asm check. * gcc.target/riscv/rvv/autovec/vx_vf/vx-4-i32.c: Ditto. * gc

[PATCH v1 1/3] RISC-V: Combine vec_duplicate + vssub.vv to vssub.vx on GR2VR cost

2025-07-07 Thread pan2 . li
From: Pan Li This patch would like to combine the vec_duplicate + vssub.vv to the vssub.vx. From example as below code. The related pattern will depend on the cost of vec_duplicate from GR2VR. Then the late-combine will take action if the cost of GR2VR is zero, and reject the combination if th

[PATCH v1 0/3] RISC-V: Combine vec_duplicate + vssub.vv to vssub.vx on GR2VR cost

2025-07-07 Thread pan2 . li
From: Pan Li This patch would like to introduce the combine of vec_dup + vssub.vv into vssub.vx on the cost value of GR2VR. The late-combine will take place if the cost of GR2VR is zero, or reject the combine if non-zero like 1, 2, 15 in test. There will be two cases for the combine: Case 0:

Re: [PATCH] aarch64: Improve popcountti2 with SVE

2025-07-07 Thread Kyrylo Tkachov
> On 7 Jul 2025, at 13:27, Richard Sandiford wrote: > > Tamar Christina writes: >>> -Original Message- >>> From: Kyrylo Tkachov >>> Sent: Monday, July 7, 2025 10:38 AM >>> To: GCC Patches >>> Cc: Richard Sandiford ; Richard Earnshaw >>> ; Alex Coplan ; Andrew >>> Pinski >>> Subject:

[PATCH] tree-optimization/120358 - bogus PTA with structure access

2025-07-07 Thread Richard Biener
When we compute the constraint for something like MEM[(const struct QStringView &)&tok2 + 32] we go and compute what (const struct QStringView &)&tok2 + 32 points to and then add subvariables to its dereference that possibly fall in the range of the access according to the original refs size. In d

Re: [PATCH v3 1/5] libstdc++: Check prerequisites of layout_*::operator().

2025-07-07 Thread Tomasz Kaminski
On Mon, Jul 7, 2025 at 3:29 PM Luc Grosheintz wrote: > > On 7/4/25 10:29, Luc Grosheintz wrote: > > Previously, the prerequisite that the arguments passed to operator() are > > a multi-dimensional index (of extents()) was not checked. > > > > Both mapping::operator() and mdspan::operator[] have t

Re: [PATCH v3] libstdc++: Format chrono %a/%A/%b/%h/%B/%p using locale's time_put [PR117214]

2025-07-07 Thread Jonathan Wakely
On Mon, 7 Jul 2025 at 14:21, Tomasz Kamiński wrote: > > From: XU Kailiang > > C++ formatting locale could have a custom time_put that performs > differently from the C locale, so do not use __timepunct directly, > instead all of above specifiers use _M_locale_fmt. > > For %a/%A/%b/%h/%B, the code

Re: [PATCH] testsuite: Restore dg-do run on pr116906 and pr78185 tests

2025-07-07 Thread Torbjorn SVENSSON
On 2025-07-03 15:02, Christophe Lyon wrote: ping^2 ? Looks fine to me, but as you know, my approval does not count. Kind regards, Torbjörn On Wed, 18 Jun 2025 at 12:11, Christophe Lyon wrote: ping? On Mon, 26 May 2025 at 17:26, Christophe Lyon wrote: On Mon, 26 May 2025 at 17:14,

Re: [PATCH] Handle non default git configurations with mklog

2025-07-07 Thread Alexander Monakov
On Tue, 1 Jul 2025, Pierre-Emmanuel Patry wrote: > Mklog parses the diff content from prepare-commit-msg hook but fails > when git has been configured with some options (eg. mnemonicPrefix). > Forcing the default values for the prefixes and the algorithm would > set a distinct diff configuration

Re: [PATCH v3 5/5] libstdc++: Implement mdspan and tests [PR107761].

2025-07-07 Thread Tomasz Kaminski
I used TEST_MDSPAN_LAYOUT_LIKE_H as header guard. On Mon, Jul 7, 2025 at 10:58 AM Tomasz Kaminski wrote: > > > On Fri, Jul 4, 2025 at 10:37 AM Luc Grosheintz > wrote: > >> Implements the class mdspan as described in N4950, i.e. without P3029. >> It also adds tests for mdspan. This commit comple

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-07 Thread Siddhesh Poyarekar
On 2025-07-07 09:14, Jakub Jelinek wrote: So that ought to be &a->fam[0] right, and not &a->fam? It means the same for a FAM, so why not specify it as &a->fam[0] (or simply a->fam)? That will be consistent with when fam is a pointer. The only difference between &a->fam[0] and &a->fam is not th

Re: [PATCH v3 1/5] libstdc++: Check prerequisites of layout_*::operator().

2025-07-07 Thread Luc Grosheintz
On 7/4/25 10:29, Luc Grosheintz wrote: Previously, the prerequisite that the arguments passed to operator() are a multi-dimensional index (of extents()) was not checked. Both mapping::operator() and mdspan::operator[] have the same prerequisite. Since, mdspan must check the prerequisite for us

RE: [PATCH] tree-optimization/120817 - bogus DSE of .MASK_STORE

2025-07-07 Thread Richard Biener
On Mon, 7 Jul 2025, Tamar Christina wrote: > > -Original Message- > > From: Richard Biener > > Sent: Monday, July 7, 2025 12:30 PM > > To: gcc-patches@gcc.gnu.org > > Cc: Tamar Christina > > Subject: [PATCH] tree-optimization/120817 - bogus DSE of .MASK_STORE > > > > DSE used ao_ref_ini

[PATCH v3] libstdc++: Format chrono %a/%A/%b/%h/%B/%p using locale's time_put [PR117214]

2025-07-07 Thread Tomasz Kamiński
From: XU Kailiang C++ formatting locale could have a custom time_put that performs differently from the C locale, so do not use __timepunct directly, instead all of above specifiers use _M_locale_fmt. For %a/%A/%b/%h/%B, the code handling the exception is now moved to the _M_check_ok function, t

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-07 Thread Jakub Jelinek
On Mon, Jul 07, 2025 at 09:07:14AM -0400, Siddhesh Poyarekar wrote: > On 2025-07-07 08:48, Jakub Jelinek wrote: > > > The return value of .ACCESS_WITH_SIZE clobbering PTR (that subsequently > > > gets > > > passed to __builtin_dynamic_object_size) should be sufficient to fully > > > prevent the re

Re: [PATCH] [testsuite] [arm] adjust fp16-aapcs for gcc-14

2025-07-07 Thread Torbjorn SVENSSON
Hi Christophe, Alexandre, Andrew and Richard, Sorry for the very late reply. I've been occupied with other tasks than GCC for the past 3 months. On 2025-05-20 09:56, Christophe Lyon wrote: On Tue, 20 May 2025 at 06:30, Alexandre Oliva wrote: (The backport I've only just posted is not enou

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-07 Thread Siddhesh Poyarekar
On 2025-07-07 08:48, Jakub Jelinek wrote: The return value of .ACCESS_WITH_SIZE clobbering PTR (that subsequently gets passed to __builtin_dynamic_object_size) should be sufficient to fully prevent the reordering, it shouldn't have to clobber &PTR, I think. The original use of .ACCESS_WITH_SIZE

Re: Add template keyword to for Clang

2025-07-07 Thread Jonathan Wakely
On Mon, 7 Jul 2025 at 12:25, Luc Grosheintz wrote: > > > > On 7/5/25 01:13, Jonathan Wakely wrote: > > Clang wants this change: > > > > --- a/libstdc++-v3/include/std/mdspan > > +++ b/libstdc++-v3/include/std/mdspan > > @@ -509,7 +509,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > > > template > >

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-07 Thread Jakub Jelinek
On Mon, Jul 07, 2025 at 07:21:26AM -0400, Siddhesh Poyarekar wrote: > > is .ACCESS_WITH_SIZE documented? I can't find it documented in the > > internals manual, internal-fn.def has > > It's documented in tree-object-size.cc as: > > /* Compute __builtin_object_size for a CALL to .ACCESS_WITH_SIZE

Re: [PATCH v1] libstdc++: Set FMT for complete C++23 mdspan.

2025-07-07 Thread Tomasz Kaminski
On Mon, Jul 7, 2025 at 2:11 PM Luc Grosheintz wrote: > > On 7/7/25 13:30, Tomasz Kaminski wrote: > > Ah, I just missed the other e-mail, and just found it. > > Yes, in that case it makes sense to include it in the patch series. > > You may also update the last two commits. > > I'm not quite sure

Re: [PATCH v1] libstdc++: Set FMT for complete C++23 mdspan.

2025-07-07 Thread Luc Grosheintz
On 7/7/25 13:30, Tomasz Kaminski wrote: Ah, I just missed the other e-mail, and just found it. Yes, in that case it makes sense to include it in the patch series. You may also update the last two commits. I'm not quite sure what you mean by "update the last two commits". Do you mean that I s

[Ada] Reapply tweaks to delay statements in ACATS 3&4 testsuites

2025-07-07 Thread Eric Botcazou
They had originally been applied to the ACATS 2 testsuite and I forgot to reapply them to the ACATS 4 testsuite altogether. Tested on x86-64/Linux, applied on the mainline. 2025-07-07 Eric Botcazou * ada/acats-3/tests/c9/c94001c.ada: Tweak delay statements. * ada/acats-4/tes

Re: [PATCH 3/7] aarch64: Handle DImode BCAX operations

2025-07-07 Thread Richard Sandiford
Richard Sandiford writes: > Kyrylo Tkachov writes: >> Hi all, >> >> To handle DImode BCAX operations we want to do them on the SIMD side only if >> the incoming arguments don't require a cross-bank move. >> This means we need to split back the combination to separate GP BIC+EOR >> instructions if

RE: [PATCH] tree-optimization/120817 - bogus DSE of .MASK_STORE

2025-07-07 Thread Tamar Christina
> -Original Message- > From: Richard Biener > Sent: Monday, July 7, 2025 12:30 PM > To: gcc-patches@gcc.gnu.org > Cc: Tamar Christina > Subject: [PATCH] tree-optimization/120817 - bogus DSE of .MASK_STORE > > DSE used ao_ref_init_from_ptr_and_size for .MASK_STORE but > alias-analysis wil

Re: [PATCH 3/7] aarch64: Handle DImode BCAX operations

2025-07-07 Thread Richard Sandiford
Kyrylo Tkachov writes: > Hi all, > > To handle DImode BCAX operations we want to do them on the SIMD side only if > the incoming arguments don't require a cross-bank move. > This means we need to split back the combination to separate GP BIC+EOR > instructions if the operands are expected to be in

Re: [PATCH v1] libstdc++: Set FMT for complete C++23 mdspan.

2025-07-07 Thread Tomasz Kaminski
Ah, I just missed the other e-mail, and just found it. Yes, in that case it makes sense to include it in the patch series. You may also update the last two commits. On Mon, Jul 7, 2025 at 1:27 PM Luc Grosheintz wrote: > > > On 7/7/25 13:24, Tomasz Kaminski wrote: > > On Mon, Jul 7, 2025 at 12:34

[PATCH] tree-optimization/120817 - bogus DSE of .MASK_STORE

2025-07-07 Thread Richard Biener
DSE used ao_ref_init_from_ptr_and_size for .MASK_STORE but alias-analysis will use the specified size to disambiguate against smaller objects. For .MASK_STORE we instead have to make the access size unspecified but we can still constrain the access extent based on the maximum size possible. Boots

Re: [PATCH] aarch64: Improve popcountti2 with SVE

2025-07-07 Thread Richard Sandiford
Tamar Christina writes: >> -Original Message- >> From: Kyrylo Tkachov >> Sent: Monday, July 7, 2025 10:38 AM >> To: GCC Patches >> Cc: Richard Sandiford ; Richard Earnshaw >> ; Alex Coplan ; Andrew >> Pinski >> Subject: [PATCH] aarch64: Improve popcountti2 with SVE >> >> Hi all, >> >>

Re: [PATCH v1] libstdc++: Set FMT for complete C++23 mdspan.

2025-07-07 Thread Luc Grosheintz
On 7/7/25 13:24, Tomasz Kaminski wrote: On Mon, Jul 7, 2025 at 12:34 PM Luc Grosheintz wrote: On 7/7/25 11:45, Tomasz Kaminski wrote: On Mon, Jul 7, 2025 at 11:41 AM Luc Grosheintz libstdc++-v3/ChangeLog: * include/bits/version.def (mdspan): Set to 202207 and remove

Re: [PATCH v2] s390: Optimize fmin/fmax.

2025-07-07 Thread Stefan Schulze Frielinghaus
On Mon, Jul 07, 2025 at 01:06:44PM +0200, Juergen Christ wrote: > Done. Should I send a v3? If bootstrapped and the new tests are still successful (no need for a full testsuite run I guess), then feel free to push immediately.

  1   2   >