On Fri, Jul 4, 2025 at 5:20 PM H.J. Lu <hjl.to...@gmail.com> wrote:
>
> On Thu, Jul 3, 2025 at 2:02 PM H.J. Lu <hjl.to...@gmail.com> wrote:
> >
> > On Wed, Jul 2, 2025 at 9:12 AM H.J. Lu <hjl.to...@gmail.com> wrote:
> > >
> > > While working on
> > >
> > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=120881
> > >
> > > I tried to use check-function-bodies to verify that
> > >
> > > 1: call mcount
> > >
> > > generated by "-pg" is placed at the function entry.  Add "^[0-9]+:" to
> > > check-function-bodies to allow:
> > >
> > > 1: call mcount
> > >
> > > PR testsuite/120881
> > > * lib/scanasm.exp (check-function-bodies): Allow "^[0-9]+:".
> > >
> > > OK for master?
> > >
> >
> > Any comments on this simple change:
> >
> > diff --git a/gcc/testsuite/lib/scanasm.exp b/gcc/testsuite/lib/scanasm.exp
> > index 97935cb23c3..a2311de5704 100644
> > --- a/gcc/testsuite/lib/scanasm.exp
> > +++ b/gcc/testsuite/lib/scanasm.exp
> > @@ -1109,6 +1109,8 @@ proc check-function-bodies { args } {
> >   append function_regexp ".*"
> >       } elseif { [regexp {^\.L} $line] } {
> >   append function_regexp $line "\n"
> > +     } elseif { [regexp {^[0-9]+:} $line] } {
> > + append function_regexp $line "\n"
> >       } else {
> >   append function_regexp $config(line_prefix) $line "\n"
> >       }
> >
> > This blocks other patches I am working on.
> >
>
> If there are no objections, I will check these 2 line changes next week to
> fix:
>
> +FAIL: gcc.target/i386/pr120936-10.c check-function-bodies foo
> +FAIL: gcc.target/i386/pr120936-11.c check-function-bodies foo
> +FAIL: gcc.target/i386/pr120936-12.c check-function-bodies foo
> +FAIL: gcc.target/i386/pr120936-4.c check-function-bodies foo
> +FAIL: gcc.target/i386/pr120936-5.c check-function-bodies foo
> +FAIL: gcc.target/i386/pr120936-6.c check-function-bodies foo
> +FAIL: gcc.target/i386/pr120936-8.c check-function-bodies foo
>
> on x86.
>
> --
> H.J.

I am checking it in.


-- 
H.J.

Reply via email to