Francesco Romani has posted comments on this change.
Change subject: hostdeploy: fix findbugs
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42422
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has uploaded a new change for review.
Change subject: hostdeploy: fix findbugs
..
hostdeploy: fix findbugs
Fixes DLS_DEAD_LOCAL_STORE, which is pretty harmless anyway.
Change-Id: I5a44be674d96256121c7f3d09ab099
Francesco Romani has posted comments on this change.
Change subject: engine, backend: enable vmconsole in host deploy
..
Patch Set 18:
Sorry for the noise, I was just me being silly. This patch actually depends on
https://gerr
Francesco Romani has posted comments on this change.
Change subject: engine, backend: enable vmconsole in host deploy
..
Patch Set 18:
Moti: unfortunately this failure:
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bu
Francesco Romani has posted comments on this change.
Change subject: engine, backend: enable vmconsole in host deploy
..
Patch Set 18: Verified+1
trivial update since v16, copied score
--
To view, visit https://gerrit.ovirt.o
Francesco Romani has posted comments on this change.
Change subject: engine, backend: enable vmconsole in host deploy
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/41388/16/backend/manager/modules/bll/src/main/java
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 52: Verified+1
verification: very minimal changes, copied score
--
To view, visit https://gerrit.o
Francesco Romani has posted comments on this change.
Change subject: core: SPICE copyPaste/fileTransfer not passed properly
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42038/1/backend/manager/modules/vdsbroker/src
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 51:
(1 comment)
https://gerrit.ovirt.org/#/c/35906/51/ovirt-engine.spec.in
File ovirt-engine.spec.i
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 51:
(2 comments)
https://gerrit.ovirt.org/#/c/35906/51/ovirt-engine.spec.in
File ovirt-engine.spec.
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 50:
Omer: I did basic verification to make sure that the changes didn't break
anything. (manual ins
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 50: Verified+1
--
To view, visit https://gerrit.ovirt.org/35906
To unsubscribe, visit https://gerri
Francesco Romani has posted comments on this change.
Change subject: core: device: add specParams for console devices
..
Patch Set 3: Verified+1
rebased, renamed script to avoid conflicts. No code changes.
--
To view, visit h
Francesco Romani has posted comments on this change.
Change subject: services, setup: vmconsole/openssh integration
..
Patch Set 16: Verified+1
rebased, addressed comments from Didi. Redid basic sanity check.
--
To view, visi
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 47: Verified+1
rebased, addressed comments from Didi. Redid basic sanity check.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: services, setup: vmconsole/openssh integration
..
Patch Set 15:
(4 comments)
https://gerrit.ovirt.org/#/c/41329/15/packaging/setup/plugins/ovirt-engine-setup
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 45:
(17 comments)
https://gerrit.ovirt.org/#/c/35906/45/ovirt-engine.spec.in
File ovirt-engine.spec
Francesco Romani has abandoned this change.
Change subject: backend: enable virtio serial console
..
Abandoned
we choose 42216
--
To view, visit https://gerrit.ovirt.org/42151
To unsubscribe, visit https://gerrit.ovirt.org/se
Francesco Romani has posted comments on this change.
Change subject: backend: enable virtio serial console
..
Patch Set 6: Code-Review-1
42216 is a better approach.
--
To view, visit https://gerrit.ovirt.org/42151
To unsubscr
Francesco Romani has posted comments on this change.
Change subject: core: device: add specParams for console devices
..
Patch Set 2: Verified+1
verified the upgrade script running it manually against VMs with console device
c
Francesco Romani has posted comments on this change.
Change subject: backend: enable virtio serial console
..
Patch Set 5:
We need either this or 42216. I prefer 42216.
--
To view, visit https://gerrit.ovirt.org/42151
To unsu
Francesco Romani has posted comments on this change.
Change subject: core: device: add specParams for console devices
..
Patch Set 1:
We need either this or 42151. I prefer this one.
--
To view, visit https://gerrit.ovirt.org
Francesco Romani has posted comments on this change.
Change subject: core: device: add specParams for console devices
..
Patch Set 1: Verified+1
tested on Engine creating a couple of new VMs, and editing existing one. Then
ins
Francesco Romani has uploaded a new change for review.
Change subject: core: device: add specParams for console devices
..
core: device: add specParams for console devices
Add the 'enableSocket=True' specParam to instruct
instru
Francesco Romani has posted comments on this change.
Change subject: backend: enable virtio serial console
..
Patch Set 4:
works fine with VDSM 4.16.20 - of course VDSM creates legacy console.
Now working on a cleaner approach
Francesco Romani has posted comments on this change.
Change subject: backend: enable virtio serial console
..
Patch Set 4:
will add backward compatibility check to make sure older VDSM are OK with this
(should be just fine), a
Francesco Romani has posted comments on this change.
Change subject: backend: enable virtio serial console
..
Patch Set 4: Verified+1
version 3 and 4 are MUCH simplified version of the original patch, since we
don't need nor w
Francesco Romani has uploaded a new change for review.
Change subject: backend: enable virtio serial console
..
backend: enable virtio serial console
Enhance the Console Device configuration by providing the flag
that instruct V
Francesco Romani has posted comments on this change.
Change subject: backend: enable vrtio serial console
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/42151/3//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2015-0
Francesco Romani has abandoned this change.
Change subject: frontend: activate virtio serial console per-vm
..
Abandoned
turns out we DO NOT want to split the concept like I did right here, so we
don't need this patch
--
To
Francesco Romani has uploaded a new change for review.
Change subject: frontend: activate virtio serial console per-vm
..
frontend: activate virtio serial console per-vm
In order to actually bind the vm serial console to an
Unix
Francesco Romani has posted comments on this change.
Change subject: ovirt-vmconsole: initial implementation
..
Patch Set 6: Verified+1
works for me. Rebuild from gerrit, applied this patch, succesfully deployed
keys on host a
Francesco Romani has posted comments on this change.
Change subject: pki: cleanup: reset some vars at init
..
Patch Set 8: Verified+1
works for me. Succesfully setup keys and ssh-connected to VM serial console.
--
To view, vi
Francesco Romani has posted comments on this change.
Change subject: pki: add pki-enroll-openssh-cert functionality
..
Patch Set 9: Verified+1
works for me. Succesfully setup keys and ssh-connected to VM serial console.
--
To
Francesco Romani has posted comments on this change.
Change subject: host-deploy: support serial console
..
Patch Set 10: Verified+1
works for me. Succesfully setup keys and ssh-connected to VM serial console.
--
To view, vis
Francesco Romani has posted comments on this change.
Change subject: pki: ssh fingerprint using various algorithms
..
Patch Set 4: Verified+1
works for me. Succesfully setup keys and ssh-connected to VM serial console.
--
To
Francesco Romani has posted comments on this change.
Change subject: packaging: setup: extract ssh public key logic to script
..
Patch Set 8: Verified+1
works for me. Succesfully setup keys and ssh-connected to VM serial consol
Francesco Romani has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 8: Code-Review+1
we discussed the vdscli usage, I'm fine with that. the
Francesco Romani has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 7:
(2 comments)
Sorry for late noticing. A possible bug and a question
Francesco Romani has abandoned this change.
Change subject: WIP: engine: port VMConsoleProxy to bulk queries
..
Abandoned
merged in parent patches.
--
To view, visit https://gerrit.ovirt.org/40700
To unsubscribe, visit https:
Francesco Romani has uploaded a new change for review.
Change subject: core: do not restrict user public keys to RSA
..
core: do not restrict user public keys to RSA
The users can upload ssh public keys, to be used to perform
au
Francesco Romani has posted comments on this change.
Change subject: core: fix EKU for VMConsole servlet
..
Patch Set 3:
unless I'm missing something, that was made already in patch 35887:
https://gerrit.ovirt.org/#/c/35887/38
Francesco Romani has posted comments on this change.
Change subject: services, setup: vmconsole/openssh integration
..
Patch Set 13:
please note this patch depends on Alon's patchset:
https://gerrit.ovirt.org/#/c/38092 - https
Francesco Romani has posted comments on this change.
Change subject: services, setup: vmconsole/openssh integration
..
Patch Set 13: Verified+1
Alon: sure, the oid was reserved in https://gerrit.ovirt.org/#/c/35887/
--
To vie
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 44: Verified+1
only copied code, basic sanity check using make all-dev pass, copying score.
--
To
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 43:
(1 comment)
https://gerrit.ovirt.org/#/c/35906/43/packaging/setup/ovirt_engine_setup/util.py
Fi
Francesco Romani has posted comments on this change.
Change subject: services, setup: vmconsole/openssh integration
..
Patch Set 12: Verified+1
re-verified in developer mode.
Reached the milestone on hypervisor-host:
ovirt-v+
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 43: Verified+1
re-verified. Works in developer mode.
--
To view, visit https://gerrit.ovirt.org/35
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 42: Verified+1
re-verified in developer mode, both using the helper directly and actually
connectin
Francesco Romani has posted comments on this change.
Change subject: core: fix EKU for VMConsole servlet
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41978
To unsubscribe, visit https://gerrit.ovirt.or
Francesco Romani has uploaded a new change for review.
Change subject: core: fix EKU for VMConsole servlet
..
core: fix EKU for VMConsole servlet
replace the EKU value with the correct one.
Change-Id: I68b5fd4bd2d8fe44d1135569e
Francesco Romani has posted comments on this change.
Change subject: services, setup: vmconsole/openssh integration
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/41329/7/packaging/setup/plugins/ovirt-engine-setup/v
Francesco Romani has posted comments on this change.
Change subject: services, setup: vmconsole/openssh integration
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/41329/7/packaging/setup/plugins/ovirt-engine-setup/v
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 38:
(1 comment)
https://gerrit.ovirt.org/#/c/35906/38/packaging/services/ovirt-vmconsole-proxy/ovir
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 38:
(1 comment)
https://gerrit.ovirt.org/#/c/35906/38/packaging/services/ovirt-vmconsole-proxy/ovir
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 38:
(2 comments)
https://gerrit.ovirt.org/#/c/35906/38/Makefile
File Makefile:
Line 370:
Francesco Romani has posted comments on this change.
Change subject: services, setup: vmconsole/openssh integration
..
Patch Set 7:
(5 comments)
https://gerrit.ovirt.org/#/c/41329/7/packaging/setup/plugins/ovirt-engine-setup/v
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 38:
(1 comment)
https://gerrit.ovirt.org/#/c/35906/38/packaging/services/ovirt-vmconsole-proxy/ovir
Francesco Romani has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 5:
(2 comments)
more possible minor improvements
https://gerrit.ovirt
Francesco Romani has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41570
To u
Francesco Romani has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 5:
(1 comment)
looks ok. If need arises, we can consolidate code in la
Francesco Romani has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/41570/4/mom/HypervisorInte
Francesco Romani has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/41570/4/mom/HypervisorInte
Francesco Romani has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 3:
(1 comment)
possible minor glitch inside
https://gerrit.ovirt.org/
Francesco Romani has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/41570/2/mom/HypervisorInte
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 38:
(1 comment)
https://gerrit.ovirt.org/#/c/35906/38/packaging/services/ovirt-vmconsole-proxy/ovir
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 38:
(13 comments)
https://gerrit.ovirt.org/#/c/35906/38/packaging/services/ovirt-vmconsole-proxy/ov
Francesco Romani has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 2: Code-Review-1
-1 only for visibility
--
To view, visit https://ger
Francesco Romani has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 2:
(1 comment)
Looks ok. I have concerns about reconnection handling.
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 38: Verified+1
verified with 35887. With SElinux disabled, the servlet works as expected.
Proper se
Francesco Romani has posted comments on this change.
Change subject: services, setup: vmconsole/openssh integration
..
Patch Set 7: Verified+1
ssh connects to the hypervisor host, so this patch works.
--
To view, visit https:
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 37: Verified+1
verified with 35887 manually invoking the helper via command line.
Checked the output
Francesco Romani has posted comments on this change.
Change subject: core, engine: servlet to support the console proxy
..
Patch Set 35: Verified+1
verified with 35906, both new APIs.
--
To view, visit https://gerrit.ovirt.or
Francesco Romani has posted comments on this change.
Change subject: engine, backend: enable vmconsole in host deploy
..
Patch Set 3: Verified+1
verified that the flag is passed to ovirt-host-deploy.
--
To view, visit https:/
Francesco Romani has posted comments on this change.
Change subject: core, engine: servlet to support the console proxy
..
Patch Set 35:
version 35 addresses the pending comments from Roy
--
To view, visit https://gerrit.ovir
Francesco Romani has posted comments on this change.
Change subject: engine, backend: enable vmconsole in host deploy
..
Patch Set 2: -Code-Review
--
To view, visit https://gerrit.ovirt.org/41388
To unsubscribe, visit https://
Francesco Romani has posted comments on this change.
Change subject: host-deploy: support serial console
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/38095/9/backend/manager/modules/bll/src/main/java/org/ovirt/engi
Francesco Romani has posted comments on this change.
Change subject: config: set monitoring interval to match VDSM one
..
Patch Set 4: Verified+1
verified reading the MOM logs that collections now run every 15s
--
To view, vi
Francesco Romani has posted comments on this change.
Change subject: mom: port ExpiringCache from VDSM
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/40779
To unsubscribe, visit https://gerrit.ovirt.org/
Francesco Romani has posted comments on this change.
Change subject: vdsm interface: refactor stats translations
..
Patch Set 6:
fixed a bug when Guest Agent is not present (or responding)
--
To view, visit https://gerrit.ovi
Francesco Romani has posted comments on this change.
Change subject: guest manager: single-thread monitoring
..
Patch Set 11:
fixed a bug which prevented collection.
I used monitor.isReady(), but the right call is monitor.shoul
Francesco Romani has posted comments on this change.
Change subject: guest monitor: split monitor from thread
..
Patch Set 15:
now includes former 39188
--
To view, visit https://gerrit.ovirt.org/31591
To unsubscribe, visit h
Francesco Romani has abandoned this change.
Change subject: WIP: more logging
..
Abandoned
info->debug and merged in 31591
--
To view, visit https://gerrit.ovirt.org/39188
To unsubscribe, visit https://gerrit.ovirt.org/settin
Francesco Romani has posted comments on this change.
Change subject: core, engine: servlet to support the console proxy
..
Patch Set 34:
version 34 implements the suggestion from Roy about the try-with-resource
construct.
I de
Francesco Romani has posted comments on this change.
Change subject: core, engine: servlet to support the console proxy
..
Patch Set 33:
(1 comment)
https://gerrit.ovirt.org/#/c/35887/33/backend/manager/modules/services/src/ma
Francesco Romani has posted comments on this change.
Change subject: core, engine: servlet to support the console proxy
..
Patch Set 33:
(2 comments)
thanks for the review Roy!
https://gerrit.ovirt.org/#/c/35887/33/backend/ma
Francesco Romani has posted comments on this change.
Change subject: services, setup: ovirt-vmconsole integration
..
Patch Set 34:
works in the basic flow.
Pending issues:
- selinux config when invoked from the actual proxy
- c
Francesco Romani has posted comments on this change.
Change subject: core, engine: servlet to support the console proxy
..
Patch Set 33:
(1 comment)
https://gerrit.ovirt.org/#/c/35887/33/backend/manager/modules/services/src/ma
Francesco Romani has posted comments on this change.
Change subject: core, engine: servlet to support the console proxy
..
Patch Set 33: Code-Review-1 Verified+1
both exposed entry points work, but needs to implement the proper
Francesco Romani has posted comments on this change.
Change subject: engine, backend: enable vmconsole in host deploy
..
Patch Set 1: Code-Review-1
should default to the value engine-setup has configured.
--
To view, visit ht
Francesco Romani has posted comments on this change.
Change subject: frontend: allow to enable/disable serial console
..
Patch Set 1: Code-Review-1 Verified+1
--
To view, visit https://gerrit.ovirt.org/41389
To unsubscribe, vi
Francesco Romani has posted comments on this change.
Change subject: frontend: allow to enable/disable serial console
..
Patch Set 1: Verified-1
incomplete
--
To view, visit https://gerrit.ovirt.org/41389
To unsubscribe, visi
Francesco Romani has uploaded a new change for review.
Change subject: engine, backend: enable vmconsole in host deploy
..
engine, backend: enable vmconsole in host deploy
Add glue code to enable the Serial Console in host deplo
Francesco Romani has uploaded a new change for review.
Change subject: frontend: allow to enable/disable serial console
..
frontend: allow to enable/disable serial console
Add checkbox to enable serial console when (re)install a
Francesco Romani has uploaded a new change for review.
Change subject: monitor: simplify should_run implementation
..
monitor: simplify should_run implementation
Make the method a couple of lines shorter.
Change-Id: Id41a43f430
Francesco Romani has posted comments on this change.
Change subject: guest monitor: split monitor from thread
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/31591/13/mom/Monitor.py
File mom/Monitor.py:
Line 187
Lin
Francesco Romani has abandoned this change.
Change subject: collect: add support for bulk stats
..
Abandoned
too invasive
--
To view, visit https://gerrit.ovirt.org/37827
To unsubscribe, visit https://gerrit.ovirt.org/setting
Francesco Romani has abandoned this change.
Change subject: monitor: collectors: add support for bulk stats
..
Abandoned
too invasive
--
To view, visit https://gerrit.ovirt.org/39754
To unsubscribe, visit https://gerrit.ovirt
Francesco Romani has posted comments on this change.
Change subject: core, engine: servlet to support the console proxy
..
Patch Set 30:
the servlet doesn't do yet key filtering based on the new vmconsole interface.
--
To vie
Francesco Romani has uploaded a new change for review.
Change subject: services, setup: vmconsole/openssh integration
..
services, setup: vmconsole/openssh integration
integration between ovirt-engine and ovirt-vmconsole-proxy,
1 - 100 of 476 matches
Mail list logo
