Francesco Romani has posted comments on this change. Change subject: New hypervisor interface for remote VDSM over XML-RPC with stats caching ......................................................................
Patch Set 5: (1 comment) looks ok. If need arises, we can consolidate code in later optimization patches. https://gerrit.ovirt.org/#/c/41570/5/mom/HypervisorInterfaces/vdsmxmlrpcInterface.py File mom/HypervisorInterfaces/vdsmxmlrpcInterface.py: Line 72: ret = self.vdsm_api.getAllVmStats() Line 73: self._check_status(ret) Line 74: except vdsmException, e: Line 75: e.handle_exception() Line 76: return vms maybe (feel free to ignore): vms = {} try: ret = self.vdsm_api.getAllVmStats() self._check_status(ret) except vdsmException, e: e.handle_exception() else: for vm in ret['statsList']: vms[vm['vmId']] = vm return vms Line 77: Line 78: for vm in ret['statsList']: Line 79: vms[vm['vmId']] = vm Line 80: return vms -- To view, visit https://gerrit.ovirt.org/41570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I314f39f9020ee257827145a57f585e7921a913e3 Gerrit-PatchSet: 5 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
