Francesco Romani has posted comments on this change. Change subject: engine, backend: enable vmconsole in host deploy ......................................................................
Patch Set 16: (1 comment) https://gerrit.ovirt.org/#/c/41388/16/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java: Line 133: Line 134: switch (getVds().getVdsType()) { Line 135: case VDS: Line 136: installer.setFirewall(parameters.getOverrideFirewall()); Line 137: installer.setVMConsole(parameters.getEnableSerialConsole()); > if this statement is common for both cases, why not have it outside of the Good point. Will fix. Line 138: break; Line 139: case oVirtNode: Line 140: if (parameters.getOverrideFirewall()) { Line 141: log.warn( -- To view, visit https://gerrit.ovirt.org/41388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb0503507d3a03789f1f14d3e95c17d121a60c59 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
