Francesco Romani has posted comments on this change. Change subject: services, setup: ovirt-vmconsole integration ......................................................................
Patch Set 38: (2 comments) https://gerrit.ovirt.org/#/c/35906/38/Makefile File Makefile: Line 370: build/python-check.sh && \ Line 371: build/dbscripts-duplicate_upgrade_scripts.sh; \ Line 372: fi Line 373: Line 374: > No need for this line Done Line 375: install_artifacts: Line 376: # we must exclude tmp.repos directory so we Line 377: # won't get artifacts of older branches Line 378: # we should use search MAVEN_OUTPUT_DIR as it may contain https://gerrit.ovirt.org/#/c/35906/38/packaging/setup/ovirt_engine_setup/vmconsole_proxy/config.py.in File packaging/setup/ovirt_engine_setup/vmconsole_proxy/config.py.in: Line 21: ENGINE_VMCONSOLE_PROXY_DIR = '@ENGINE_VMPROXY_DIR@' Line 22: ENGINE_VMCONSOLE_PROXY_CONFIG = '@ENGINE_VMPROXY_VARS@' Line 23: ENGINE_PKIDIR = '@ENGINE_PKI@' Line 24: VMCONSOLE_PROXY_HELPER_PATH='@VMCONSOLE_PROXY_HELPER_PATH@' Line 25: > 2 line here Done -- To view, visit https://gerrit.ovirt.org/35906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034ef8e6d10da5dc93eda61e0c5c518ca13a5a28 Gerrit-PatchSet: 38 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
