Francesco Romani has posted comments on this change. Change subject: services, setup: vmconsole/openssh integration ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/41329/7/packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy/pki.py File packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy/pki.py: Line 300: '-nodes', Line 301: '-nocerts', Line 302: ), Line 303: logStreams=False, Line 304: ) > Sorry, do you mean the parent patch? in ca.py we have indeed _expandPKCS12 which is pretty similar, but there are some not-trivial differences. Better to refactor code in ca.py and to reuse it or are the differences enough to justify two similar pieces of code? I'm for the latter, not out of laziness but because I find hard to refactor ca.py in a meaningful way, useful for both cases. Line 305: Line 306: key_file = os.path.join( Line 307: oenginecons.FileLocations.OVIRT_ENGINE_PKIDIR, Line 308: 'proxy-ssh_%s_rsa' % name, Line 349: '\x00\x00\x00\x07ssh-rsa{exponent}{modulus}'.format( Line 350: exponent=data[0], Line 351: modulus=data[1], Line 352: ) Line 353: ) > Is somehow missed the usage of pki-ssh-keygen.py. Will fix. Done Line 354: Line 355: Line 356: def _fixOwnerPermissions(dialog, pki_artifacts): Line 357: if os.geteuid() == 0: -- To view, visit https://gerrit.ovirt.org/41329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I740e37d5c34633bbe51922fb047d6b1a0a2431b6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
