Francesco Romani has posted comments on this change. Change subject: services, setup: vmconsole/openssh integration ......................................................................
Patch Set 15: (4 comments) https://gerrit.ovirt.org/#/c/41329/15/packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy/pki.py File packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy/pki.py: Line 355: ) Line 356: Line 357: self._copyVMConsoleProxyPKIArtifacts(pki_artifacts) Line 358: Line 359: def _enrollSSHKeys(self, host_mode, uninstall_files, pki_artifacts): > Please move helper functions to before events (and before they are used if Done Line 360: suffix = 'host' if host_mode else 'user' Line 361: name = '%s-%s' % ( Line 362: ovmpcons.Const.VMCONSOLE_PROXY_PKI_NAME, Line 363: suffix Line 429: name, Line 430: ), Line 431: ) Line 432: Line 433: rc, key, stderr = self.execute( > Wouldn't OVIRT_ENGINE_PKI_PKCS12_EXTRACT do this? Yes, with minimal changes to my code. Fixed. Line 434: args=( Line 435: self.command.get('openssl'), Line 436: 'pkcs12', Line 437: '-in', pkcs12, Line 498: '-f', Line 499: '/proc/self/fd/0', Line 500: ), Line 501: 'env': { Line 502: 'EPYTHON': 'python2', > what's this? If it's supposed to affect the python script that pki-enroll-o mistake of mine. Will remove. Line 503: }, Line 504: }, Line 505: ] Line 506: Line 520: def _copyVMConsoleProxyPKIArtifacts(self, pki_artifacts): Line 521: if not self.environment[osetupcons.CoreEnv.DEVELOPER_MODE]: Line 522: for artifact in pki_artifacts: Line 523: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 524: CopyFileInDirTransaction( > Please try, here and elsewhere, to name the arguments - Done Line 525: artifact.path, Line 526: ovmpcons.FileLocations.OVIRT_VMCONSOLE_PROXY_PKIDIR, Line 527: mode=artifact.mode, Line 528: owner=artifact.owner, -- To view, visit https://gerrit.ovirt.org/41329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I740e37d5c34633bbe51922fb047d6b1a0a2431b6 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
