automat...@ovirt.org has posted comments on this change.
Change subject: core: Add executePipe
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit http://gerrit.ovirt.org/26213
To unsubscribe, visit h
Yedidyah Bar David has posted comments on this change.
Change subject: core: Add executePipe
..
Patch Set 3:
(4 comments)
http://gerrit.ovirt.org/#/c/26213/3/src/otopi/plugin.py
File src/otopi/plugin.py:
Line 410:
Alona Kaplan has posted comments on this change.
Change subject: webadmin: removed caching from EnumTranslator.
..
Patch Set 2:
(20 comments)
Well done! :)
Just few small comments.
Please note the comment in EnumTranslator, it
Liron Ar has posted comments on this change.
Change subject: core: Remove a proxy use of ImagesHandler filter
..
Patch Set 2: Code-Review-2
(1 comment)
marking -2 till the comment is fixed as this patch already has +2.
http:/
Tomas Jelinek has posted comments on this change.
Change subject: core: adjustments needed to support instance types
..
Patch Set 20: Verified+1
--
To view, visit http://gerrit.ovirt.org/23828
To unsubscribe, visit http://gerr
automat...@ovirt.org has posted comments on this change.
Change subject: core: Fix DbUserCacheManager when to refresh users
..
Patch Set 1: -Verified
* #1081204::Update tracker: OK
* #1081204::Bug-Url: Correct product oVirt
* #
Oved Ourfali has posted comments on this change.
Change subject: core: Fix DbUserCacheManager when to refresh users
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26187
To unsubscribe, visit http://ger
Oved Ourfali has posted comments on this change.
Change subject: core: Fix DbUserCacheManager when to refresh users
..
Patch Set 1:
Rerun-Hooks: all
--
To view, visit http://gerrit.ovirt.org/26187
To unsubscribe, visit http:/
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Introducing format to id of User and Group API entities
..
Patch Set 5:
And about the 2nd part of your comment -
"If we changed our minds again and we dec
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Introducing format to id of User and Group API entities
..
Patch Set 5:
Hi Juan, aobut your comment -
"I have to insist that it isn't acceptable to have t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/1596/ : SU
Einav Cohen has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/26277
To unsubscribe, visit http://gerrit.ovirt.org
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1:
* #1082800::Update tracker: ERROR, wrong product Red Hat Enterprise
Virtualization Manager
* #1
Einav Cohen has uploaded a new change for review.
Change subject: webadmin, userportal: translations update
..
webadmin, userportal: translations update
pulled translation from Zanata oVirt project, ovirt-3.4 version.
Change-Id
Federico Simoncelli has posted comments on this change.
Change subject: engine: Change OpenStack SDK version
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25356
To unsubscribe, visit http://gerrit.ovi
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED: IGNORE, no Bug-Url found.
--
To vie
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin, userportal: translations update
..
webadmin, userportal: translations update
pulled translation from Zanata oVirt project, master version.
Chan
Daniel Erez has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26276
To unsubscribe, visit http://gerrit.ovirt.
Einav Cohen has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1:
> Patch Set 1: Code-Review+1
Alex, any reason for not giving +2?
[this is just a pull from the translati
Alexander Wels has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26276
To unsubscribe, visit http://gerrit.ovi
Einav Cohen has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/26276
To unsubscribe, visit http://gerrit.ovirt.org
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-e
Einav Cohen has uploaded a new change for review.
Change subject: webadmin, userportal: translations update
..
webadmin, userportal: translations update
pulled translation from Zanata oVirt project, master version.
Change-Id: I
Alexander Wels has posted comments on this change.
Change subject: webadmin: System tree refresh
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/26161
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine : Tunnel calls to AsyncTaskManager and introduce CoCo
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine : Introduction of CallBack interface
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/4719/
Oved Ourfali has posted comments on this change.
Change subject: core: Fix NPE when scanning for non-existent domain.
..
Patch Set 2:
Maor - let me know when to merge that (I guess you'll address Allon's comment).
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine : Move all tasks classes to bll.tasks package
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_ger
Oved Ourfali has posted comments on this change.
Change subject: tools : engine-config is over writing the previous values
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25762
To unsubscribe, visit htt
Ravi Nori has uploaded a new change for review.
Change subject: engine : Move all tasks classes to bll.tasks package
..
engine : Move all tasks classes to bll.tasks package
Moves all tasks related classes into the bll.tasks
pack
automat...@ovirt.org has posted comments on this change.
Change subject: core: fix sysprep architecture values
..
Patch Set 2:
* #1066884::Update tracker: ERROR, wrong product Red Hat Enterprise
Virtualization Manager
* #10668
automat...@ovirt.org has posted comments on this change.
Change subject: engine : Move all tasks classes to bll.tasks package
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored bran
automat...@ovirt.org has posted comments on this change.
Change subject: engine : Introduction of CallBack interface
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt
Oved Ourfali has submitted this change and it was merged.
Change subject: core: fix sysprep architecture values
..
core: fix sysprep architecture values
arch values don't match the OS ini question - x86 instead of
amd64 for OSs
automat...@ovirt.org has posted comments on this change.
Change subject: engine : Tunnel calls to AsyncTaskManager and introduce CoCo
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monito
Ravi Nori has uploaded a new change for review.
Change subject: engine : Introduction of CallBack interface
..
engine : Introduction of CallBack interface
CallBack interface with endAction method has been
introduced. This reduce
Ravi Nori has uploaded a new change for review.
Change subject: engine : Tunnel calls to AsyncTaskManager and introduce CoCo
..
engine : Tunnel calls to AsyncTaskManager and introduce CoCo
All calls to AsyncTaskManager are made
Oved Ourfali has posted comments on this change.
Change subject: backend: check if vds is null on setUpStatus callback.
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26252
To unsubscribe, visit http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tools : engine-config is over writing the previous values
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_test
Ravi Nori has posted comments on this change.
Change subject: tools : engine-config is over writing the previous values
..
Patch Set 6: Verified+1
Removed CustomDeviceProperties
{type=disk; prop={value1=regex1; ...; valueN=reg
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tools : engine-config is over writing the previous values
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_test
automat...@ovirt.org has posted comments on this change.
Change subject: tools : engine-config is over writing the previous values
..
Patch Set 6:
* #1069768::Update tracker: ERROR, wrong product Red Hat Enterprise
Virtualizat
automat...@ovirt.org has posted comments on this change.
Change subject: tools : engine-config is over writing the previous values
..
Patch Set 5:
* #1069768::Update tracker: ERROR, wrong product Red Hat Enterprise
Virtualizat
oVirt Jenkins CI Server has posted comments on this change.
Change subject: backend: check if vds is null on setUpStatus callback.
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: backend: bugfix in VdsManager on failedToRunVm
..
Patch Set 3: -Code-Review -Verified
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_mast
automat...@ovirt.org has posted comments on this change.
Change subject: backend: check if vds is null on setUpStatus callback.
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored br
David Caro has posted comments on this change.
Change subject: Added scripts for 3.4 to latest upgrade job
..
Patch Set 16: Verified+1
This one works well, at least, as far as I've been able to test.
Notice that it will fail o
Juan Hernandez has posted comments on this change.
Change subject: aaa: Introducing format to id of User and Group API entities
..
Patch Set 5: Code-Review-1
I have to insist that it isn't acceptable to have two possible identi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: prevent maintenance when domain is still in use
..
Patch Set 17:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_mast
Omer Frenkel has posted comments on this change.
Change subject: core: move static helper methods out of VURTI
..
Patch Set 3:
there is a conflict, please rebase manually
--
To view, visit http://gerrit.ovirt.org/26012
To uns
Omer Frenkel has posted comments on this change.
Change subject: core: fix sysprep architecture values
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26214
To unsubscribe, visit http://gerrit.ovirt.org
Omer Frenkel has posted comments on this change.
Change subject: core: move static helper methods out of VURTI
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26012
To unsubscribe, visit http://gerrit.o
Juan Hernandez has posted comments on this change.
Change subject: sdk: Check SSL server certificate
..
Patch Set 1:
The capability to check host names was added in python 3.4.
--
To view, visit http://gerrit.ovirt.org/26271
Alon Bar-Lev has posted comments on this change.
Change subject: sdk: Check SSL server certificate
..
Patch Set 1:
> This works well in 2.6 and 2.7.
was this an answer to my question? if it does, I still do not understand, if
Tal Nisan has posted comments on this change.
Change subject: core: Remove a proxy use of ImagesHandler filter
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26205
To unsubscribe, visit http://gerrit.o
Tal Nisan has posted comments on this change.
Change subject: core: adding BusinessEntityHelper (with buildIdMap)
..
Patch Set 1: Code-Review+1
Good idea, there are many place which this patter is used over and over again
--
Juan Hernandez has posted comments on this change.
Change subject: sdk: Check SSL server certificate
..
Patch Set 1:
Michael, this is about validating that the host name in the URL matches the
host name in the CN or subjectAlt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: prevent maintenance when domain is still in use
..
Patch Set 17:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_mast
Juan Hernandez has posted comments on this change.
Change subject: sdk: Check SSL server certificate
..
Patch Set 1:
This works well in 2.6 and 2.7.
--
To view, visit http://gerrit.ovirt.org/26271
To unsubscribe, visit http:/
Michael Pasternak has posted comments on this change.
Change subject: sdk: Check SSL server certificate
..
Patch Set 1:
Juan,
HTTPSConnection was especially implemented for this matter,
it automatically validates the host when
Allon Mureinik has posted comments on this change.
Change subject: core: Fix NPE when scanning for non-existent domain.
..
Patch Set 2: Code-Review+1
(1 comment)
+1 on the code, minor suggestion about the error message.
http:
Alon Bar-Lev has posted comments on this change.
Change subject: sdk: Check SSL server certificate
..
Patch Set 1:
Hi,
Is it solves in python-2.7? if so, can we use the python check in 2.7 while
applying this only for 2.6?
-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core, webadmin: remove name from template version
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_master_ge
automat...@ovirt.org has posted comments on this change.
Change subject: core: prevent maintenance when domain is still in use
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED: IGNORE, no Bug-Url found
Allon Mureinik has submitted this change and it was merged.
Change subject: core: prevent maintenance when domain is still in use
..
core: prevent maintenance when domain is still in use
A domain is effectively in maintenance o
automat...@ovirt.org has posted comments on this change.
Change subject: core: prevent maintenance when domain is still in use
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored br
Allon Mureinik has posted comments on this change.
Change subject: core: prevent maintenance when domain is still in use
..
Patch Set 16: Verified+1 Code-Review+2
The checkstyle failure is an env. problem, not a real issue:
16
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: add helper method for template version
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/4711
Juan Hernandez has posted comments on this change.
Change subject: sdk: Check SSL server certificate
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/26271
To unsubscribe, visit http://gerrit.ovirt.org/sett
Juan Hernandez has uploaded a new change for review.
Change subject: sdk: Check SSL server certificate
..
sdk: Check SSL server certificate
Currently we don't check that the host name provided in the URL matches
the host name co
automat...@ovirt.org has posted comments on this change.
Change subject: sdk: Check SSL server certificate
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit http://gerrit.ovirt.org/26271
To unsubscr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: frontend: Proper VM SystemTab Validation
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/4710/ :
automat...@ovirt.org has posted comments on this change.
Change subject: core, webadmin: remove name from template version
..
Patch Set 1:
* #1075074::Update tracker: ERROR, wrong product Red Hat Enterprise
Virtualization Mana
Omer Frenkel has uploaded a new change for review.
Change subject: core: add helper method for template version
..
core: add helper method for template version
some places in addVmTemplate command are checking for
baseTemplateId
automat...@ovirt.org has posted comments on this change.
Change subject: core: add helper method for template version
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovir
Omer Frenkel has uploaded a new change for review.
Change subject: core, webadmin: remove name from template version
..
core, webadmin: remove name from template version
>From now, the template.name for template versions will be
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: make ClearNonResponsiveVdsVms non-transactive
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rerun HA VMs on manual fence using AutoStartVmsRunner
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests
automat...@ovirt.org has posted comments on this change.
Change subject: frontend: Proper VM SystemTab Validation
..
Patch Set 1:
* #1069628::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* C
Martin Betak has uploaded a new change for review.
Change subject: frontend: Proper VM SystemTab Validation
..
frontend: Proper VM SystemTab Validation
UnitVmModel#validate() used async query to get max valid mem size and
thus c
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: prevent maintenance when domain is still in use
..
Patch Set 16: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt_eng
Project:
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_master_gerrit/
Build:
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_master_gerrit/1506/
Build Number: 1506
Build Status: Fixed
Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/22045
-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin : Existing gluster cluster import iptables config
..
Patch Set 1: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: userportal, webadmin: new look and feel based on PatternFly
..
Patch Set 26:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_t
Allon Mureinik has posted comments on this change.
Change subject: core: prevent maintenance when domain is still in use
..
Patch Set 16:
rebased, handled conflicts
--
To view, visit http://gerrit.ovirt.org/22045
To unsubscri
automat...@ovirt.org has posted comments on this change.
Change subject: core: prevent maintenance when domain is still in use
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored br
automat...@ovirt.org has posted comments on this change.
Change subject: Fix typo and use default cert
..
Patch Set 1:
* #1078353::Update tracker: ERROR, wrong product Red Hat Enterprise
Virtualization Manager
--
To view, vi
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin : Existing gluster cluster import iptables config
..
Patch Set 1:
* #1051019::Update tracker: ERROR, wrong product Red Hat Enterprise
Virtualiza
David Caro has abandoned this change.
Change subject: Fix typo and use default cert
..
Abandoned
Branch to be deleted
--
To view, visit http://gerrit.ovirt.org/25951
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
anmolbabu has uploaded a new change for review.
Change subject: webadmin : Existing gluster cluster import iptables config
..
webadmin : Existing gluster cluster import iptables config
This patch enables iptables rules configura
automat...@ovirt.org has posted comments on this change.
Change subject: userportal, webadmin: new look and feel based on PatternFly
..
Patch Set 26:
* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monito
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Aggregate error messages in
Frontend.runMultipleActions()
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25837/2/frontend/webadmin/modules/fr
automat...@ovirt.org has posted comments on this change.
Change subject: core: make ClearNonResponsiveVdsVms non-transactive
..
Patch Set 1:
* #1080961::Update tracker: OK
* #1080961::Bug-Url: Correct product oVirt
* #1080961::
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Aggregate errors when importing networks
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25838/2/frontend/webadmin/modules/frontend/src/main/ja
automat...@ovirt.org has posted comments on this change.
Change subject: core: rerun HA VMs on manual fence using AutoStartVmsRunner
..
Patch Set 2:
* #1080961::Update tracker: OK
* #1080961::Bug-Url: Correct product oVirt
* #1
Arik Hadas has uploaded a new change for review.
Change subject: core: make ClearNonResponsiveVdsVms non-transactive
..
core: make ClearNonResponsiveVdsVms non-transactive
ClearNonResponsiveVdsVmsCommand basically do the followi
Ravi Nori has posted comments on this change.
Change subject: tools : engine-config is over writing the previous values
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25762/4/packaging/etc/engine-config/engine-config.
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Aggregate error messages in
Frontend.runMultipleActions()
..
Patch Set 2:
(4 comments)
http://gerrit.ovirt.org/#/c/25837/2/frontend/webadmin/modules/f
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Warning about display network change.
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/4
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: handle 'source' domains when adding a vm from template
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt
1 - 100 of 553 matches
Mail list logo
