Michael Pasternak has posted comments on this change. Change subject: sdk: Check SSL server certificate ......................................................................
Patch Set 1: Juan, HTTPSConnection was especially implemented for this matter, it automatically validates the host when ca_file is provided, take a look at HTTPSConnection:52 it forces cert_reqs=ssl.CERT_REQUIRED, did you saw that httplib.HTTPSConnection fails to validate the host with ssl.CERT_REQUIRED? -- To view, visit http://gerrit.ovirt.org/26271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a08179288fd564fbb79f5731c3e32251e560d81 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
