Ravi Nori has posted comments on this change.

Change subject: tools : engine-config is over writing the previous values
......................................................................


Patch Set 6: Verified+1

Removed CustomDeviceProperties

{type=disk; prop={value1=regex1; ...; valueN=regexN}};{type=interface; 
prop={value1=regex1; ...; valueN=regexN}}

the delimiter ; can occur inside the string making it hard to write a generic 
method to split and merge

-- 
To view, visit http://gerrit.ovirt.org/25762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c70539f47c509e3b8c23b1aa3de41bead36c1b4
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to