Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Introducing format to id of User and Group API entities
......................................................................
Patch Set 5:
And about the 2nd part of your comment -
"If we changed our minds again and we decided that /users and
/domain/{domain:id}/users are different entities, and we really need to have
two identifiers then we should revert to the situation where we used only the
internal identifier to build the URI for /users, only the external identifier
to build the URI for /domain/{domain:id}/users, and the <external_id> element
for the external identifier inside /users."
in 3.3 the id for user under /users and user /domains/xxx/users was the same.
In 3.4, the id changed - external_id was introduced in API.
So a developer that uses the API can not longer take the "id" of a "domain
user" and add a user under /users with that id - he has to change from id to
external_id, as the id for the user is now internally generated.
I'm not sure exactly how did it keep the backward compatibility in 3.4
--
To view, visit http://gerrit.ovirt.org/26191
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaecb5d43945769db82475edde1c7075c1a343c07
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
