Liron Ar has posted comments on this change. Change subject: core: Remove a proxy use of ImagesHandler filter ......................................................................
Patch Set 2: Code-Review-2 (1 comment) marking -2 till the comment is fixed as this patch already has +2. http://gerrit.ovirt.org/#/c/26205/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 337: return db.getVmInitByIds(ids); Line 338: } Line 339: Line 340: /** Line 341: * Filters out all the disks which are not active. you removed from the comment the parts related to the devices/luns. Line 342: */ Line 343: public static void filterImageDisksForVM(VM vm) { Line 344: List<DiskImage> filteredDisks = ImagesHandler.filterImageDisks(vm.getDiskMap().values(), false, false, true); Line 345: Collection<? extends Disk> vmDisksToRemove = CollectionUtils.subtract(vm.getDiskMap().values(), filteredDisks); -- To view, visit http://gerrit.ovirt.org/26205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87f74d76771b3fe3fb31a4d9c731ec0139515694 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
