Juan Hernandez has posted comments on this change.
Change subject: aaa: Introducing format to id of User and Group API entities
......................................................................
Patch Set 5: Code-Review-1
I have to insist that it isn't acceptable to have two possible identifiers (and
thus two possible URIs) for the same resource, as we can do with just one.
Having more than one possible identifier just adds confusion. As we can easily
do everything just with the external identifier we should use it everywhere.
Thus the "id=" and "providerid=" prefixes aren't needed.
If we changed our minds again and we decided that /users and
/domain/{domain:id}/users are different entities, and we really need to have
two identifiers then we should revert to the situation where we used only the
internal identifier to build the URI for /users, only the external identifier
to build the URI for /domain/{domain:id}/users, and the <external_id> element
for the external identifier inside /users.
Please remember to change from URL encoding to hex encoding.
--
To view, visit http://gerrit.ovirt.org/26191
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaecb5d43945769db82475edde1c7075c1a343c07
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
