Alissa Bonas has posted comments on this change.
Change subject: webadmin: fix findbugs warning on ProviderModel
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22805
To unsubscribe, visit http://gerrit
Oved Ourfali has posted comments on this change.
Change subject: webadmin: fix findbugs warning on ProviderModel
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22805
To unsubscribe, visit http://gerrit.ov
Mike Kolesnik has posted comments on this change.
Change subject: core: Add QoS member to Network and VdsNetworkInterface
..
Patch Set 15:
(4 comments)
File
backend/manager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Introduce NetworkLabel entity
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/5314/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Update network on hosts when label is changed
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_mas
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Introduces GetNetworkLabelsByNetworkIdQuery
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_maste
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add Label and Unlabel network commands
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_ger
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Extract getNetwork() method
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/5307/
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: update remote DB interactive messages
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22555
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Expand GetNetworkByIdQuery to a user query
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to
Mike Kolesnik has posted comments on this change.
Change subject: core: Added feature support versions for Host QoS
..
Patch Set 2:
(1 comment)
File
backend/manager/modules
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: on upgrade first backup
..
Patch Set 1:
> Can you please base on http://gerrit.ovirt.org/22701 ?
It's already based on it - see the "dependencie
Sandro Bonazzola has posted comments on this change.
Change subject: packging: fixed remote install setup
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22701
To unsubscribe, visit http://gerrit.ovirt.
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: Fix /etc/sysconfig/nfs quotes
..
Patch Set 2:
Didi, can you rebase this manually?
--
To view, visit http://gerrit.ovirt.org/22622
To unsub
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: customize NFS export ACL
..
Patch Set 3:
Didi, can you rebase this manually?
--
To view, visit http://gerrit.ovirt.org/22570
To unsubscrib
Oved Ourfali has uploaded a new change for review.
Change subject: webadmin: fix findbugs warning on ProviderModel
..
webadmin: fix findbugs warning on ProviderModel
This patch fixes a findbugs warning in ProviderModel, as we ca
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Extract method to create the vlan name
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_ger
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Change DetachNetworkToVdsGroup to non-transactive
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Remove network from hosts when detached from cluster
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Remove unnecessary abstraction
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Use NetworkUtils.isVlan() where possible
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Configure network on hosts on cluster assignment
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add NetworkUtils.isVlan(VdsNetworkInterface)
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_mast
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Extract isVlan into NetworkUtils for reusability
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_
Project:
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_gerrit_master/
Build:
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_gerrit_master/873/
Build Number: 873
Build Status: Failure
Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/22800
-
Moti Asayag has uploaded a new change for review.
Change subject: core: Introduce NetworkLabel entity
..
core: Introduce NetworkLabel entity
The NetworkLabel entity is a plan container of the
label id. The class designed to be t
Moti Asayag has uploaded a new change for review.
Change subject: engine: Introduces GetNetworkLabelsByNetworkIdQuery
..
engine: Introduces GetNetworkLabelsByNetworkIdQuery
The query returns a list of labels of a specific networ
Moti Asayag has uploaded a new change for review.
Change subject: engine: Expand GetNetworkByIdQuery to a user query
..
engine: Expand GetNetworkByIdQuery to a user query
The query will be used for fetch a specific entity
by the
Moti Asayag has uploaded a new change for review.
Change subject: engine: Add Label and Unlabel network commands
..
engine: Add Label and Unlabel network commands
The commands are added for labeling and unlabeling
a network. The
Moti Asayag has uploaded a new change for review.
Change subject: restapi: Support network labels
..
restapi: Support network labels
Adding support for labels on network level.
Currently the engine supports a single label
per ne
Lior Vernia has posted comments on this change.
Change subject: engine: Extracted some QoS validation to NetworkQosValidator
..
Patch Set 13:
(1 comment)
File
backend/manag
Lior Vernia has posted comments on this change.
Change subject: webadmin: Refactored edit host network code
..
Patch Set 2:
Thanks, sure thing :)
--
To view, visit http://gerrit.ovirt.org/22788
To unsubscribe, visit http://ge
Lior Vernia has posted comments on this change.
Change subject: webadmin: Add QoS button in Add/Edit Network dialog
..
Patch Set 9:
That would be great, but in this dialog I can't know yet whether it would be
supported or not.
Lior Vernia has posted comments on this change.
Change subject: webadmin: Move Network QoS logic to common ground
..
Patch Set 16:
(2 comments)
File
frontend/webadmin/modul
Maor Lipchuk has posted comments on this change.
Change subject: engine: SearchQuery generates slow query on vds_with_tags and
storage_domains
..
Patch Set 12: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20914
To
Juan Hernandez has posted comments on this change.
Change subject: restapi: optional disks list in create snapshot
..
Patch Set 4: Code-Review+1
Please verify.
--
To view, visit http://gerrit.ovirt.org/22781
To unsubscribe, v
Juan Hernandez has posted comments on this change.
Change subject: restapi: optional disks list for snapshot restore
..
Patch Set 4: Code-Review+1
Please verify.
--
To view, visit http://gerrit.ovirt.org/22782
To unsubscribe,
Juan Hernandez has posted comments on this change.
Change subject: restapi: Add Reboot VM action
..
Patch Set 1:
Martin, please ping me when the backend change is merged so that we can merge
this.
--
To view, visit http://ge
Juan Hernandez has posted comments on this change.
Change subject: restapi: Add Reboot VM action
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22745
To unsubscribe, visit http://gerrit.ovirt.org/setti
Mike Kolesnik has posted comments on this change.
Change subject: webadmin: Ability to add external subnet
..
Patch Set 1:
(18 comments)
File
frontend/webadmin/modules/uico
Mike Kolesnik has posted comments on this change.
Change subject: webadmin: Added remove external subnet capability
..
Patch Set 1:
(8 comments)
File
frontend/webadmin/modu
Alissa Bonas has posted comments on this change.
Change subject: ui: rename EventsArgs.Empty to empty
..
Patch Set 1: Verified+1
compiled incl. GWT.
Saw findbugs marks it as resolved.
--
To view, visit http://gerrit.ovirt.org
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ui: rename EventsArgs.Empty to empty
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/5300/
Allon Mureinik has posted comments on this change.
Change subject: core, engine: Prevent snapshot in ppc64
..
Patch Set 2: Code-Review-1
(6 comments)
File
backend/manager/m
Alissa Bonas has uploaded a new change for review.
Change subject: ui: rename EventsArgs.Empty to empty
..
ui: rename EventsArgs.Empty to empty
Change-Id: Iff1f2de7e8aaaeb7869864d35da1b4892ad807f5
Signed-off-by: Alissa Bonas
--
Allon Mureinik has posted comments on this change.
Change subject: core: adding support for version 3.4
..
Patch Set 4: Code-Review-1
@Eli, why is removing DesktopAudioDeviceType part of this patch?
(Giving -1 in the meanwhile
Allon Mureinik has posted comments on this change.
Change subject: core: CDA messages - i18n/format
..
Patch Set 2: Code-Review+1
(2 comments)
Looks fine to me.
Tal?
Commit
Yaniv Dary has posted comments on this change.
Change subject: packaging: on upgrade first backup
..
Patch Set 1:
Can you please base on http://gerrit.ovirt.org/22701 ?
Yaniv
--
To view, visit http://gerrit.ovirt.org/22797
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ui: fix findbugs exclude filter.
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/5299/
: S
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ui: fix findbugs exclude filter.
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/5298/
: S
Oved Ourfali has submitted this change and it was merged.
Change subject: ui: fix findbugs exclude filter.
..
ui: fix findbugs exclude filter.
The numbering of anonymous classes changed
due to a refactoring, and hence the exclu
Oved Ourfali has posted comments on this change.
Change subject: ui: fix findbugs exclude filter.
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22791
To unsubscribe, visit http://gerrit.ovi
Oved Ourfali has posted comments on this change.
Change subject: ui: fix findbugs exclude filter.
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22791
To unsubscribe, visit http://gerrit.ovi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Hot set number of CPUs on update VM
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/5
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Refactored Network QoS frontend code
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22798
To unsubscribe, visit http://gerrit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Refactored edit host network code
..
Patch Set 2: Code-Review+2
nice!! please verify thoroughly
--
To view, visit http://gerrit.ovirt.org/22788
To un
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Add QoS button in Add/Edit Network dialog
..
Patch Set 9:
@Lior
don't you want to hide it when the feature disabled?
--
To view, visit http://gerrit
Project:
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_gerrit_master/
Build:
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_gerrit_master/872/
Build Number: 872
Build Status: Fixed
Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/22757
---
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Remove coupling between QoS dialog and DC/QoS subtab
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22681
To unsubscribe, vis
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Unify VLAN and MTU styles
..
Patch Set 16: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Added QoS to Network dialog
..
Patch Set 17: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Refactored Network QoS frontend code
..
Patch Set 1: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Move Network QoS logic to common ground
..
Patch Set 16: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Moved NetworkModel command initiation to constructor
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22682
To unsubscribe, vis
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Added QoS to Network dialog
..
Patch Set 17: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22607
To unsubscribe, visit http://gerrit.ovirt.o
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Unify VLAN and MTU styles
..
Patch Set 16: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22606
To unsubscribe, visit http://gerrit.ovirt.org
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Move Network QoS logic to common ground
..
Patch Set 16:
(2 comments)
File
frontend/webadmin/mod
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Refactored edit host network code
..
Patch Set 2: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_m
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Added QoS overridden member to VdsNetworkInterface
..
Patch Set 3: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_eng
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Add QoS button in Add/Edit Network dialog
..
Patch Set 9: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Moved NetworkModel command initiation to constructor
..
Patch Set 9: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt_engine
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Include network QoS in Setup Networks
..
Patch Set 15: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Moved more QoS validation to NetworkQosValidator
..
Patch Set 3: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt_engine_3.3_u
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Support interface QoS override in Setup Networks
..
Patch Set 3: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt_engine_3.3_u
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Remove coupling between QoS dialog and DC/QoS subtab
..
Patch Set 9: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt_engine
Lior Vernia has posted comments on this change.
Change subject: engine: Added toString() override to NetworkQoS
..
Patch Set 12:
No problem.
--
To view, visit http://gerrit.ovirt.org/22608
To unsubscribe, visit http://gerrit.
Lior Vernia has posted comments on this change.
Change subject: engine: NetworkQoS validation in Add/Update Network
..
Patch Set 13:
(2 comments)
File
backend/manager/modul
Lior Vernia has posted comments on this change.
Change subject: engine: Extracted some QoS validation to NetworkQosValidator
..
Patch Set 13:
(2 comments)
File
backend/mana
Gilad Chaplik has posted comments on this change.
Change subject: engine: NetworkQoS validation in Add/Update Network
..
Patch Set 13:
(2 comments)
File
backend/manager/mod
Lior Vernia has posted comments on this change.
Change subject: core: Add QoS member to Network and VdsNetworkInterface
..
Patch Set 15:
(2 comments)
File
backend/manager/m
Lior Vernia has posted comments on this change.
Change subject: core: Allow anonymous QoS in DB
..
Patch Set 10:
Nothing as of yet. I don't see the harm, but need to discuss.
--
To view, visit http://gerrit.ovirt.org/22601
To
Gilad Chaplik has posted comments on this change.
Change subject: engine: Added toString() override to NetworkQoS
..
Patch Set 12: Code-Review+1
Gave a comment about toStr some where - so strike it. it would be nice to move
th
Gilad Chaplik has posted comments on this change.
Change subject: engine: Extracted Network QoS VDSM mapping logic
..
Patch Set 13: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22603
To unsubscribe, visit http://ger
Lior Vernia has uploaded a new change for review.
Change subject: webadmin: Refactored Network QoS frontend code
..
webadmin: Refactored Network QoS frontend code
Extracted the part concerned with the actual QoS values into
Base
oVirt Jenkins CI Server has posted comments on this change.
Change subject: UI: Vm Init - new Feature
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/5284/
: SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: API: Vm Init - new Feature
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/5282/
:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Engine: Vm Init - new Feature
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/5281/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: scheduling: VM Affinity Group filter and weight module
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db
oVirt Jenkins CI Server has posted comments on this change.
Change subject: db: Fetch all running VM in cluster
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/5279/
Gilad Chaplik has posted comments on this change.
Change subject: engine: Extracted some QoS validation to NetworkQosValidator
..
Patch Set 13:
(2 comments)
File
backend/ma
oVirt Jenkins CI Server has posted comments on this change.
Change subject: DB: Vm Init - new Feature
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/5283/
: S
Project:
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_gerrit_master/
Build:
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_gerrit_master/870/
Build Number: 870
Build Status: Failure
Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/22795
-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove VM from its Affinity Group on change cluster
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_master/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_master/5524/
Build Number: 5524
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: on upgrade first backup
..
Patch Set 1: -Verified
Probably requires more testing
--
To view, visit http://gerrit.ovirt.org/22797
To unsubscribe
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: on upgrade first backup
..
Patch Set 1: Verified+1
Verified upgrade from 3.2 with local database
--
To view, visit http://gerrit.ovirt.org/2279
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: on upgrade first backup
..
packaging: on upgrade first backup
Bug-Url: https://bugzilla.redhat.com/1046679
Change-Id: I1b85a6aee99e94856b233f1c2
Daniel Erez has posted comments on this change.
Change subject: userportal, webadmin: Prevent snapshot in ppc64
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21658
To unsubscribe, visit http://gerrit.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: ManipulateAffinityGroup action group
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: db: Affinity Groups database support
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/5275/
1 - 100 of 214 matches
Mail list logo
