Lior Vernia has posted comments on this change.
Change subject: webadmin: Move Network QoS logic to common ground
......................................................................
Patch Set 16:
(2 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
Line 175: <include
name="common/businessentities/QuotaUsagePerUser.java"/>
Line 176:
Line 177: <!--QoS-->
Line 178: <include
name="common/businessentities/network/NetworkQoS.java"/>
Line 179: <include
name="common/businessentities/network/DcBoundNetworkQos.java"/>
Good spot, it's something I ended up not using. Will remove this line.
Line 180:
Line 181: <!-- Misc -->
Line 182: <include name="common/AuditLogType.java" />
Line 183: <include name="common/AuditLogTimeInterval.java" />
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
Line 461: }
Line 462: return null;
Line 463: }
Line 464:
Line 465: public static NetworkQoS findNetworkQosById(Iterable<NetworkQoS>
items, Guid qosId) {
Not sure I follow, where is this called with null?
Line 466: for (NetworkQoS qos : items) {
Line 467: if (qos.getId().equals(qosId)) {
Line 468: return qos;
Line 469: }
--
To view, visit http://gerrit.ovirt.org/22605
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib32cfe2392e86431323176fa9ef3e0aa00dbb841
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
