Allon Mureinik has posted comments on this change. Change subject: core: CDA messages - i18n/format ......................................................................
Patch Set 2: Code-Review+1 (2 comments) Looks fine to me. Tal? .................................................... Commit Message Line 3: AuthorDate: 2013-12-16 17:03:04 +0200 Line 4: Commit: Liron Aravot <lara...@redhat.com> Line 5: CommitDate: 2013-12-29 12:39:04 +0200 Line 6: Line 7: core: CDA messages - i18n/format I'd add some context here (e.g. snapshot validation CDA messages) Line 8: Line 9: * Removal of text from the message replacements to avoid breaking i18n. Line 10: * New lines where needed. Line 11: Line 5: CommitDate: 2013-12-29 12:39:04 +0200 Line 6: Line 7: core: CDA messages - i18n/format Line 8: Line 9: * Removal of text from the message replacements to avoid breaking i18n. s/text/hardcoded strings/ Line 10: * New lines where needed. Line 11: Line 12: Change-Id: I3a2c548c50cfab8d9a2d36730a7a8351449549d7 -- To view, visit http://gerrit.ovirt.org/22787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a2c548c50cfab8d9a2d36730a7a8351449549d7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
