Lior Vernia has posted comments on this change.
Change subject: engine: NetworkQoS validation in Add/Update Network
......................................................................
Patch Set 13:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java
Line 179: VdcBllMessages.VAR__ENTITIES__VM_TEMPLATES);
Line 180: }
Line 181:
Line 182: /**
Line 183: * @return An error iff the QoS entity attached to the network
isn't null, but doesn't exist in the database or
If and only if.
Line 184: * belongs to the wrong DC.
Line 185: */
Line 186: public ValidationResult qosExistsInDc() {
Line 187: NetworkQosValidator qosValidator = new
NetworkQosValidator(getDbFacade().getQosDao().get(network.getQosId()));
Line 183: * @return An error iff the QoS entity attached to the network
isn't null, but doesn't exist in the database or
Line 184: * belongs to the wrong DC.
Line 185: */
Line 186: public ValidationResult qosExistsInDc() {
Line 187: NetworkQosValidator qosValidator = new
NetworkQosValidator(getDbFacade().getQosDao().get(network.getQosId()));
True, but simpler code and should return the correct result. Fix or not?
Line 188: ValidationResult res = qosValidator.qosExists();
Line 189: return (res == ValidationResult.VALID) ?
qosValidator.consistentDataCenter() : res;
Line 190: }
Line 191:
--
To view, visit http://gerrit.ovirt.org/22602
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70ecf50f5f786544cc4a68286ef9850c2b525026
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
