Lior Vernia has posted comments on this change.
Change subject: engine: Extracted some QoS validation to NetworkQosValidator
......................................................................
Patch Set 13:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkQosValidator.java
Line 33: /**
Line 34: * Verify that the QoS entity has the same DC ID as the one stored
in the database.
Line 35: */
Line 36: public ValidationResult consistentDataCenter() {
Line 37: return (qos != null && (getOldQos() == null ||
!qos.getStoragePoolId().equals(getOldQos().getStoragePoolId())))
Clarification: "At this point" meaning in this patch. Anonymous QoS is created
in later patches when the VDSM reports QoS configuration for an interface. In
which case this validation isn't run.
Line 38: ? new
ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_NETWORK_QOS_INVALID_DC_ID)
Line 39: : ValidationResult.VALID;
Line 40: }
Line 41:
--
To view, visit http://gerrit.ovirt.org/22600
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I13dbb35bbd4cdbf4071e79d81eeb52667b734fcb
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
