Mike Kolesnik has posted comments on this change. Change subject: core: Added feature support versions for Host QoS ......................................................................
Patch Set 2: (1 comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java Line 177: public static boolean networkQoS(Version version) { Line 178: return supportedInConfig(ConfigValues.NetworkQosSupported, version); Line 179: } Line 180: Line 181: public static boolean HostNetworkQos(Version version) { Why first letter in upper case? Line 182: return supportedInConfig(ConfigValues.HostNetworkQosSupported, version); Line 183: } Line 184: Line 185: /** -- To view, visit http://gerrit.ovirt.org/22597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id66a22be4a30716f70af9bfcf2e467156d9c2a42 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches