Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: REST: ProductInfo use ProductRPMVersion
..
REST: ProductInfo use ProductRPMVersion
Frontend uses ProductRPMVersion from vdc_options to provide vers
Alon Bar-Lev has posted comments on this change.
Change subject: pki: delete cacert alias from keystore before import
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/13419
To unsubscribe, visit http://gerrit.
Alon Bar-Lev has posted comments on this change.
Change subject: pki: delete cacert alias from keystore before import
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Alon Bar-Lev has uploaded a new change for review.
Change subject: pki: delete cacert alias from keystore before import
..
pki: delete cacert alias from keystore before import
Java keystore will not overwrite certificate, leavin
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: add options for wrappers
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13418
To unsubscribe, visit http://gerrit.o
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: leave valid fd at stdin
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13417
To unsubscribe, visit http://gerrit.ov
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: do not fail if setsid fails
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13416
To unsubscribe, visit http://gerri
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: rework start pid file handling
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13415
To unsubscribe, visit http://ge
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: use kill to detect running processes
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13414
To unsubscribe, visit htt
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: cleanup pyflakes warnings
..
Patch Set 1:
We should really get rid of all of these globals in favor of dictionary context.
--
To view,
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: cleanup pyflakes warnings
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13413
To unsubscribe, visit http://gerrit.
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: rework start pid file handling
..
packaging: engine-service: rework start pid file handling
There is no reason to force user to explic
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: do not fail if setsid fails
..
packaging: engine-service: do not fail if setsid fails
setsid fails if already session leader.
Change-
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: use kill to detect running processes
..
packaging: engine-service: use kill to detect running processes
Change-Id: I20238c634c418029c6
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: leave valid fd at stdin
..
packaging: engine-service: leave valid fd at stdin
Change-Id: Ib029542a45f7fa6e486ae3876b20d18c56374228
Sig
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: cleanup pyflakes warnings
..
packaging: engine-service: cleanup pyflakes warnings
Change-Id: I2186d79e96aaf2789ee860e7e7e34a20d71e6287
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: add options for wrappers
..
packaging: engine-service: add options for wrappers
In order to be used at other environments, with their
Daniel Erez has posted comments on this change.
Change subject: webadmin: UI-plugins MainTabActionButton CommandLocation
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13376
To unsubscribe, visit http://gerr
Barak Azulay has posted comments on this change.
Change subject: agent: Windows Guest - ini file lookup
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13341
To unsubscribe, visit http://ger
Barak Azulay has posted comments on this change.
Change subject: agent: Recommend python 2.7.3 for windows in the README
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13342
To unsubscribe,
Barak Azulay has submitted this change and it was merged.
Change subject: agent: Add a configure option to disable SSO
..
agent: Add a configure option to disable SSO
We don't support SSO on all systems, therefore we should at
Barak Azulay has posted comments on this change.
Change subject: agent: Add a configure option to disable SSO
..
Patch Set 2: Verified; Looks good to me, approved
Verified by: Vinzenz
Approved by: Barak Azulay
--
To view, visi
Barak Azulay has posted comments on this change.
Change subject: agent: Add a configure option to disable SSO
..
Patch Set 2:
Verified by: Vinzenz
Approved by: Barak Azulay
--
To view, visit http://gerrit.ovirt.org/13334
To un
Barak Azulay has posted comments on this change.
Change subject: agent: Include windows files in tar balls
..
Patch Set 2:
why do we need it ?
--
To view, visit http://gerrit.ovirt.org/13340
To unsubscribe, visit http://gerrit
Barak Azulay has posted comments on this change.
Change subject: agent: Add a configure option to disable SSO
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13334
To unsubscribe, visit http
Barak Azulay has posted comments on this change.
Change subject: Added myself to AUTHORS
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1
To unsubscribe, visit http://gerrit.ovirt.org/s
Barak Azulay has submitted this change and it was merged.
Change subject: Added myself to AUTHORS
..
Added myself to AUTHORS
Change-Id: I541d0ecdf6e623210c5ecd89cdb694cb90e199c2
Signed-off-by: Vinzenz Feenstra
---
M AUTHORS
1
Arik Hadas has posted comments on this change.
Change subject: frontend: fluent API instead of temporary fields
..
Patch Set 4: (1 inline comment)
File
frontend/webadmin/mod
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: /etc/ovirt-engine should not be owned by engine
..
Patch Set 1: Verified
Maybe someone know something I don't... I afraid of the ldap stuff... yair?
V
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: /etc/ovirt-engine should not be owned by engine
..
packaging: /etc/ovirt-engine should not be owned by engine
engine does not and should not write int
Laszlo Hornyak has submitted this change and it was merged.
Change subject: engine: remove redundant check from setter in StorageDomain
..
engine: remove redundant check from setter in StorageDomain
checking if the status the s
Laszlo Hornyak has posted comments on this change.
Change subject: engine: remove redundant check from setter in StorageDomain
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13366
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
..
Patch Set 18: Verified; Looks good to me, but someone else must approve
I hope no more issues.
Now styl
Alona Kaplan has posted comments on this change.
Change subject: frontend: fluent API instead of temporary fields
..
Patch Set 4: (1 inline comment)
File
frontend/webadmin/m
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: remove hide popup feature.
..
Patch Set 3: Looks good to me, approved
> Vojtech - any reason that you gave "+1" rather than "+2" on this patch?
Sorry,
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Application continue polling after logout
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10895
To unsubscribe, vi
Daniel Erez has submitted this change and it was merged.
Change subject: core: update DiskImageDynamic on RemoveSnapshot
..
core: update DiskImageDynamic on RemoveSnapshot
* Fetching image's size on endSuccessfully of
RemoveS
Daniel Erez has posted comments on this change.
Change subject: core: update DiskImageDynamic on RemoveSnapshot
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13243
To unsubscribe
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: grids jump to last selected entity
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10672
To unsubscribe, visit htt
Liron Ar has posted comments on this change.
Change subject: core: allow hibernate for vm without image disks (#928708)
..
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
..
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: Drop support for IE6-7
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13393
To unsubscribe, visit http:/
Daniel Erez has posted comments on this change.
Change subject: core: Fix unpermitted Move-Disk in Audit mode
..
Patch Set 1: (1 inline comment)
Commit Message
Line 5: Commit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Drop support for IE6-7
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13393
To unsubscribe, visit http://gerrit.ovirt.or
ofri masad has posted comments on this change.
Change subject: core: Fix unpermitted Move-Disk in Audit mode
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13410
To unsubscribe, visit http://gerrit.ovirt.org
ofri masad has uploaded a new change for review.
Change subject: core: Fix unpermitted Move-Disk in Audit mode
..
core: Fix unpermitted Move-Disk in Audit mode
When Data Center is in quota enforcement mode 'Audit', a user can mo
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
..
Patch Set 16: Fails; I would prefer that you didn't submit this
found some more issues...
--
To view, v
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: removed --no-mem-check from engine-setup
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13409
To unsubscribe, visit http://gerr
Sandro Bonazzola has uploaded a new change for review.
Change subject: packaging: removed --no-mem-check from engine-setup
..
packaging: removed --no-mem-check from engine-setup
If minimum memory requirements are not met:
- on i
Laszlo Hornyak has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (1)
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
..
Patch Set 16: Verified; Looks good to me, but someone else must approve
Remove double slash from proxy U
Gilad Chaplik has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (1)
..
Patch Set 1:
please continue and review the rest of the topic branch.
thanks.
--
To view, visit http://gerrit.ovir
Mike Kolesnik has posted comments on this change.
Change subject: engine: Extending migrate verb with an additional parameter-
"dstqemu"
..
Patch Set 10: (4 inline comments)
Gilad Chaplik has abandoned this change.
Change subject: core: clean-up RunVmCommand.CanDoAction (2/15)
..
Patch Set 2: Abandoned
resubmitted and addressed your comments there:
http://gerrit.ovirt.org/#/c/13397/
sorry for the n
Gilad Chaplik has abandoned this change.
Change subject: core: Move RunVm validation logic to RunVmCommand (1/15)
..
Patch Set 2: Abandoned
resubmitted and addressed your comments there:
http://gerrit.ovirt.org/#/c/13397/
sorry
Gilad Chaplik has uploaded a new change for review.
Change subject: core: RunVmCommand.canDoAction cleanup (1)
..
core: RunVmCommand.canDoAction cleanup (1)
Inital commit includes adding a new class 'RunVmValidator';
Eventually,
Gilad Chaplik has uploaded a new change for review.
Change subject: core: move findActiveISODomain to IsoDomainListSyncronizer (2)
..
core: move findActiveISODomain to IsoDomainListSyncronizer (2)
To a more suitable place
Chang
Gilad Chaplik has abandoned this change.
Change subject: core: runVmCommandParams: remove get/setInternalExecution (3/15)
..
Patch Set 2: Abandoned
resubmitted as part of a topic branch:
http://gerrit.ovirt.org/#/c/13408/
--
T
Gilad Chaplik has uploaded a new change for review.
Change subject: core: runVmCommand.canDoAction clean-up (12)
..
core: runVmCommand.canDoAction clean-up (12)
move vdsSelector validation to the command itself
Change-Id: Ia048
Gilad Chaplik has uploaded a new change for review.
Change subject: core: runVmCommand.canDoAction clean up (13)
..
core: runVmCommand.canDoAction clean up (13)
- Vm status validtion
- Removal of RunVmHandler
Change-Id: I6e2ca6
Gilad Chaplik has uploaded a new change for review.
Change subject: core: runVmCommandParams: remove get/setInternalExecution
..
core: runVmCommandParams: remove get/setInternalExecution
AuditLogableBase.isInternalExecution() ca
Mike Kolesnik has posted comments on this change.
Change subject: engine: adding "migration" property to NetworkCluster
..
Patch Set 9: (4 inline comments)
File
backend/mana
Gilad Chaplik has uploaded a new change for review.
Change subject: core: RunVmCommand.canDoAction clean-up (9)
..
core: RunVmCommand.canDoAction clean-up (9)
vmDuringInitialization.
Change-Id: I2b595b419ac6f4c6b42eecef9f8f8f62
Gilad Chaplik has uploaded a new change for review.
Change subject: core: RunVmCommand.canDoAction clean-up (6)
..
core: RunVmCommand.canDoAction clean-up (6)
Check for vm images.
Change-Id: I297c9afba655c38ffdd870f61b1967732a7
Gilad Chaplik has uploaded a new change for review.
Change subject: core: RunVmCommand.canDoAction clean-up (10)
..
core: RunVmCommand.canDoAction clean-up (10)
vdsStatus (vm.status = paused + vds.status != up)
Change-Id: I7b32
Gilad Chaplik has uploaded a new change for review.
Change subject: core: RunVmCommand.canDoAction clean-up (11)
..
core: RunVmCommand.canDoAction clean-up (11)
Handle stateless vm.
Change-Id: Ie887a05e17dd6a59b4e5d2df83a9aa7e3
Gilad Chaplik has uploaded a new change for review.
Change subject: core: RunVmCommand.canDoAction clean-up (4)
..
core: RunVmCommand.canDoAction clean-up (4)
extract vmNotLocked()
Change-Id: Iec2b8e21253feb718b297f0dd12b963b53
Gilad Chaplik has uploaded a new change for review.
Change subject: core: RunVmCommand.canDoAction cleanup (3)
..
core: RunVmCommand.canDoAction cleanup (3)
refactor and test run vm BootSequence
Change-Id: Ida913a72e04c4edc57f9
Gilad Chaplik has uploaded a new change for review.
Change subject: core: RunVmCommand.canDoAction clean-up (5)
..
core: RunVmCommand.canDoAction clean-up (5)
extract not in SnapshotsValidator().vmNotDuringSnapshot
Change-Id: I
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Control UI plugin dynamic tab alignment
..
webadmin: Control UI plugin dynamic tab alignment
This patch improves the existing UI plugin API fo
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Control UI plugin dynamic tab alignment
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11273
To unsubsc
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: UI plugin dialog API improved
..
webadmin: UI plugin dialog API improved
This patch improves the existing UI plugin API for handling dialogs.
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugin dialog API improved
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11717
To unsubscribe, visi
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Select english when browser is other locale
..
webadmin: Select english when browser is other locale
- Fixed ability to select English (which
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Select english when browser is other locale
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11047
To uns
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Select english when browser is other locale
..
Patch Set 5:
It seems that recent versions of Firefox have the "navigator.language"
implemented correct
Laszlo Hornyak has abandoned this change.
Change subject: engine: hashcode method simplification (2/2) [wip]
..
Patch Set 2: Abandoned
squashed
--
To view, visit http://gerrit.ovirt.org/13386
To unsubscribe, visit http://gerri
Frank Kobzik has posted comments on this change.
Change subject: engine: Fixes in non plugin console invocation
..
Patch Set 2: (3 inline comments)
File
frontend/webadmin/mo
Mike Kolesnik has posted comments on this change.
Change subject: engine: adding "NetworkMigrationEnabled" to vdc_options.
..
Patch Set 1: (1 inline comment)
File
backend/ma
Laszlo Hornyak has posted comments on this change.
Change subject: engine: hashcode method simplification [wip]
..
Patch Set 2:
This patch is trying to demonstrate how hashCode() could be simplified. If
everyone/most of us lik
Gilad Chaplik has posted comments on this change.
Change subject: engine: hashcode method simplification [wip]
..
Patch Set 2:
a small q:
Will you enforce others to write hashCode in this fashion?
--
To view, visit http://gerr
Omer Frenkel has posted comments on this change.
Change subject: core: allow hibernate for vm without image disks (#928708)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13395
To unsubscribe, visit http://g
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
..
Patch Set 15: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Omer Frenkel has uploaded a new change for review.
Change subject: core: allow hibernate for vm without image disks (#928708)
..
core: allow hibernate for vm without image disks (#928708)
remove check for image disks,
move stora
Sandro Bonazzola has posted comments on this change.
Change subject: pki: set ownership of apache key to root
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13381
To un
Sandro Bonazzola has posted comments on this change.
Change subject: pki: set keys permission to world readable and owned by root
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
..
Patch Set 15: Verified
Changed the if module to use more portable module name.
Added ifmodule to the wh
Ravi Nori has posted comments on this change.
Change subject: restapi : Creating template by specifing vm name, does not work
(#915285)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13375
To unsubscribe, v
Daniel Erez has posted comments on this change.
Change subject: core: update DiskImageDynamic on RemoveSnapshot
..
Patch Set 2: (1 inline comment)
File
backend/manager/modul
Michael Pasternak has posted comments on this change.
Change subject: restapi : Creating template by specifing vm name, does not work
(#915285)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerr
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi : Creating template by specifing vm name, does not work
(#915285)
..
restapi : Creating template by specifing vm name, does not work (#91528
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Drop support for IE6-7
..
Patch Set 1:
This patch is a follow-up to http://gerrit.ovirt.org/#/c/11629/ which removes
support for IE6-7.
--
Daniel Erez has posted comments on this change.
Change subject: webadmin: Console connect button availability fix
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: add missing log4j dep
..
restapi: add missing log4j dep
Change-Id: I6980d7a3acd38940a1c9e63bee028a7ee826cd7a
Signed-off-by: Michael Pastern
Michael Pasternak has posted comments on this change.
Change subject: restapi: add missing log4j dep
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13394
To unsubscribe, visit htt
Maor Lipchuk has posted comments on this change.
Change subject: restapi: add missing log4j dep
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13394
To unsubscribe, visit http://gerrit.ovir
Michael Pasternak has uploaded a new change for review.
Change subject: restapi: add missing log4j dep
..
restapi: add missing log4j dep
Change-Id: I6980d7a3acd38940a1c9e63bee028a7ee826cd7a
Signed-off-by: Michael Pasternak
---
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin,userportal: Drop support for IE6-7
..
webadmin,userportal: Drop support for IE6-7
This patch removes "ie6" user agent from default GWT compilation,
whi
Shireesh Anjal has submitted this change and it was merged.
Change subject: webadmin: fix NPE in WebAdminHostPageServletTest
..
webadmin: fix NPE in WebAdminHostPageServletTest
Two @Before methods in WebAdminHostPageServletTest
Shireesh Anjal has posted comments on this change.
Change subject: webadmin: fix NPE in WebAdminHostPageServletTest
..
Patch Set 2: Verified; Looks good to me, approved
Vojtech, if the two methods are called in opposite order t
Shireesh Anjal has posted comments on this change.
Change subject: webadmin: fix NPE in WebAdminHostPageServletTest
..
Patch Set 2:
Vojtech, if the two methods are called in opposite order than assumed,
mockPluginDefinitionsAr
1 - 100 of 178 matches
Mail list logo
