Daniel Erez has posted comments on this change. Change subject: webadmin: Console connect button availability fix ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java Line 2803: Line 2804: getGuideCommand().setIsExecutionAllowed(getGuideContext() != null Line 2805: || (getSelectedItem() != null && getSelectedItems() != null && getSelectedItems().size() == 1)); Line 2806: Line 2807: this.checkConsoleAvailabilityEvent.raise(this, EventArgs.Empty); Do we have to explicitly raise an event here? (maybe bind to the a relevant model instead?) Line 2808: } Line 2809: Line 2810: /** Line 2811: * Return true if and only if one element is selected. -- To view, visit http://gerrit.ovirt.org/13343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If102303d6b5c5ac45959b87a540c8ea278c227c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
