Vojtech Szocs has posted comments on this change. Change subject: webadmin: Select english when browser is other locale ......................................................................
Patch Set 5: It seems that recent versions of Firefox have the "navigator.language" implemented correctly, i.e. to return preferred content language. I made a mistake during my testing, scratch my last comment, the patch works. Two small comments: * Patch also works with <gwt.locale>en</gwt.locale> instead of "default", I think we should use "en" everywhere instead of "default" for consistency * For browsers not implementing "navigator.language" correctly, we could make a separate patch that puts 'Accept-Language' header into GWT locale meta-tag (which overrides "navigator.language" detection). -- To view, visit http://gerrit.ovirt.org/11047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1b31fe65c306602c45c85857ccc7392e16dc8d3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
