Daniel Erez has posted comments on this change. Change subject: core: update DiskImageDynamic on RemoveSnapshot ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java Line 92: Line 93: private void updateDiskImageDynamic() { Line 94: VDSReturnValue ret = runVdsCommand( Line 95: VDSCommandType.GetImageInfo, Line 96: new GetImageInfoVDSCommandParameters(getDestinationDiskImage().getStoragePoolId().getValue(), GetImageInfoVDSCommand catches the exception (so no need for another try/catch block) Line 97: getDestinationDiskImage().getStorageIds().get(0), Line 98: getDestinationDiskImage().getId(), Line 99: getDestinationDiskImage().getImageId())); Line 100: -- To view, visit http://gerrit.ovirt.org/13243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie124fb42c34860ee349e91172e0248a2d824b127 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches