Shireesh Anjal has posted comments on this change.

Change subject: webadmin: fix NPE in WebAdminHostPageServletTest
......................................................................


Patch Set 2:

Vojtech, if the two methods are called in opposite order than assumed, 
mockPluginDefinitionsArray would be null when the following line is executed:
when(mockRequest.getAttribute(WebAdminHostPageServlet.ATTR_PLUGIN_DEFS)).thenReturn(mockPluginDefinitionsArray);

This means that during test execution, 
getAttribute(WebAdminHostPageServlet.ATTR_PLUGIN_DEFS) returns null, and hence 
the NPE.

--
To view, visit http://gerrit.ovirt.org/13350
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib76f7bd842d3b58c522e3e97609a9b55d5a79902
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to