Arik Hadas has posted comments on this change. Change subject: frontend: fluent API instead of temporary fields ......................................................................
Patch Set 4: (1 inline comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java Line 1395 Line 1396 Line 1397 Line 1398 Line 1399 I found that I didn't remove it as part of http://gerrit.ovirt.org/#/c/13208 (the model initialization part of this function moved to WebadminRunOnceModel, as we talked about). it didn't make any harm not removing it, but it's just duplicate code so I remove it as part of this patch -- To view, visit http://gerrit.ovirt.org/13246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bfe6b084ecc0643a5a45a1fb9a1170b415ed15 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
