Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Updated 'nfs exports' step alignment in cleanup
..
packaging: Updated 'nfs exports' step alignment in cleanup
Change-Id: I06d36c964a6b812598
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated 'nfs exports' step alignment in cleanup
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12384
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated 'nfs exports' step alignment in cleanup
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12384
To unsubsc
Project: http://jenkins.ovirt.org/job/ovirt_engine/
Build: http://jenkins.ovirt.org/job/ovirt_engine/4407/
Build Number: 4407
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Chang
Juan Hernandez has posted comments on this change.
Change subject: pki: preserve template files during upgrade
..
Patch Set 2: Looks good to me, but someone else must approve
Please verify.
--
To view, visit http://gerrit.ovir
Michael Kublin has posted comments on this change.
Change subject: engine: Removing opening of global transaction from endAction
..
Patch Set 1:
re: "All flows that have multiple DAO calls in end actions (under global
transact
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: changed psql execution environment
..
packaging: changed psql execution environment
Added LC_ALL=C in the environment provided by getPgPassE
Juan Hernandez has posted comments on this change.
Change subject: packaging: changed psql execution environment
..
Patch Set 4: Verified; Looks good to me, approved
Merging based on previous acks and verification.
--
To view,
Juan Hernandez has posted comments on this change.
Change subject: packaging: changed psql execution environment
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12227
To unsubscribe, visit h
Tomas Jelinek has posted comments on this change.
Change subject: webadmin,userportal: set up Proxy property to SPICE
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/12093
To unsubscribe, visit http://gerrit.
Tomas Jelinek has posted comments on this change.
Change subject: webadmin,userportal: set up Proxy property to SPICE
..
Patch Set 6: (1 inline comment)
File
frontend/webadm
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Don't resolve plugins
..
packaging: Don't resolve plugins
Now that we have a plugin in the project that is required for the build
(the jboss
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't resolve plugins
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12239
To unsubscribe, visit http
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't resolve plugins
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12239
To unsubscribe, visit http://gerrit.
Juan Hernandez has posted comments on this change.
Change subject: packaging: Remove Module.resourcePath
..
Patch Set 6:
Instead of this I would rather add the missing "setResourcePath" method. Any
objection to that?
--
To vi
Allon Mureinik has posted comments on this change.
Change subject: core: Unfilter ImagesHandler.PerformImagesChecks
..
Patch Set 3: Verified
fixed a previous patch, no changes to this one.
--
To view, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: Add ImagesHandler.filterEditableImageDisks
..
Patch Set 3: Verified
fixed a previous patch, no changes to this one.
--
To view, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: ImageHandlerTest - add missing annotation
..
Patch Set 3: Verified
fixed a previous patch, no changes to this one.
--
To view, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler: filterImageDisks readability
..
Patch Set 3:
Fixed typo as per Liron's review.
--
To view, visit http://gerrit.ovirt.org/12318
To unsubscr
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler: filterImageDisks readability
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/12318
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler: filterImageDisks readability
..
Patch Set 2: (1 inline comment)
File
backend/manager/
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix broken bll unit test
..
core: Fix broken bll unit test
An error was introduced due to usage of AsyncTaskDao.getAll in the CTOR of the
AsyncTa
Allon Mureinik has posted comments on this change.
Change subject: core: Fix broken bll unit test
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12385
To unsubscribe, visit http:/
Sahina Bose has uploaded a new change for review.
Change subject: engine:[WIP] Rebalance Gluster volume command
..
engine:[WIP] Rebalance Gluster volume command
Rebalance gluster volume is an asynchronous operation started from
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Removal of @override annotation
..
core: Removal of @override annotation
This removes an @override annotation which breaks compatbility with
open
Allon Mureinik has posted comments on this change.
Change subject: core: Removal of @override annotation
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12388
To unsubscribe, visit
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Removal of @override annotation
..
core: Removal of @override annotation
This removes an @override annotation which breaks compatbility with
open jdk6.
Kanagaraj M has posted comments on this change.
Change subject: packaging: excluding log4j.xml from dal.jar
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12369
To unsubscribe, visit http://gerrit.ovirt.org/
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Fixed typo
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Mes
Dhandapani Gopal has uploaded a new change for review.
Change subject: engine: Fixed typo
..
engine: Fixed typo
- Fixed typo Exteral to External in the AppErrors.properties
Change-Id: I09f6c8677c2248b98840cf7df81c60273fdcd677
S
Daniel Erez has posted comments on this change.
Change subject: engine: Propagate error message when quering for LDAP
users/groups
..
Patch Set 1: (2 inline comments)
File
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3467/
Build Number: 3467
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 4,403
-
Chang
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3466/
Build Number: 3466
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 4,402
-
Chang
Daniel Erez has posted comments on this change.
Change subject: core: Fix unit bll unit test
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
..
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: tool-tip for DirectLUN disk column
..
webadmin: tool-tip for DirectLUN disk column
Added a tool-tip for DirectLUN disk column (for each item).
A
Daniel Erez has posted comments on this change.
Change subject: webadmin: tool-tip for DirectLUN disk column
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12378
To unsubscribe, v
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Storage tabs - move description column
..
webadmin: Storage tabs - move description column
For keeping the convention on other tabs:
* move desc
Daniel Erez has posted comments on this change.
Change subject: webadmin: Storage tabs - move description column
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12377
To unsubscrib
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: storage tab - remove redundant name column
..
webadmin: storage tab - remove redundant name column
Remove redundant Domain Name column from Stor
Daniel Erez has posted comments on this change.
Change subject: webadmin: storage tab - remove redundant name column
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12376
To unsubs
Daniel Erez has posted comments on this change.
Change subject: webadmin: storage tab - remove redundant name column
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12376
To unsubscribe, visit http://gerrit.o
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Fix unit bll unit test
..
core: Fix unit bll unit test
An error was introduced due to usage of AsyncTaskDao.getAll in the CTOR of the
AsyncTaskManager si
Daniel Erez has posted comments on this change.
Change subject: webadmin: Create storage domains using Gluster FS.
..
Patch Set 2: (1 inline comment)
File
frontend/webadmin/
Daniel Erez has posted comments on this change.
Change subject: webadmin: Create storage domains using Gluster FS.
..
Patch Set 14: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8983
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: core: LSM - standardize version checks in CDA
..
Patch Set 1:
You should use GetCommandsCompatibilityVersions query in the UI so we could
remove LiveStorageMigrat
Daniel Erez has posted comments on this change.
Change subject: webadmin: prevent several imported VMs with same name
..
Patch Set 2: (4 inline comments)
File
frontend/webad
Daniel Paikov has posted comments on this change.
Change subject: core : ImportVm with snapshots without collapse - not all disks
are copied
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12297
To unsubscri
Liron Aravot has posted comments on this change.
Change subject: core: ImagesHandler: filterImageDisks readability
..
Patch Set 2: (1 inline comment)
File
backend/manager/mo
Liron Aravot has posted comments on this change.
Change subject: core: ImageHandlerTest - add missing annotation
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12319
To
Omer Frenkel has posted comments on this change.
Change subject: userportal: quota permissions show extended view wrongfully
..
Patch Set 1: (1 inline comment)
File
frontend
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated 'nfs exports' step alignment in cleanup
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12384
To unsubscribe, visit http://ge
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated 'nfs exports' step alignment
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12384
To unsubscribe, visit http://gerrit.ovirt.
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Updated 'nfs exports' step alignment
..
packaging: Updated 'nfs exports' step alignment
Change-Id: I06d36c964a6b8125982ce85328c52f603c227245
Signed-off
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: fixed time missing in br45 (#910778)
..
reports: fixed time missing in br45 (#910778)
Bug-Url: https://bugzilla.redhat.com/910778
Change-Id: I653
Yaniv Dary has posted comments on this change.
Change subject: reports: fixed time missing in br45 (#910778)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12383
To unsubscribe, v
Allon Mureinik has posted comments on this change.
Change subject: core: Unfilter ImagesHandler.PerformImagesChecks
..
Patch Set 2: Verified
fixed a previous patch, no changes to this one.
--
To view, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: Add ImagesHandler.filterEditableImageDisks
..
Patch Set 2: Verified
fixed a previous patch, no changes to this one.
--
To view, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: ImageHandlerTest - add missing annotation
..
Patch Set 2: Verified
fixed a previous patch, no changes to this one.
--
To view, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler: filterImageDisks readability
..
Patch Set 2: Verified
Fixed allowOnlyAllowSnapshotDisks->allowSnapable disks, no other changes.
--
To view
Allon Mureinik has posted comments on this change.
Change subject: core: add ability edit nfs path in webadmin
..
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
Some minor issues, see inline.
Givi
Yaniv Dary has uploaded a new change for review.
Change subject: reports: fixed time missing in br45 (#910778)
..
reports: fixed time missing in br45 (#910778)
Bug-Url: https://bugzilla.redhat.com/910778
Change-Id: I653956a70b4
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: fixed input controls entities selection (#910778)
..
reports: fixed input controls entities selection (#910778)
Bug-Url: https://bugzilla.redhat.c
Yaniv Dary has posted comments on this change.
Change subject: reports: fixed input controls entities selection (#910778)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12382
To u
Alex Lourie has posted comments on this change.
Change subject: packaging: Creating keystore for jboss use
..
Patch Set 2: Verified
Tested setup, upgrade on a system without the keystore file and cleanup.
--
To view, visit htt
Alissa Bonas has posted comments on this change.
Change subject: core: ImagesHandler: filterImageDisks readability
..
Patch Set 1: (1 inline comment)
File
backend/manager/mo
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Updated taskcleaner use in remote DB flows
..
packaging: Updated taskcleaner use in remote DB flows
Currently taskcleaner is executed as if it was runn
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler: filterImageDisks readability
..
Patch Set 1: (1 inline comment)
File
backend/manager/
Tal Nisan has posted comments on this change.
Change subject: core: add ability edit nfs path in webadmin
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll
Alex Lourie has posted comments on this change.
Change subject: packaging: Creating keystore for jboss use
..
Patch Set 2:
@Ofer
engine.p12 is used for DB encryption and vdsm. Using the same key for jboss
doesn't really "sepa
Liron Aravot has posted comments on this change.
Change subject: core: add ability edit nfs path in webadmin
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/
Liron Aravot has posted comments on this change.
Change subject: core: add ability edit nfs path in webadmin
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/
Tal Nisan has posted comments on this change.
Change subject: core: add ability edit nfs path in webadmin
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll
Liron Aravot has posted comments on this change.
Change subject: core: add ability edit nfs path in webadmin
..
Patch Set 2: (7 inline comments)
File
backend/manager/modules
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Creating keystore for jboss use
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12374
To unsu
Alex Lourie has posted comments on this change.
Change subject: packaging: Creating keystore for jboss use
..
Patch Set 2:
Updated permissions of the keystore in setup.
--
To view, visit http://gerrit.ovirt.org/12374
To unsubs
Tal Nisan has posted comments on this change.
Change subject: core: add ability edit nfs path in webadmin
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll
Eyal Edri has posted comments on this change.
Change subject: packaging: Don't resolve plugins
..
Patch Set 1: Verified
http://jenkins.ovirt.org/view/rpms/job/ovirt-engine_create_rpms_fedora/jdk=java-1.7.0-openjdk.x86_64,label=
Alissa Bonas has posted comments on this change.
Change subject: core: ImageHandlerTest - add missing annotation
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
..
Alissa Bonas has posted comments on this change.
Change subject: core: add ability edit nfs path in webadmin
..
Patch Set 2: (13 inline comments)
@Liron, yes, there will be REST capability too for that feature, however since
Daniel Erez has posted comments on this change.
Change subject: webadmin: Show warning, if VM provides any non-exportable disks
..
Patch Set 2: (1 inline comment)
File
front
Tal Nisan has posted comments on this change.
Change subject: core: ImagesHandler: filterImageDisks readability
..
Patch Set 1: (1 inline comment)
File
backend/manager/modul
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3465/
Build Number: 3465
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 4,401
-
Chang
Gilad Chaplik has posted comments on this change.
Change subject: webadmin,userportal: Show data centers and their clusters based
on configured cluster service
..
Patch Set 5: (1 inline comment)
...
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Use engine.conf for local configuration
..
Patch Set 2:
Merge?
--
To view, visit http://gerrit.ovirt.org/7591
To unsubscribe, visit http://gerrit.ovir
Liron Aravot has posted comments on this change.
Change subject: core: ImagesHandler: filterImageDisks readability
..
Patch Set 1: (1 inline comment)
File
backend/manager/mo
Gilad Chaplik has posted comments on this change.
Change subject: core: Fix quota calculation for floating disks
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12269
To
Alissa Bonas has posted comments on this change.
Change subject: core: ImagesHandler: filterImageDisks readability
..
Patch Set 1: (1 inline comment)
File
backend/manager/mo
Liron Aravot has posted comments on this change.
Change subject: core: add ability edit nfs path in webadmin
..
Patch Set 2: (12 inline comments)
nice :) , please see in line comments..do you plan to make this usable through
R
Tal Nisan has posted comments on this change.
Change subject: webadmin: tool-tip for DirectLUN disk column
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12378
To unsubscribe, visit http://
Gilad Chaplik has posted comments on this change.
Change subject: core: simplify businessentity equals() methods [part 1]
..
Patch Set 1:
just thought of a cool way we can refactor here with no regressions (and hard
review)...
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler: filterImageDisks readability
..
Patch Set 1: (1 inline comment)
File
backend/manager/
Tal Nisan has posted comments on this change.
Change subject: webadmin: Storage tabs - move description column
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12377
To unsubscribe, visit htt
Eyal Edri has posted comments on this change.
Change subject: packaging: Don't resolve plugins
..
Patch Set 1: Looks good to me, but someone else must approve
can we merge this?
it's blocking some jenkins jobs running.
--
To
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Move lock RunVmCommand -> RunVmCommandBase
..
core: Move lock RunVmCommand -> RunVmCommandBase
Move RunVmCommand's exclusive lock up to its ances
Allon Mureinik has posted comments on this change.
Change subject: core: Move lock RunVmCommand -> RunVmCommandBase
..
Patch Set 2: Verified; Looks good to me, approved
Rebaed, no code changes.
+2 by Tal and Omer,
--
To view,
Alissa Bonas has posted comments on this change.
Change subject: core: ImagesHandler: filterImageDisks readability
..
Patch Set 1: (1 inline comment)
File
backend/manager/mo
Tal Nisan has posted comments on this change.
Change subject: webadmin: storage tab - remove redundant name column
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12376
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Creating keystore for jboss use
..
Patch Set 1:
> Code looks good to me. Why don't we use the "engine" keys we already have?
Already sent you an email
Tal Nisan has posted comments on this change.
Change subject: core: add ability edit nfs path in webadmin
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Creating keystore for jboss use
..
Patch Set 1:
OK, no problem... but keystore artifacts should usually be 0600...
--
To view, visit http://gerrit.ovi
1 - 100 of 205 matches
Mail list logo
