Alex Lourie has uploaded a new change for review.

Change subject: packaging: Updated taskcleaner use in remote DB flows
......................................................................

packaging: Updated taskcleaner use in remote DB flows

Currently taskcleaner is executed as if it was running only
on a locally installed DB. Added the correct parameters with
values of host/port of the DB, so that in case of remote DB
all the values will be sent correctly and the script will
execute on a remote DB server.

Additionally added missing common.sh file to the taskcleaner
packaging.

Change-Id: Ie3c205962521bafe56ff67f3f46dd83202f48b7e
Bug-Url: https://bugzilla.redhat.com/915028
Signed-off-by: Alex Lourie <alou...@redhat.com>
---
M Makefile
M packaging/fedora/setup/engine-upgrade.py
2 files changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/81/12381/1

diff --git a/Makefile b/Makefile
index ace2553..0de95d0 100644
--- a/Makefile
+++ b/Makefile
@@ -326,6 +326,7 @@
 
         # Task cleaner
        install -m 750 backend/manager/tools/dbutils/taskcleaner.sh 
$(DESTDIR)$(DATA_DIR)/scripts/taskcleaner
+       install -m 750 backend/manager/tools/dbutils/common.sh 
$(DESTDIR)$(DATA_DIR)/scripts/taskcleaner
        install -m 640 backend/manager/tools/dbutils/taskcleaner_sp.sql 
$(DESTDIR)$(DATA_DIR)/scripts/taskcleaner
 
 install_aio_plugin:
diff --git a/packaging/fedora/setup/engine-upgrade.py 
b/packaging/fedora/setup/engine-upgrade.py
index 6cd55a2..d681a07 100755
--- a/packaging/fedora/setup/engine-upgrade.py
+++ b/packaging/fedora/setup/engine-upgrade.py
@@ -773,6 +773,8 @@
     cmd = [
         basedefs.EXEC_TASK_CLEANER,
         "-u", SERVER_ADMIN,
+        "-s", SERVER_NAME,
+        "-p", SERVER_PORT,
         "-d", basedefs.DB_NAME,
         "-z",
     ]
@@ -797,6 +799,8 @@
     cmd = [
         basedefs.EXEC_TASK_CLEANER,
         "-u", SERVER_ADMIN,
+        "-s", SERVER_NAME,
+        "-p", SERVER_PORT,
         "-d", basedefs.DB_NAME,
         "-z",
         "-R",


--
To view, visit http://gerrit.ovirt.org/12381
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3c205962521bafe56ff67f3f46dd83202f48b7e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to