Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler: filterImageDisks readability
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 606: List<DiskImage> diskImages = new ArrayList<DiskImage>();
Line 607: for (Disk disk : listOfDisks) {
Line 608: if (disk.getDiskStorageType() == DiskStorageType.IMAGE &&
Line 609: (!allowOnlyNotShareableDisks ||
!disk.isShareable()) &&
Line 610: (!allowOnlySnapabletDisks ||
disk.isAllowSnapshot())) {
Done
Line 611: diskImages.add((DiskImage) disk);
Line 612: }
Line 613: }
Line 614: return diskImages;
--
To view, visit http://gerrit.ovirt.org/12318
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cc2fc314e05fda6b1c6cdf39365b64fa0cfe345
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
