Daniel Erez has posted comments on this change.
Change subject: engine: Propagate error message when quering for LDAP
users/groups
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
Line 232: + "]"); //$NON-NLS-1$
Line 233: if (getEventsHandler() != null) {
Line 234: ArrayList<VdcQueryReturnValue>
failedResult = new ArrayList<VdcQueryReturnValue>();
Line 235: failedResult.add(result);
Line 236:
getEventsHandler().runQueryFailed(failedResult);
why is it needed?
Line 237: String errorMessage =
result.getExceptionString();
Line 238: handleNotLoggedInEvent(errorMessage);
Line 239: }
Line 240: if (callback.isHandleFailure()) {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java
Line 241: _asyncQuery.asyncCallback = new INewAsyncCallback() {
Line 242: @Override
Line 243: public void OnSuccess(Object model, Object ReturnValue)
Line 244: {
Line 245: VdcQueryReturnValue rr = (VdcQueryReturnValue)
ReturnValue;
seems redundant...
Line 246: AdElementListModel adElementListModel =
(AdElementListModel) model;
Line 247: HashSet<Guid> excludeUsers = new HashSet<Guid>();
Line 248: if (getExcludeItems() != null)
Line 249: {
--
To view, visit http://gerrit.ovirt.org/11893
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50da72d12c6d60642ad5e65b9376efc49e4ef699
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
