Daniel Erez has posted comments on this change.

Change subject: webadmin: Create storage domains using Gluster FS.
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
Line 1298:             parameters,
Line 1299:             new 
ArrayList<IFrontendActionAsyncCallback>(Arrays.asList(new 
IFrontendActionAsyncCallback[] {
Line 1300:                         callback1, callback2 })),
Line 1301:             failureCallback,
Line 1302:             this);
No interest for a long time... we can start with the suggested approach and 
extract it later on.
Line 1303:     }
Line 1304: 
Line 1305:     private void SaveGlusterStorage(TaskContext context) {
Line 1306: 


--
To view, visit http://gerrit.ovirt.org/8983
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia74870ea95a103ecdd228a26d314ff66e2fcc675
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to