Allon Mureinik has posted comments on this change.
Change subject: core: add ability edit nfs path in webadmin
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
Some minor issues, see inline.
Giving -1 so this stops poping up on my gerrit frontpage until the corrections
agreed upon with Liron are fixed.
Also, a test would be nice ;-)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
Line 24: }
Line 25:
Line 26: @Override
Line 27: protected boolean canDoAction() {
Line 28: StorageServerConnections connection =
getParameters().getStorageServerConnection();
Just to make sure I got it right - this is the new connection details, right?
Line 29: //Check if the NFS path has a valid format
Line 30: if (connection.getstorage_type() == StorageType.NFS
Line 31: && !new
NfsMountPointConstraint().isValid(connection.getconnection(), null)) {
Line 32: return
failCanDoAction(VdcBllMessages.VALIDATION_STORAGE_CONNECTION_INVALID);
Line 27: protected boolean canDoAction() {
Line 28: StorageServerConnections connection =
getParameters().getStorageServerConnection();
Line 29: //Check if the NFS path has a valid format
Line 30: if (connection.getstorage_type() == StorageType.NFS
Line 31: && !new
NfsMountPointConstraint().isValid(connection.getconnection(), null)) {
Before doing this, shouldn't you fail if it isn't an NFS domain?
Also, isn't the infrastructure taking care of @Validations before you even get
to the canDoAction?
Line 32: return
failCanDoAction(VdcBllMessages.VALIDATION_STORAGE_CONNECTION_INVALID);
Line 33: }
Line 34: //Check if connection exists by id - otherwise there's nothing
to update
Line 35: String connectionId = connection.getid();
....................................................
Commit Message
Line 3: AuthorDate: 2013-02-10 17:17:54 +0200
Line 4: Commit: Alissa Bonas <abo...@redhat.com>
Line 5: CommitDate: 2013-02-24 13:22:08 +0200
Line 6:
Line 7: core: add ability edit nfs path in webadmin
general: s/nfs/NFS/
Line 8:
Line 9: Add the option to edit nfs path and the overriden
Line 10: additional options of storage domain (retransmissions, timeout,
version)
Line 11: in webadmin UI --> Storage tab.
Line 8:
Line 9: Add the option to edit nfs path and the overriden
Line 10: additional options of storage domain (retransmissions, timeout,
version)
Line 11: in webadmin UI --> Storage tab.
Line 12: The edit of those properties is available only when
s/The edit of/Editing/
Line 13: the storage domain is in maintenance status and is data/master domain,
Line 14: and for storage of nfs type. These are the only properties which are
Line 15: editable in this status.
Line 16: Edit is still available for storage domains in status Active/Mixed, but
--
To view, visit http://gerrit.ovirt.org/12372
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaff5344ff191d6bdf53cc706c7bb796167a56b3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
