Omer Frenkel has posted comments on this change.
Change subject: core: [RFE] Display Address Override
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9022
To unsubscribe, visit http://gerrit
Arik Hadas has posted comments on this change.
Change subject: core: Remove VMStatus#isGuestUp method
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10978
To unsubscribe, visit http://gerrit.ovirt.org/settin
Arik Hadas has posted comments on this change.
Change subject: core: Remove VMStatus#isGuestUp method
..
Patch Set 4:
rebased, verified
--
To view, visit http://gerrit.ovirt.org/10978
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: remove expensive use of ObjectDescriptor.toString
..
Patch Set 4:
@Roy - seems so, yes.
I was commenting that after your patch the only place the Jedi cl
Roy Golan has posted comments on this change.
Change subject: core: remove expensive use of ObjectDescriptor.toString
..
Patch Set 4:
@Allon - maybe a gerrit bug, I can't see your comment (possibly on a deleted
file?)
--
To v
Vered Volansky has posted comments on this change.
Change subject: core: Update Enums to support GLusterFS.
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8961
To unsub
Vered Volansky has posted comments on this change.
Change subject: core: TrybackToAllSnapshots vmDown validation
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11015
To
Vered Volansky has posted comments on this change.
Change subject: core: RemoveSnapshot vmDown validation
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11014
To unsubs
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Adjust configuration when using PREFIX
..
packaging: Adjust configuration when using PREFIX
When using the PREFIX make variable to install t
Juan Hernandez has posted comments on this change.
Change subject: packaging: Adjust configuration when using PREFIX
..
Patch Set 8: Verified; Looks good to me, approved
Merging based on previous acks and verification.
--
To v
Juan Hernandez has posted comments on this change.
Change subject: packaging: Adjust configuration when using PREFIX
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10982
To unsubscribe, vis
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: End list of dependencies in $(NULL)
..
packaging: End list of dependencies in $(NULL)
To simplify patching in the future make sure that list
Juan Hernandez has posted comments on this change.
Change subject: packaging: End list of dependencies in $(NULL)
..
Patch Set 2: Verified; Looks good to me, approved
Merging based on previous acks and verification.
--
To view
Juan Hernandez has posted comments on this change.
Change subject: packaging: End list of dependencies in $(NULL)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10992
To unsubscribe, visit
Vered Volansky has posted comments on this change.
Change subject: core: Consolidate vm down check when removing disk
..
Patch Set 1: (2 inline comments)
File
backend/manage
Yair Zaslavsky has posted comments on this change.
Change subject: core:Async Tasks cleaner utility...
..
Patch Set 3: (1 inline comment)
Eli, the former utility had the ability also to show all tasks (not just
zombies) and er
Vered Volansky has posted comments on this change.
Change subject: core: Early return RemoveDiskCommand.canDoAction()
..
Patch Set 1:
Oh, This also stands by itself and is unrelated to the other patches. Why not
remove the dep
Vered Volansky has posted comments on this change.
Change subject: core: Early return RemoveDiskCommand.canDoAction()
..
Patch Set 1: Looks good to me, but someone else must approve
So much better!
--
To view, visit http://ger
Vered Volansky has posted comments on this change.
Change subject: core: RemoveDiskCommand project standards
..
Patch Set 1: Looks good to me, but someone else must approve
+1 Specifically due to the override notation.
Not ever
Vered Volansky has posted comments on this change.
Change subject: core: VM is down check when adding template
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Vered Volansky has posted comments on this change.
Change subject: core: ExportVm vmDown validation
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Do you eventually intend to remove this arg
Vered Volansky has posted comments on this change.
Change subject: core: MoveVm vmDown validation
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
..
Allon Mureinik has posted comments on this change.
Change subject: core: RemoveDiskCommand project standards
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11011
To unsubscribe, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core: VM is down check when adding template
..
Patch Set 1: (1 inline comment)
File
backend/manager/module
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImagesHandler cleanup: Generic warnings
..
core: ImagesHandler cleanup: Generic warnings
Cleaned up warnings about using raw types in PerformImag
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImagesHandler cleanup: Logged empty catch
..
core: ImagesHandler cleanup: Logged empty catch
Added a log message to an empty catch block.
Change
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImagesHandler cleanup: unwrap else clauses
..
core: ImagesHandler cleanup: unwrap else clauses
Unwrapped useless else clauses where the if clause
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImagesHandler cleanup: remove useless const
..
core: ImagesHandler cleanup: remove useless const
Removed the useless BlankImageTemplateId constan
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImagesHandler cleanup: make log private
..
core: ImagesHandler cleanup: make log private
Made the log private, as per proper java conventions.
C
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove checkVmDown from PerformImagesChecks
..
core: Remove checkVmDown from PerformImagesChecks
Following a series of patches that removed all the useca
Allon Mureinik has uploaded a new change for review.
Change subject: core: MoveVm vmDown validation
..
core: MoveVm vmDown validation
Added an explicit test for VM.isDown in
MoveVmCommand.canDoAction() instead of using
ImagesHan
Allon Mureinik has uploaded a new change for review.
Change subject: core: TrybackToAllSnapshots vmDown validation
..
core: TrybackToAllSnapshots vmDown validation
Added an explicit test for VM.isDown in
TrybackToAllSnapshotsOfV
Allon Mureinik has uploaded a new change for review.
Change subject: core: ExportVm vmDown validation
..
core: ExportVm vmDown validation
Added an explicit test for VM.isDown in
ExportVmCommand.canDoAction() instead of using
Ima
Allon Mureinik has uploaded a new change for review.
Change subject: core: VM is down check when adding template
..
core: VM is down check when adding template
AddTemplateCommand explicitly checks if the VM is down in the
canDoA
Allon Mureinik has uploaded a new change for review.
Change subject: core: RemoveDiskCommand project standards
..
core: RemoveDiskCommand project standards
Fixed RemoveDiskCommand's formatting to comply with project standards of
Allon Mureinik has uploaded a new change for review.
Change subject: core: Consolidate vm down check when removing disk
..
core: Consolidate vm down check when removing disk
Both removing an image and a LUN disk had to check tha
Allon Mureinik has uploaded a new change for review.
Change subject: core: RemoveSnapshot vmDown validation
..
core: RemoveSnapshot vmDown validation
Added an explicit test for VM.isDown in
RemoveSnapshotCommand.canDoAction() in
Allon Mureinik has uploaded a new change for review.
Change subject: core: Early return RemoveDiskCommand.canDoAction()
..
core: Early return RemoveDiskCommand.canDoAction()
Converted RemoveDiskCommand.canDoAction() to use the e
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: Adjust configuration when using PREFIX
..
Patch Set 7: Looks good to me, but someone else must approve
I agree the $(NULL) changes are mu
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: End list of dependencies in $(NULL)
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Add cluster policy to edit cluster
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10573
To uns
Tal Nisan has posted comments on this change.
Change subject: core: ImagesHandler cleanup: Generic warnings
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10999
To unsubscribe, visit http:/
Tal Nisan has posted comments on this change.
Change subject: core: ImagesHandler cleanup: Logged empty catch
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
Minor comment, up to you if you'd take it
...
Tal Nisan has posted comments on this change.
Change subject: core: ImagesHandler cleanup: unwrap else clauses
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10997
To unsubscribe, visit htt
Tal Nisan has posted comments on this change.
Change subject: core: ImagesHandler cleanup: remove useless const
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10996
To unsubscribe, visit ht
Tal Nisan has posted comments on this change.
Change subject: core: ImagesHandler cleanup: make log private
..
Patch Set 1: Looks good to me, approved
Also imports order sorting by the way.. ;)
--
To view, visit http://gerrit.
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: post ovirt-host-deploy-1.0.0_beta
..
packaging: post ovirt-host-deploy-1.0.0_beta
Change-Id: Ifb55f8e8e77b6fe01601d3f44ed87c4b295a877c
Signed-
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: post ovirt-host-deploy-1.0.0_beta
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11009
To unsubscribe,
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: ovirt-host-deploy-1.0.0_beta
..
packaging: ovirt-host-deploy-1.0.0_beta
Change-Id: Ia61bf5eae69ae561d7f9c50b5c0ffb6b2ab315d3
Signed-off-by: Al
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: ovirt-host-deploy-1.0.0_beta
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11008
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: bump master to 1.0.0
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11007
To unsubscribe, visit http://
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: bump master to 1.0.0
..
packaging: bump master to 1.0.0
Change-Id: I173f283de21ee348c7d3dfd8e058587c2073893b
Signed-off-by: Alon Bar-Lev
---
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: setup tarball publish location
..
packaging: setup tarball publish location
Change-Id: I8c2e7f04b40fe828ca6d6ca03e1ca6e040bf30c0
Signed-off-by
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup tarball publish location
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11006
To unsubscribe, vis
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: ovirt-host-deploy-1.0.0_beta
..
packaging: ovirt-host-deploy-1.0.0_beta
Change-Id: Ia61bf5eae69ae561d7f9c50b5c0ffb6b2ab315d3
Signed-off-by: Alon Bar-L
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: bump master to 1.0.0
..
packaging: bump master to 1.0.0
Change-Id: I173f283de21ee348c7d3dfd8e058587c2073893b
Signed-off-by: Alon Bar-Lev
---
M Change
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: post ovirt-host-deploy-1.0.0_beta
..
packaging: post ovirt-host-deploy-1.0.0_beta
Change-Id: Ifb55f8e8e77b6fe01601d3f44ed87c4b295a877c
Signed-off-by:
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: setup tarball publish location
..
packaging: setup tarball publish location
Change-Id: I8c2e7f04b40fe828ca6d6ca03e1ca6e040bf30c0
Signed-off-by: Alon B
Eli Mesika has uploaded a new change for review.
Change subject: core:Async Tasks cleaner utility...
..
core:Async Tasks cleaner utility...
Adding a utility to clean async tasks.
The utility enables to
display all async tasks
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: post otopi-1.0.0_beta
..
packaging: post otopi-1.0.0_beta
Change-Id: I6085aca6d909a08c3eb6068bcfc1ba1a08149e9b
Signed-off-by: Alon Bar-Lev
--
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: post otopi-1.0.0_beta
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11004
To unsubscribe, visit http:/
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: otopi-1.0.0_beta
..
packaging: otopi-1.0.0_beta
Change-Id: I97b18e36e9fc2190113b2f052d2d5bdc2881f046
Signed-off-by: Alon Bar-Lev
---
M config
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: otopi-1.0.0_beta
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11003
To unsubscribe, visit http://gerr
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: bump master to 1.0.0
..
packaging: bump master to 1.0.0
Change-Id: Ie9b8c9fd46df45dce1a8f8ebcbc0d22b36000bb0
Signed-off-by: Alon Bar-Lev
---
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: bump master to 1.0.0
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11002
To unsubscribe, visit http://
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: setup tarball publish location
..
packaging: setup tarball publish location
Change-Id: I5332cbfcf68b24695eea01e476def1ac0423bedb
Signed-off-by
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup tarball publish location
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11001
To unsubscribe, vis
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: bump master to 1.0.0
..
packaging: bump master to 1.0.0
Change-Id: Ie9b8c9fd46df45dce1a8f8ebcbc0d22b36000bb0
Signed-off-by: Alon Bar-Lev
---
M Change
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: post otopi-1.0.0_beta
..
packaging: post otopi-1.0.0_beta
Change-Id: I6085aca6d909a08c3eb6068bcfc1ba1a08149e9b
Signed-off-by: Alon Bar-Lev
---
M conf
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: otopi-1.0.0_beta
..
packaging: otopi-1.0.0_beta
Change-Id: I97b18e36e9fc2190113b2f052d2d5bdc2881f046
Signed-off-by: Alon Bar-Lev
---
M configure.ac
M
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: setup tarball publish location
..
packaging: setup tarball publish location
Change-Id: I5332cbfcf68b24695eea01e476def1ac0423bedb
Signed-off-by: Alon B
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: branding cleanup
..
Patch Set 1:
Guys, please try to push upstream as much as we can.
Thanks!
--
To view, visit http://gerrit.ovirt.org/11000
To unsu
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: branding cleanup
..
packaging: branding cleanup
Two changes to ease branding.
Change-Id: I62e31f8a50f7e1db575e9bd5f5388d4c60e5c34a
Signed-off-by: Alo
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler cleanup: Generic warnings
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10999
To unsubscribe, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler cleanup: Logged empty catch
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10998
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler cleanup: unwrap else clauses
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10997
To unsubscribe, visit http://gerrit.ov
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler cleanup: remove useless const
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10996
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler cleanup: make log private
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10995
To unsubscribe, visit http://gerrit.ovirt
Allon Mureinik has uploaded a new change for review.
Change subject: core: ImagesHandler cleanup: make log private
..
core: ImagesHandler cleanup: make log private
Made the log private, as per proper java conventions.
Change-Id
Allon Mureinik has uploaded a new change for review.
Change subject: core: ImagesHandler cleanup: unwrap else clauses
..
core: ImagesHandler cleanup: unwrap else clauses
Unwrapped useless else clauses where the if clause does no
Allon Mureinik has uploaded a new change for review.
Change subject: core: ImagesHandler cleanup: remove useless const
..
core: ImagesHandler cleanup: remove useless const
Removed the useless BlankImageTemplateId constant which
Allon Mureinik has uploaded a new change for review.
Change subject: core: ImagesHandler cleanup: Logged empty catch
..
core: ImagesHandler cleanup: Logged empty catch
Added a log message to an empty catch block.
Change-Id: Ie6
Allon Mureinik has uploaded a new change for review.
Change subject: core: ImagesHandler cleanup: Generic warnings
..
core: ImagesHandler cleanup: Generic warnings
Cleaned up warnings about using raw types in PerformImagesChecks
Allon Mureinik has posted comments on this change.
Change subject: engine: Removal of code related to importing SAN storage domains
..
Patch Set 1: I would prefer that you didn't submit this
please also remove
VdcBllMessages.E
Allon Mureinik has posted comments on this change.
Change subject: fix test
..
Patch Set 1:
Laszlo, are you sure about this?
The test seems to run fine for me - both with "mvn install -Penable-dao-tests"
and by running this t
Allon Mureinik has posted comments on this change.
Change subject: core: remove expensive use of ObjectDescriptor.toString
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
should also be remov
Allon Mureinik has submitted this change and it was merged.
Change subject: core: improve logs in several classes
..
core: improve logs in several classes
remove class name from log statement because it's logged anyway
switch f
Allon Mureinik has posted comments on this change.
Change subject: core: improve logs in several classes
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10993
To unsubscribe, visit
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/3112/
Build Number: 3112
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,987
-
Changes Since La
Allon Mureinik has posted comments on this change.
Change subject: core: add line number to logged statements
..
Patch Set 1: Looks good to me, but someone else must approve
I like this approach, but there seems to be a consens
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix logging level in several classes
..
core: Fix logging level in several classes
Log exceptions in error instead of debug
Log frequent actions
Allon Mureinik has posted comments on this change.
Change subject: core: Fix logging level in several classes
..
Patch Set 3: Verified; Looks good to me, approved
Rebased.
Only change is removal of the change to LoginBaseComma
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused import,fix log and comment
..
core: Remove unused import,fix log and comment
Remove unused import, unused class member, fix log exc
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused import,fix log and comment
..
Patch Set 3:
rebased, no code changes.
additional acks by Moti (+2) and Daniel (+1).
--
To view, visit http:/
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused import,fix log and comment
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10880
To unsubscri
Ayal Baron has posted comments on this change.
Change subject: core: improve logs in several classes
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10993
To unsubscribe
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Add install_devel target
..
Patch Set 3: (1 inline comment)
File Makefile
Line 459: echo "EN
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Updated cleanup to ignore DB if --dont-drop-db
supplied
..
packaging: Updated cleanup to ignore DB if --dont-drop-db supplied
This patch re
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Updated cleanup to ignore DB if --dont-drop-db
supplied
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.o
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: periodically check if ovirt-engine upgrade available
..
Patch Set 2:
./packaging/fedora/setup/engine-check-update is using the engine-upgrade which
is
1 - 100 of 339 matches
Mail list logo
