[Engine-patches] Change in ovirt-engine[master]: core: ImagesHandler cleanup: Generic warnings

[amureini]

Allon Mureinik has uploaded a new change for review.

Change subject: core: ImagesHandler cleanup: Generic warnings
......................................................................

core: ImagesHandler cleanup: Generic warnings

Cleaned up warnings about using raw types in PerformImagesChecks passing
a Collection that's intended as a Collection of Disks.

Change-Id: Iad9a2f228087e697fd718d8ecfce9b79b0374076
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/99/10999/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
index 495df2c..285d9ec 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
@@ -209,7 +209,7 @@
                 false,
                 false,
                 true,
-                Collections.emptyList());
+                Collections.<Disk> emptyList());
     }
 
     private double getRequestDiskSpace() {
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
index 4a87970..3b8203f 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
@@ -467,7 +467,7 @@
             boolean checkVmInPreview,
             boolean checkVmIsDown,
             boolean checkStorageDomain,
-            boolean checkIsValid, Collection diskImageList) {
+            boolean checkIsValid, Collection<? extends Disk> diskImageList) {
 
         boolean returnValue = true;
 
@@ -538,7 +538,7 @@
         return returnValue;
     }
 
-    private static List<DiskImage> getImages(VM vm, Collection<Disk> 
diskImageList) {
+    private static List<DiskImage> getImages(VM vm, Collection<? extends Disk> 
diskImageList) {
         if (diskImageList == null) {
             return 
filterImageDisks(DbFacade.getInstance().getDiskDao().getAllForVm(vm.getId()), 
true, false);
         }
@@ -642,7 +642,7 @@
      * @param filterAllowSnapshotDisks - Indication whether to filter disks 
which are allowed to be snapshot.
      * @return - List filtered of disk images.
      */
-    public static List<DiskImage> filterImageDisks(Collection<Disk> 
listOfDisks,
+    public static List<DiskImage> filterImageDisks(Collection<? extends Disk> 
listOfDisks,
             boolean filterNotShareableDisks,
             boolean filterAllowSnapshotDisks) {
         List<DiskImage> diskImages = new ArrayList<DiskImage>();


--
To view, visit http://gerrit.ovirt.org/10999
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad9a2f228087e697fd718d8ecfce9b79b0374076
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches