Allon Mureinik has uploaded a new change for review.
Change subject: core: ImagesHandler cleanup: unwrap else clauses
......................................................................
core: ImagesHandler cleanup: unwrap else clauses
Unwrapped useless else clauses where the if clause does not terminate
normally (breaks, returns, etc.).
Change-Id: I0d1a9ad5c01471c217973cd0a6907023564d841d
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/97/10997/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
index 8edf4dd..d9dc2f6 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
@@ -384,9 +384,9 @@
if (fromIrs == null) {
returnValue = false;
break;
- } else {
- irsImages.add(fromIrs);
}
+
+ irsImages.add(fromIrs);
}
return returnValue;
}
@@ -540,9 +540,9 @@
private static List<DiskImage> getImages(VM vm, Collection<Disk>
diskImageList) {
if (diskImageList == null) {
return
filterImageDisks(DbFacade.getInstance().getDiskDao().getAllForVm(vm.getId()),
true, false);
- } else {
- return filterImageDisks(diskImageList, true, false);
}
+
+ return filterImageDisks(diskImageList, true, false);
}
private static boolean checkDiskImages(List<String> messages,
--
To view, visit http://gerrit.ovirt.org/10997
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d1a9ad5c01471c217973cd0a6907023564d841d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
