Alon Bar-Lev has posted comments on this change. Change subject: packaging: Add install_devel target ......................................................................
Patch Set 3: (1 inline comment) .................................................... File Makefile Line 459: echo "ENGINE_DB_USER=postgres" >> $(DESTDIR)$(SYSCONF_DIR)/sysconfig/$(ENGINE_NAME) Line 460: echo "ENGINE_DB_PASSWORD=" >> $(DESTDIR)$(SYSCONF_DIR)/sysconfig/$(ENGINE_NAME) Line 461: Line 462: # Enable remote debugging in all IP addresses and port 8787: Line 463: echo "ENGINE_DEBUG_ADDRESS=0.0.0.0:8787" >> $(SYSCONF_DIR)/sysconfig/$(ENGINE_NAME) Is there a reason why not to keep these as a file and do: cat DEVELOPMENT_APPENDIX >> $(SYSCONF_DIR)/sysconfig/$(ENGINE_NAME) Also, please add quotes, it always healthy. Line 464: Line 465: # Create directories that the engine needs to run: Line 466: install -dm 755 $(DESTDIR)$(ENGINE_STATE) Line 467: install -dm 755 $(DESTDIR)$(ENGINE_STATE)/content -- To view, visit http://gerrit.ovirt.org/10984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I726af2b57b302750db4390dc5859a8ba36e59a2e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
