Allon Mureinik has posted comments on this change. Change subject: core: remove expensive use of ObjectDescriptor.toString ......................................................................
Patch Set 4: @Roy - seems so, yes. I was commenting that after your patch the only place the Jedi class will be used is in ObjectIdentityCheckerTest, and perhaps is a good idea to move it to be an inner class of that test. However, even if we decide to do so, I don't think it's mandatory for /this/ patch. -- To view, visit http://gerrit.ovirt.org/10356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0bb51579a9af1f76248cb1152e29ad7cb82d8a0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
