Allon Mureinik has posted comments on this change. Change subject: core: remove expensive use of ObjectDescriptor.toString ......................................................................
Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) should also be removed from common.gwt.xml, as Alissa commented. In addition, see small suggestion inline. .................................................... File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ObjectDescriptorTest.java Line 3 Line 4 Line 5 Line 6 Line 7 After removing this test, the only place using Jedi is ObjectIdentityCheckerTest. Perhaps it's worth while making Jedi an inner class over there? Not sure it should be part of /this/ patch though, -- To view, visit http://gerrit.ovirt.org/10356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0bb51579a9af1f76248cb1152e29ad7cb82d8a0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
