Asaf Shakarchi has posted comments on this change.
Change subject: engine: pom metainformation
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10575
To unsubscribe, visit http://gerrit.ovirt
Liron Aravot has posted comments on this change.
Change subject: core: avoid NPE on UpdateVM template command
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/10545
To unsubscribe, visit http://gerrit.ovirt.or
Liron Aravot has posted comments on this change.
Change subject: core: avoid unneeded db calls on update of BlankTemplate
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/10544
To unsubscribe, visit http://ger
quan.xu has abandoned this change.
Change subject: Xu Quan,Gerrit engine_3.1 init
..
Patch Set 1: Abandoned
need further debug
--
To view, visit http://gerrit.ovirt.org/10841
To unsubscribe, visit http://gerrit.ovirt.org/setti
quan.xu has abandoned this change.
Change subject: Xu Quan,Gerrit init
..
Patch Set 1: Abandoned
need further debug
--
To view, visit http://gerrit.ovirt.org/10816
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Yaniv Kaul has posted comments on this change.
Change subject: packaging: Change the timestamp of log rotation.
..
Patch Set 4: (2 inline comments)
The patch is incorrect. Please test and tell me if they have different
timesta
quan.xu has uploaded a new change for review.
Change subject: Xu Quan,Gerrit engine_3.1 init
..
Xu Quan,Gerrit engine_3.1 init
Change-Id: Ieefa94d8442c02ab3f058e7e906205cf130fcc8c
Signed-off-by: quan.xu
---
M Makefile
1 file ch
Liron Aravot has posted comments on this change.
Change subject: core: avoid unneeded db calls on update of BlankTemplate
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10544
To unsubscribe, visit http://ger
Liron Aravot has posted comments on this change.
Change subject: core: avoid NPE on UpdateVM template command
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10545
To unsubscribe, visit http://gerrit.ovirt.or
Daniel Erez has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10842
To unsubscribe, visit http://g
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] core: compensation should not clean entities with
associated tasks
..
Patch Set 4:
Barak,
I fully agree here.
This should not submitted without the rest
Yair Zaslavsky has posted comments on this change.
Change subject: core: add toString method to VM and VDS
..
Patch Set 6: (1 inline comment)
File
backend/manager/modules/co
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3208/
Build Number: 3208
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,919
-
Changes Since La
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3207/
Build Number: 3207
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,918
-
Changes Since
Moti Asayag has posted comments on this change.
Change subject: core: add toString method to VM and VDS
..
Patch Set 6: (2 inline comments)
Generally, i think that for debug purpose sometimes the ID can be helpful as
well.
..
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: sync miniyum with otopi
..
Patch Set 1:
Anyone?
--
To view, visit http://gerrit.ovirt.org/10725
To unsubscribe, visit http://gerrit.ovirt.org/settings
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: disks subtab - enable template disk removal
..
webadmin: disks subtab - enable template disk removal
Enable template disk removal in disks sub-t
Daniel Erez has posted comments on this change.
Change subject: webadmin: disks subtab - enable template disk removal
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/10817
Alon Bar-Lev has posted comments on this change.
Change subject: engine: remove Config dependency from frontend
..
Patch Set 2:
Merge?!?!
--
To view, visit http://gerrit.ovirt.org/10330
To unsubscribe, visit http://gerrit.ovir
Daniel Erez has submitted this change and it was merged.
Change subject: engine: modified title of index and 404 HTML pages
..
engine: modified title of index and 404 HTML pages
Modified title: 'OVirt' -> 'oVirt'
Change-Id: I7
Daniel Erez has posted comments on this change.
Change subject: engine: modified title of index and 404 HTML pages
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/10829
To
Daniel Erez has posted comments on this change.
Change subject: engine: modified title of index and 404 HTML pages
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10829
To unsubscribe, visit http://gerrit.ovi
Daniel Erez has submitted this change and it was merged.
Change subject: core: TarTest - assume Unix OS
..
core: TarTest - assume Unix OS
TarTest requires tar utility.
Therefore, ignoring test for non-Unix machines.
Change-Id:
Daniel Erez has posted comments on this change.
Change subject: core: TarTest - assume Unix OS
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/10739
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: core: TarTest - assume Unix OS
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10739
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Yair Zaslavsky has posted comments on this change.
Change subject: core:no task id in engine log for revert task
..
Patch Set 2: (1 inline comment)
File
backend/manager/modu
Yair Zaslavsky has posted comments on this change.
Change subject: core:no task id in engine log for revert task
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10804
To unsubscribe, visit h
Keith Robertson has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 2: (1 inline comment)
File src/engine-is
Frank Kobzik has posted comments on this change.
Change subject: frontend: "Disable strict user checking" option for server VMs
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10834
To unsubscribe, visit http
Frank Kobzik has uploaded a new change for review.
Change subject: frontend: "Disable strict user checking" option for server VMs
..
frontend: "Disable strict user checking" option for server VMs
This patch adds "Disable strict
Keith Robertson has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 2:
What problem are you trying to solve with this patch? As near as I can tell
you are only
Muli Salem has uploaded a new change for review.
Change subject: engine: Cleanup Logging in MacPoolManager
..
engine: Cleanup Logging in MacPoolManager
This patch cleans up the logging in MacPoolManager.
Change-Id: If7d47189fe6
Muli Salem has uploaded a new change for review.
Change subject: engine: Change Member Name to Lower Case
..
engine: Change Member Name to Lower Case
Change-Id: I95a7bcf2570166069122fc8053938007203094a1
Signed-off-by: Muli Salem
Muli Salem has uploaded a new change for review.
Change subject: engine: Make AllowDuplicateMacAddresses Reloadable
..
engine: Make AllowDuplicateMacAddresses Reloadable
This patch makes the AllowDuplicateMacAddresses
ConfigValu
Omer Frenkel has posted comments on this change.
Change subject: engine: Display warning before overtaking spice console
..
Patch Set 4: Looks good to me, but someone else must approve
maybe in a different patch but please also
Muli Salem has posted comments on this change.
Change subject: engine: Support Duplicate Mac Addresses
..
Patch Set 4: (5 inline comments)
File
backend/manager/modules/bll/s
Muli Salem has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/bll/src/main/jav
Frank Kobzik has posted comments on this change.
Change subject: engine: Display warning before overtaking spice console
..
Patch Set 4: Verified
Removed UpdateVmConsoleData command since we can rely on host events to unset
co
Einav Cohen has posted comments on this change.
Change subject: engine: modified title of index and 404 HTML pages
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10829
To unsubscribe, visit
Juan Hernandez has posted comments on this change.
Change subject: engine: modified title of index and 404 HTML pages
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/108
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Change the timestamp of log rotation.
..
Patch Set 4: (1 inline comment)
File packaging/resources
Roy Golan has uploaded a new change for review.
Change subject: core: fix NPE when mounting run once CD
..
core: fix NPE when mounting run once CD
A payload is valid a device (e.g. CD) that has specParams field set with a
struct
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: fixing buttons text misalignment
..
webadmin: fixing buttons text misalignment
Removed redundant 'margin-right:3px' from dialogButton template.
* Causin
Alissa Bonas has uploaded a new change for review.
Change subject: core: Improve logs in DbUserCacheManager
..
core: Improve logs in DbUserCacheManager
Make loggings in DbUserCacheManager more clear
Change-Id: I46c0cffd1280f278
Alissa Bonas has posted comments on this change.
Change subject: core: improve logging
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10823
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Mess
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/2969/
Build Number: 2969
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,917
-
Change
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 2: (1 inline comment)
File src/engine-iso-u
Alissa Bonas has uploaded a new change for review.
Change subject: core: improve logging
..
core: improve logging
This patch introduces several logging improvements, mostly around
backend classes initialized on system startup.
1
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/2968/
Build Number: 2968
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 3,916
Omer Frenkel has submitted this change and it was merged.
Change subject: core: fix to dao test
..
core: fix to dao test
this patch fixes VmAndTemplatesGenerationsDaoTest
testDeleteByOvfGenerations()
Change-Id: I70c1ca64762de3
Omer Frenkel has posted comments on this change.
Change subject: core: fix to dao test
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10822
To unsubscribe, visit http://gerrit.ovirt.org/set
Liron Aravot has posted comments on this change.
Change subject: core: fix to dao test
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10822
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Mess
Liron Aravot has uploaded a new change for review.
Change subject: core: fix to dao test
..
core: fix to dao test
this patch fixes VmAndTemplatesGenerationsDaoTest
testDeleteByOvfGenerations()
Change-Id: I70c1ca64762de3b5827cb1
ofri masad has posted comments on this change.
Change subject: webadmin: Add cluster policy to edit cluster
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10573
To unsubscribe, visit http://gerrit.ovirt.org/
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3106/
Build Number: 3106
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,914
-
Changes Since
Alex Lourie has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10815
To unsubscribe, visit http://gerrit.o
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Add cluster policy to edit cluster
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Moti Asayag has uploaded a new change for review.
Change subject: engine: AcrivateVdsCommand cleanup
..
engine: AcrivateVdsCommand cleanup
The patch performs few minor cleanups.
Change-Id: I7b407c035cbc094b314b3d26a4a1d679b8a83
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/2967/
Build Number: 2967
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 3,915
Oved Ourfali has posted comments on this change.
Change subject: core+ui: Add host notifications
..
Patch Set 2: Looks good to me, but someone else must approve
assuming you fix Doron's comment.
--
To view, visit http://gerrit
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3105/
Build Number: 3105
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,912,
Started by upstream project "ovirt_engine"
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/2966/
Build Number: 2966
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 3,914
Ravi Nori has posted comments on this change.
Change subject: restapi: wrong user id in /api/users//permissions(#890124)
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10581
To unsubscribe, visit http://gerr
Ravi Nori has posted comments on this change.
Change subject: restapi : error when adding disk with missing
parameters(#890524)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10820
To unsubscribe, visit htt
Ravi Nori has uploaded a new change for review.
Change subject: restapi : error when adding disk with missing
parameters(#890524)
..
restapi : error when adding disk with missing parameters(#890524)
When trying to add disk with
Greg Padgett has posted comments on this change.
Change subject: webadmin: improve behavior of bookmark list (2/2)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10819
To unsubscribe, visit http://gerrit.ovi
Greg Padgett has posted comments on this change.
Change subject: webadmin: improve behavior of bookmark list (1/2)
..
Patch Set 2: Verified
Rebased, split workaround for gwt issue into separate patch at
http://gerrit.ovirt.org
Greg Padgett has uploaded a new change for review.
Change subject: webadmin: improve behavior of bookmark list (2/2)
..
webadmin: improve behavior of bookmark list (2/2)
This patch series fixes some problems with the behavior of
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: updated setup to fail immediately if adding host
fails
..
Patch Set 2: (2 inline comments)
File p
Mike Kolesnik has posted comments on this change.
Change subject: engine: Support Duplicate Mac Addresses
..
Patch Set 4: (4 inline comments)
If you do plan on adding methods to the DAO, please add tests too.
.
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3202/
Build Number: 3202
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,911
-
Changes Since La
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/2965/
Build Number: 2965
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 3,913
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3104/
Build Number: 3104
Build Status: Still unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,911
-
Chang
oat.intel has uploaded a new change for review.
Change subject: oat.intel init
..
oat.intel init
Change-Id: I74e8d38f2d69caad66465b1359f1538238ae0475
Signed-off-by: oat.intel
---
M Makefile
1 file changed, 1 insertion(+), 0 del
quan.xu has uploaded a new change for review.
Change subject: Xu Quan,Gerrit init
..
Xu Quan,Gerrit init
Change-Id: Iaf622a05c9c53daa8ad7228ecfe904b3ad19e99e
Signed-off-by: quan.xu
---
M LICENSE
1 file changed, 1 insertion(+),
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Remove the pre search query command
..
core: Remove the pre search query command
This is no longer needed.
Change-Id: I2caadcdd801c8659c438bf7b9
Juan Hernandez has posted comments on this change.
Change subject: core: Remove the pre search query command
..
Patch Set 2: Verified; Looks good to me, approved
Merging based on previous approvals and verification.
--
To view
Doron Fediuck has posted comments on this change.
Change subject: core+ui: Add host notifications
..
Patch Set 2: (1 inline comment)
Commit Message
Line 8:
Line 9: This patc
Doron Fediuck has posted comments on this change.
Change subject: core+ui: Add host notifications
..
Patch Set 2: (1 inline comment)
File
frontend/webadmin/modules/uicompat/
Omer Frenkel has posted comments on this change.
Change subject: engine: Display warning before overtaking spice console
..
Patch Set 2: No score
please also add console_cur_user_name and consoleUserId to the ignored
propertie
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: enabled localization of input controls labels (#876138)
..
reports: enabled localization of input controls labels (#876138)
Bug-Url: https://bugzi
Yaniv Dary has posted comments on this change.
Change subject: reports: enabled localization of input controls labels (#876138)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1081
Gilad Chaplik has submitted this change and it was merged.
Change subject: db: fill consume quota role and clean up
..
db: fill consume quota role and clean up
add consume quota action group to consume quota role id,
only if mi
Gilad Chaplik has posted comments on this change.
Change subject: db: fill consume quota role and clean up
..
Patch Set 5: Verified; Looks good to me, approved
rebased, updated script name/number: 290->300
--
To view, visit ht
Tal Nisan has posted comments on this change.
Change subject: webadmin: disks subtab - enable template disk removal
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10817
To unsubscribe, visi
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: disks subtab - enable template disk removal
..
webadmin: disks subtab - enable template disk removal
Enable template disk removal in disks sub-tab
(unde
Omer Frenkel has posted comments on this change.
Change subject: engine: Display warning before overtaking spice console
..
Patch Set 2:
Roy just reminded me that we have an event of clientIp change when spice is
closed, do we
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/2964/
Build Number: 2964
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 3,912
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 1: (1 inline comment)
File src/engine-iso-u
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Add compression for server and jasperserver logs.
..
packaging: Add compression for server and jasperserver logs.
Added a copression for jas
Juan Hernandez has posted comments on this change.
Change subject: packaging: Add compression for server and jasperserver logs.
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1081
Juan Hernandez has posted comments on this change.
Change subject: packaging: Add compression for server and jasperserver logs.
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10811
To unsub
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Add compression for server and jasperserver logs.
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/10811
To unsubscribe, visit http:
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/2963/
Build Number: 2963
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 3,911
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Change vm_guest_interface_type.interface_name to text
..
engine: Change vm_guest_interface_type.interface_name to text
The interface name as repor
Moti Asayag has posted comments on this change.
Change subject: engine: Change vm_guest_interface_type.interface_name to text
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10814
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/2608/
Build Number: 2608
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Use temporary modules directory
..
packaging: Use temporary modules directory
The application server creates .jar.index files in the modules
Juan Hernandez has posted comments on this change.
Change subject: packaging: Use temporary modules directory
..
Patch Set 6: Verified; Looks good to me, approved
Merging based on previous acks and verification.
--
To view, vi
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Add compression for server and jasperserver logs.
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10811
To unsubscribe, visit http:
1 - 100 of 237 matches
Mail list logo
