Alissa Bonas has uploaded a new change for review.
Change subject: core: improve logging
......................................................................
core: improve logging
This patch introduces several logging improvements, mostly around
backend classes initialized on system startup.
1. Remove new Date() from logging statements - the timestamp is already
part of the log on each line, no need to write it twice
2. Wherever there are no parameters in log statement, just a string, call to
log.info
instead of infoFormat which performs several unneeded expensive transformations
on
strings.
3. Move initialization log statements to the classes which are
initialized, instead of putting them in the calling class.
4. Make the log statements more clear - instead of just mentioning
hardcoded name of class in the log, specify whether this is start/end of its
initialization so whoever reads the log can understand at which phase
the system is or at which point it failed/stuck.
5. Make logged class name extracted generically instead of hardcoding it
Change-Id: Iaea9c16e9913cdee4eef88de920e87bde8bc6b5d
Signed-off-by: Alissa Bonas <abo...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AuditLogCleanupManager.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsLoadBalancer.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryCleanupManager.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/job/ExecutionMessageDirector.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
14 files changed, 46 insertions(+), 50 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/23/10823/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
index 877f60f..09c1dbb 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
@@ -83,8 +83,7 @@
}
public void InitAsyncTaskManager() {
-
- log.info("AsyncTaskManager: Initialization of AsyncTaskManager
completed successfully.");
+ log.info("Initialization of AsyncTaskManager completed successfully.");
}
@OnTimerMethodAnnotation("_timer_Elapsed")
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AuditLogCleanupManager.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AuditLogCleanupManager.java
index 05afbbc..11abd60 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AuditLogCleanupManager.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AuditLogCleanupManager.java
@@ -23,6 +23,7 @@
}
private AuditLogCleanupManager() {
+ log.info("Start initializing " + this.getClass().getSimpleName());
Calendar calendar = new GregorianCalendar();
Date mAuditLogCleanupTime = Config.<DateTime>
GetValue(ConfigValues.AuditLogCleanupTime);
calendar.setTimeInMillis(mAuditLogCleanupTime.getTime());
@@ -33,6 +34,7 @@
log.info("Setting audit clean up manager to run at: " +
cronExpression);
SchedulerUtilQuartzImpl.getInstance().scheduleACronJob(this,
"OnTimer", new Class[] {}, new Object[] {},
cronExpression);
+ log.info("Finished initializing " + this.getClass().getSimpleName());
}
@OnTimerMethodAnnotation("OnTimer")
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java
index 86cb22b..2e77df7 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java
@@ -41,8 +41,10 @@
* Should be called by backend, schedules the execution as configured.
*/
void initialize() {
+ log.info("Start initializing " + this.getClass().getSimpleName());
SchedulerUtilQuartzImpl.getInstance().scheduleACronJob(this, "onTimer",
new Class<?>[] {}, new Object[] {}, Config.<String>
GetValue(ConfigValues.AutoRecoverySchedule));
+ log.info("Finished initializing " + this.getClass().getSimpleName());
}
/**
@@ -80,7 +82,6 @@
* @param actionType autorecovery action
* @param paramsCallback a closure to create the parameters for the
autorecovery action
* @param logMsg a user-readable name for the failing resource
type
- * @param counters counters for the failing resources to avoid
too frequent auditlog
*/
<T extends BusinessEntity<Guid>> void check(final AutoRecoverDAO<T> dao,
final VdcActionType actionType,
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
index 8a65b00..64255d9 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
@@ -2,7 +2,6 @@
import java.io.File;
import java.util.ArrayList;
-import java.util.Date;
import java.util.List;
import java.util.concurrent.TimeUnit;
@@ -100,6 +99,7 @@
VmHandler.Init();
VdsHandler.Init();
VmTemplateHandler.Init();
+ log.info("Completed initializing handlers");
}
private VDSBrokerFrontend _resourceManger;
@@ -158,7 +158,7 @@
*/
@Override
public void Initialize() {
- log.infoFormat("Start time: {0}", new Date());
+ log.info("Start initializing " + this.getClass().getSimpleName());
// When getting a proxy to this bean using JBoss embedded, the
initialize method is called for each method
// invocation on the proxy, as it is called by setup method which is
@PostConstruct - the initialized flag
// makes sure that initialization occurs only once per class (which is
ok, as this is a @Service)
@@ -172,42 +172,36 @@
Config.setConfigUtils(new DBConfigUtils());
_resourceManger = new VDSBrokerFrontendImpl();
+ log.info("Initialized VDSBrokerFrontend");
- log.infoFormat("VDSBrokerFrontend: {0}", new Date());
CpuFlagsManagerHandler.InitDictionaries();
- log.infoFormat("CpuFlagsManager: {0}", new Date());
+
// ResourceManager res = ResourceManager.Instance;
// Initialize the AuditLogCleanupManager
AuditLogCleanupManager.getInstance();
- log.infoFormat("AuditLogCleanupManager: {0}", new Date());
TagsDirector.getInstance().init();
- log.infoFormat("TagsDirector: {0}", new Date());
+
IsoDomainListSyncronizer.getInstance();
- log.infoFormat("IsoDomainListSyncronizer: {0}", new Date());
+
InitHandlers();
- log.infoFormat("InitHandlers: {0}", new Date());
final String AppErrorsFileName = "bundles/AppErrors.properties";
final String VdsErrorsFileName = "bundles/VdsmErrors.properties";
errorsTranslator = new ErrorTranslatorImpl(AppErrorsFileName,
VdsErrorsFileName);
- log.infoFormat("ErrorTranslator: {0}", new Date());
+
_vdsErrorsTranslator = new ErrorTranslatorImpl(VdsErrorsFileName);
- log.infoFormat("VdsErrorTranslator: {0}", new Date());
// initialize the JobRepository object and finalize non-terminated jobs
- log.infoFormat("Mark uncompleted jobs as {0}: {1}",
JobExecutionStatus.UNKNOWN.name(), new Date());
+ log.infoFormat("Mark incompleted jobs as {0}",
JobExecutionStatus.UNKNOWN.name());
initJobRepository();
// initializes the JobRepositoryCleanupManager
- log.infoFormat("JobRepositoryCleanupManager: {0}", new Date());
JobRepositoryCleanupManager.getInstance().initialize();
// initialize the AutoRecoveryManager
- log.infoFormat("AutoRecoveryManager: {0}", new Date());
AutoRecoveryManager.getInstance().initialize();
- log.infoFormat("ExecutionMessageDirector: {0}", new Date());
initExecutionMessageDirector();
Integer sessionTimoutInterval = Config.<Integer>
GetValue(ConfigValues.UserSessionTimeOutInterval);
@@ -258,6 +252,7 @@
} catch (RuntimeException e) {
log.error("Failed to initialize ExecutionMessageDirector", e);
}
+
}
/**
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java
index a6ae216..da4de37 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java
@@ -20,14 +20,17 @@
import org.ovirt.engine.core.utils.log.LogFactory;
public final class CpuFlagsManagerHandler {
+ private static final Log log =
LogFactory.getLog(CpuFlagsManagerHandler.class);
private static Map<Version, CpuFlagsManager> _managersDictionary =
new HashMap<Version, CpuFlagsManager>();
public static void InitDictionaries() {
+ log.info("Start initializing " +
CpuFlagsManagerHandler.class.getSimpleName());
_managersDictionary.clear();
for (Version ver : Config.<HashSet<Version>>
GetValue(ConfigValues.SupportedClusterLevels)) {
_managersDictionary.put(ver, new CpuFlagsManager(ver));
}
+ log.info("Finished initializing " +
CpuFlagsManagerHandler.class.getSimpleName());
}
public static String GetVDSVerbDataByCpuName(String name, Version ver) {
@@ -423,6 +426,5 @@
return server1Level - server2Level;
}
- private static final Log log =
LogFactory.getLog(CpuFlagsManagerHandler.class);
}
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
index 2bcb3d7..1680bdc 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
@@ -1,6 +1,5 @@
package org.ovirt.engine.core.bll;
-import java.util.Date;
import javax.annotation.PostConstruct;
import javax.ejb.DependsOn;
@@ -37,35 +36,29 @@
@Override
@PostConstruct
public void create() {
- log.infoFormat("InitResourceManager: {0}", new Date());
+
ResourceManager.getInstance().init();
AsyncTaskManager.getInstance().InitAsyncTaskManager();
- log.infoFormat("AsyncTaskManager: {0}", new Date());
OvfDataUpdater.getInstance().initOvfDataUpdater();
- log.infoFormat("OvfDataUpdater: {0}", new Date());
if (Config.<Boolean> GetValue(ConfigValues.EnableVdsLoadBalancing)) {
VdsLoadBalancer.EnableLoadBalancer();
}
- log.infoFormat("VdsLoadBalancer: {0}", new Date());
ThreadPoolUtil.execute(new Runnable() {
@Override
public void run() {
- log.infoFormat("MacPoolManager started: {0}", new Date());
MacPoolManager.getInstance().initialize();
- log.infoFormat("MacPoolManager finished: {0}", new Date());
}
});
StoragePoolStatusHandler.Init();
GlusterManager.getInstance().init();
try {
- log.infoFormat("Init VM Custom Properties utilities: {0}", new
Date());
+ log.info("Init VM Custom Properties utilities");
VmPropertiesUtils.getInstance().init();
} catch (InitializationException e) {
- log.errorFormat("Initialization failed. Exception message is {0}
",e.getMessage());
- log.debug("Initialization failed ",e);
+ log.error("Initialization failed",e);
throw new RuntimeException(e);
}
}
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
index 6fe591b..554c916 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
@@ -50,6 +50,7 @@
*/
@SuppressWarnings("synthetic-access")
public class IsoDomainListSyncronizer {
+ private static final Log log =
LogFactory.getLog(IsoDomainListSyncronizer.class);
private List<RepoFileMetaData> problematicRepoFileList = new
ArrayList<RepoFileMetaData>();
private static final int MIN_TO_MILLISECONDS = 60 * 1000;
private static final IsoDomainListSyncronizer isoDomainListSyncronizer =
new IsoDomainListSyncronizer();
@@ -72,6 +73,7 @@
* private constructor to initialize the quartz scheduler
*/
private IsoDomainListSyncronizer() {
+ log.info("Start initializing " + this.getClass().getSimpleName());
repoStorageDom = DbFacade.getInstance().getRepoFileMetaDataDao();
isoDomainRefreshRate = Config.<Integer>
GetValue(ConfigValues.AutoRepoDomainRefreshTime) * MIN_TO_MILLISECONDS;
SchedulerUtilQuartzImpl.getInstance().scheduleAFixedDelayJob(this,
@@ -81,6 +83,7 @@
300000,
isoDomainRefreshRate,
TimeUnit.MILLISECONDS);
+ log.info("Finished initializing " + this.getClass().getSimpleName());
}
/**
@@ -734,7 +737,6 @@
AuditLogDirector.log(logable,
AuditLogType.REFRESH_REPOSITORY_FILE_LIST_SUCCEEDED);
}
- private static final Log log =
LogFactory.getLog(IsoDomainListSyncronizer.class);
private boolean isStorageDomainValid(Guid storageDomainId,
FileTypeExtension fileTypeExtension, boolean forceRefresh) {
// Check storage domain Id validity.
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java
index db11fe8..eb9b2a1 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java
@@ -50,12 +50,13 @@
*/
protected void init() {
- log.info("TagsDirector initialization");
+ log.info("Start initializing " + this.getClass().getSimpleName());
tagsMapByID.clear();
tagsMapByName.clear();
tags root = new tags("root", null, true, ROOT_TAG_ID, "root");
AddTagToHash(root);
AddChildren(root);
+ log.info("Finished initializing " + this.getClass().getSimpleName());
}
@@ -234,8 +235,8 @@
/**
* This function will return the tag's ID and its parents IDs.
*
- * @param tagId
- * the tag ID.
+ * @param tagName
+ * the tag name.
* @return a comma seperated list of IDs.
*/
public String GetTagIdAndParentsIds(String tagName) {
@@ -295,7 +296,7 @@
* assigned to an entity. Tag is determined as assigned to an entity if
the entity is assigned to the tag or to one
* of its children.
*
- * @param tagName
+ * @param tagNameRegExp
* the name of the 'root' tag.
* @return a comma separated list of IDs.
*/
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsLoadBalancer.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsLoadBalancer.java
index de045eb..7830591 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsLoadBalancer.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsLoadBalancer.java
@@ -49,8 +49,10 @@
}
public static void EnableLoadBalancer() {
+ log.info("Start scheduling to enable load balancer");
SchedulerUtilQuartzImpl.getInstance().scheduleAFixedDelayJob(instance,
"PerformLoadBalancing", new Class[] {},
new Object[] {}, Config.<Integer>
GetValue(ConfigValues.VdsLoadBalancingeIntervalInMinutes),
Config.<Integer>
GetValue(ConfigValues.VdsLoadBalancingeIntervalInMinutes), TimeUnit.MINUTES);
+ log.info("Finished scheduling to enable load balancer");
}
}
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryCleanupManager.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryCleanupManager.java
index 83ed9b5..4b227de 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryCleanupManager.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryCleanupManager.java
@@ -29,6 +29,7 @@
* Initializes the Job Cleanup scheduler
*/
public void initialize() {
+ log.info("Start initializing " + this.getClass().getSimpleName());
succeededJobTime = Config.<Integer>
GetValue(ConfigValues.SucceededJobCleanupTimeInMinutes).intValue();
failedJobTime = Config.<Integer>
GetValue(ConfigValues.FailedJobCleanupTimeInMinutes).intValue();
@@ -40,6 +41,7 @@
cleanupFrequency,
cleanupFrequency,
TimeUnit.MINUTES);
+ log.info("Finished initializing " + this.getClass().getSimpleName());
}
/**
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
index 40afe72..73ee5f7 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
@@ -1,9 +1,6 @@
package org.ovirt.engine.core.bll.network;
-import java.util.HashSet;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Set;
+import java.util.*;
import java.util.concurrent.locks.ReentrantReadWriteLock;
import org.apache.commons.lang.StringUtils;
@@ -44,12 +41,13 @@
public void initialize() {
lockObj.writeLock().lock();
try {
+ log.info("Start initializing " + this.getClass().getSimpleName());
String ranges = Config.<String>
GetValue(ConfigValues.MacPoolRanges);
if (!"".equals(ranges)) {
try {
initRanges(ranges);
} catch (MacPoolExceededMaxException e) {
- log.errorFormat("MAC Pool range exceeded maximum number of
mac pool addressed. Please check Mac Pool configuration.");
+ log.error("MAC Pool range exceeded maximum number of mac
pool addressed. Please check Mac Pool configuration.");
}
}
@@ -58,9 +56,9 @@
addMac(iface.getMacAddress());
}
initialized = true;
+ log.info("Finished initializing " +
this.getClass().getSimpleName());
} catch (Exception ex) {
- log.debug(INIT_ERROR_MSG, ex);
- log.error(INIT_ERROR_MSG + "Exception message is: " +
ex.getMessage());
+ log.error(INIT_ERROR_MSG, ex);
} finally {
lockObj.writeLock().unlock();
}
diff --git
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/job/ExecutionMessageDirector.java
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/job/ExecutionMessageDirector.java
index 10f3c55..f94b959 100644
---
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/job/ExecutionMessageDirector.java
+++
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/job/ExecutionMessageDirector.java
@@ -57,6 +57,7 @@
* The base name of the resource bundle
*/
public void initialize(String bundleBaseName) {
+ log.info("Start initializing " + this.getClass().getSimpleName());
ResourceBundle bundle = ResourceBundle.getBundle(bundleBaseName);
final int jobMessagePrefixLength = JOB_MESSAGE_PREFIX.length();
final int stepMessagePrefixLength = STEP_MESSAGE_PREFIX.length();
@@ -74,6 +75,7 @@
STEP_MESSAGE_PREFIX);
}
}
+ log.info("Finished initializing " + this.getClass().getSimpleName());
}
/**
diff --git
a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
index 402a870..6a7cae8 100644
---
a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
+++
b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
@@ -1,11 +1,6 @@
package org.ovirt.engine.core.utils;
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Locale;
-import java.util.Map;
-import java.util.ResourceBundle;
+import java.util.*;
import org.apache.commons.lang.text.StrSubstitutor;
import org.apache.commons.lang.StringUtils;
@@ -16,7 +11,7 @@
public final class ErrorTranslatorImpl implements ErrorTranslator {
private static final long ONE_HOUR = 60 * 60 * 1000L;
-
+ private static Log log = LogFactory.getLog(ErrorTranslatorImpl.class);
private List<String> messageSources;
private Locale standardLocale;
private Map<String, String> standardMessages;
@@ -24,10 +19,12 @@
// Will assume these are property files, not ResxFiles.
public ErrorTranslatorImpl(String... errorFileNames) {
+ log.infoFormat("Start initializing " +
this.getClass().getSimpleName());
messageSources = asList(errorFileNames);
standardLocale = Locale.getDefault();
standardMessages = retrieveByLocale(standardLocale);
messagesByLocale = new ReapedMap<Locale, Map<String,
String>>(ONE_HOUR, true);
+ log.infoFormat("Finished initializing " +
this.getClass().getSimpleName());
}
private synchronized Map<String, String> getMessages(Locale locale) {
@@ -230,5 +227,4 @@
: name;
}
- private static Log log = LogFactory.getLog(ErrorTranslatorImpl.class);
}
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
index fa5e943..1d99bc4 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
@@ -59,7 +59,7 @@
}
public void init() {
- log.info("ResourceManager::ResourceManager::Entered");
+ log.info("Start initializing " + this.getClass().getSimpleName());
List<VDS> allVdsList = DbFacade.getInstance().getVdsDao().getAll();
HashSet<Guid> nonResponsiveVdss = new HashSet<Guid>();
for (VDS helper_vds : allVdsList) {
@@ -95,6 +95,7 @@
AddVds(curVds, true);
}
IrsBrokerCommand.Init();
+ log.info("Finished initializing " + this.getClass().getSimpleName());
}
public boolean AddAsyncRunningVm(Guid vmId) {
@@ -181,7 +182,7 @@
}
vdsManager.schedulJobs();
_vdsManagersDict.put(vds.getId(), vdsManager);
- log.infoFormat("ResourceManager::AddVds - VDS {0} was added to the
Resource Manager", vds.getId());
+ log.infoFormat("VDS {0} was added to the Resource Manager",
vds.getId());
}
--
To view, visit http://gerrit.ovirt.org/10823
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaea9c16e9913cdee4eef88de920e87bde8bc6b5d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
